Bug #28088 for GraphViz-Data-Structure: Graphviz 2.12 installed but Makefile.PL won't accept

Tue Jul 10 20:19:00 2007 unobe [...] cpan.org - Ticket created

Subject:

Graphviz 2.12 installed but Makefile.PL won't accept

When a Graphviz version greater than 2.9 is installed (e.g., 2.12), Makefile.PL wrongly asserts that the Graphviz is not greater than 2.2. A patch to fix the problem is attached.

Subject:

gds.patch

--- Makefile.PL.orig 2007-07-10 17:03:07.000000000 -0700 +++ Makefile.PL 2007-07-10 17:11:01.000000000 -0700 @@ -8,8 +8,10 @@ die "You must install the graphviz package (http://www.graphviz.org) before using this module.\n"; } else { - my ($v) = ($dot_version =~ /dot version (.*?) /); - die "You must have at least version 2.2 of dot to use this module" if ($v+0 < 2.2); + my (@v) = ($dot_version =~ /dot (?:- Graphviz) version (\d+)\.(\d+) /); + if ( $v[0] < 2 || $v[1] < 2 ) { + die "You must have at least version 2.2 of dot to use this module (found $v[0].$v[1])"; + } } WriteMakefile(

Tue Jul 10 20:21:25 2007 unobe [...] cpan.org - Correspondence added

On Tue Jul 10 20:19:00 2007, UNOBE wrote: Show quoted text

> When a Graphviz version greater than 2.9 is installed (e.g., 2.12), > Makefile.PL wrongly asserts that the Graphviz is not greater than 2.2. A > patch to fix the problem is attached.

Previous patch didn't retain backwards compatibility. for determining version from `dot`.

--- Makefile.PL.orig 2007-07-10 17:03:07.000000000 -0700 +++ Makefile.PL 2007-07-10 17:11:01.000000000 -0700 @@ -8,8 +8,10 @@ die "You must install the graphviz package (http://www.graphviz.org) before using this module.\n"; } else { - my ($v) = ($dot_version =~ /dot version (.*?) /); - die "You must have at least version 2.2 of dot to use this module" if ($v+0 < 2.2); + my (@v) = ($dot_version =~ /dot (?:- Graphviz )?version (\d+)\.(\d+) /); + if ( $v[0] < 2 || $v[1] < 2 ) { + die "You must have at least version 2.2 of dot to use this module (found $v[0].$v[1])"; + } } WriteMakefile(

Tue Jul 10 20:21:30 2007 The RT System itself - Status changed from 'new' to 'open'

Wed Jul 11 14:39:39 2007 mcmahon [...] yahoo-inc.com - Correspondence added

Subject:	Re: [rt.cpan.org #28088] Graphviz 2.12 installed but Makefile.PL won't accept
Date:	Wed, 11 Jul 2007 11:39:06 -0700
To:	bug-GraphViz-Data-Structure [...] rt.cpan.org
From:	Joe McMahon <mcmahon [...] yahoo-inc.com>

On Jul 10, 2007, at 5:19 PM, David Romano via RT wrote: Show quoted text

> > Tue Jul 10 20:19:00 2007: Request 28088 was acted upon. > Transaction: Ticket created by UNOBE > Queue: GraphViz-Data-Structure > Subject: Graphviz 2.12 installed but Makefile.PL won't accept > Broken in: 0.15 > Severity: Important > Owner: Nobody > Requestors: unobe@cpan.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=28088 > > > > When a Graphviz version greater than 2.9 is installed (e.g., 2.12), > Makefile.PL wrongly asserts that the Graphviz is not greater than > 2.2. A > patch to fix the problem is attached.<gds.patch>

Thanks. Applying and will push today. -- Joe M.

Wed Jul 11 18:07:25 2007 mcmahon [...] cpan.org - Correspondence added 20 min

The supplied patch seems to work fine here, but we do not have access to graphviz > 2.8 on our dev boxes. I've pushed out GraphViz::Data::Structure 0.16; can you verify that it works OK? If not, let's reopen this bug.

Wed Jul 11 18:07:27 2007 mcmahon [...] cpan.org - Status changed from 'open' to 'resolved'

Wed Jul 11 18:07:29 2007 mcmahon [...] cpan.org - Given to MCMAHON

Wed Jul 11 20:49:34 2007 unobe@cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #28088] Graphviz 2.12 installed but Makefile.PL won't accept
Date:	Wed, 11 Jul 2007 17:49:05 -0700
To:	Joe McMahon via RT <bug-GraphViz-Data-Structure [...] rt.cpan.org>
From:	David Romano <unobe [...] cpan.org>

Joe McMahon via RT wrote on Wed, Jul 11, 2007 at 03:07:27PM PDT: Show quoted text

> > <URL: http://rt.cpan.org/Ticket/Display.html?id=28088 > > > The supplied patch seems to work fine here, but we do not have access to graphviz > 2.8 on > our dev boxes. I've pushed out GraphViz::Data::Structure 0.16; can you verify that it works OK? > If not, let's reopen this bug.

It works. Sorry about replying to the other e-mail too, but thanks again :-) - David -- "It is well to remember that the entire universe, with one trifling exception, is composed of others." -- John Andrew Holmes

Wed Jul 11 20:49:40 2007 The RT System itself - Status changed from 'resolved' to 'open'

Wed Sep 19 21:24:35 2007 mcmahon [...] cpan.org - Correspondence added 15 min

Fixed (again!) in the latest CPAN release to support 2.12.3 (and similar release numbers).

Wed Sep 19 21:24:36 2007 mcmahon [...] cpan.org - Status changed from 'open' to 'resolved'