| Subject: | bug in Business-Tax-Vat-Validation |
| Date: | Tue, 10 Jul 2007 19:18:56 +0200 |
| To: | <bug-Business-Tax-VAT-Validation [...] rt.cpan.org> |
| From: | "Immofrance - Green-Acres" <admin [...] immofrance.com> |
Hi,
Module is great, but this version in not correct:
You included spaces in your patterns :
Old version :GB => '([0-9]{9}|[0-9]{12}|GD[0-9]{3}|HA[0-9]{3})',
is now
GB => '([0-9]{3} [0-9]{4} [0-9]{2}( [0-9]{3})?|GD[0-9]{3}|HA[0-9]{3})'
This break existing code as previous versions implied to remove white spaces. And now you make them mandatory (and users do not respect spaces patterns when entering there vat number). It should either be reverted back, or at list make the 'spaces' check optionnal.
This appart, thanks for this great module.
Benoit Galy