Skip Menu |

This queue is for tickets about the Digest-MD5 CPAN distribution.

Report information
The Basics
Id: 28079
Status: resolved
Priority: 0/
Queue: Digest-MD5

People
Owner: Nobody in particular
Requestors: SMPETERS [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] Assorted fixes from bleadperl
Since the last release of Digest::MD5, there have been a few fixes in bleadperl to Digest::MD5. These changes were made to make Perl compile cleaning with C++ compilers. --- MD5.xs 2005-11-26 05:06:20.000000000 -0600 +++ /home/steve/p4-bleadperl/perl/ext/Digest/MD5/MD5.xs 2006-12-29 20:24:57.0000 00000 -0600 @@ -587,7 +587,7 @@ SV* self PREINIT: MD5_CTX* cont = get_md5_ctx(aTHX_ self); - char *myname = sv_reftype(SvRV(self),TRUE); + const char *myname = sv_reftype(SvRV(self),TRUE); MD5_CTX* context; PPCODE: New(55, context, 1, MD5_CTX); @@ -713,8 +713,8 @@ } } if (msg) { - char *f = (ix == F_BIN) ? "md5" : - (ix == F_HEX) ? "md5_hex" : "md5_base64"; + const char *f = (ix == F_BIN) ? "md5" : + (ix == F_HEX) ? "md5_hex" : "md5_base64"; warn("&Digest::MD5::%s function %s", f, msg); } }
On Tue Jul 10 10:02:59 2007, SMPETERS wrote: Show quoted text
> Since the last release of Digest::MD5, there have been a few fixes in > bleadperl to Digest::MD5. These changes were made to make Perl compile > cleaning with C++ compilers. > > > --- MD5.xs 2005-11-26 05:06:20.000000000 -0600 > +++ /home/steve/p4-bleadperl/perl/ext/Digest/MD5/MD5.xs 2006-12-29 > 20:24:57.0000 > 00000 -0600 > @@ -587,7 +587,7 @@ > SV* self > PREINIT: > MD5_CTX* cont = get_md5_ctx(aTHX_ self); > - char *myname = sv_reftype(SvRV(self),TRUE); > + const char *myname = sv_reftype(SvRV(self),TRUE); > MD5_CTX* context; > PPCODE: > New(55, context, 1, MD5_CTX); > @@ -713,8 +713,8 @@ > } > } > if (msg) { > - char *f = (ix == F_BIN) ? "md5" : > - (ix == F_HEX) ? "md5_hex" : "md5_base64"; > + const char *f = (ix == F_BIN) ? "md5" : > + (ix == F_HEX) ? "md5_hex" : "md5_base64"; > warn("&Digest::MD5::%s function %s", f, msg); > } > }
Here's a newer version of the patch... --- Digest-MD5-2.36/MD5.pm 2005-11-30 07:46:47.000000000 -0600 +++ /home/steve/perl-current/ext/Digest/MD5/MD5.pm 2006-08-22 09:09:38.000000000 -0500 @@ -3,7 +3,7 @@ use strict; use vars qw($VERSION @ISA @EXPORT_OK); -$VERSION = '2.36'; # $Date: 2005/11/30 13:46:47 $ +$VERSION = '2.36_01'; # $Date: 2005/11/30 13:46:47 $ require Exporter; *import = \&Exporter::import; diff -ur Digest-MD5-2.36/MD5.xs /home/steve/perl-current/ext/Digest/MD5/MD5.xs --- Digest-MD5-2.36/MD5.xs 2005-11-26 05:06:20.000000000 -0600 +++ /home/steve/perl-current/ext/Digest/MD5/MD5.xs 2006-10-04 14:59:27.000000000 -0500 @@ -587,7 +587,7 @@ SV* self PREINIT: MD5_CTX* cont = get_md5_ctx(aTHX_ self); - char *myname = sv_reftype(SvRV(self),TRUE); + const char *myname = sv_reftype(SvRV(self),TRUE); MD5_CTX* context; PPCODE: New(55, context, 1, MD5_CTX); @@ -713,8 +713,8 @@ } } if (msg) { - char *f = (ix == F_BIN) ? "md5" : - (ix == F_HEX) ? "md5_hex" : "md5_base64"; + const char *f = (ix == F_BIN) ? "md5" : + (ix == F_HEX) ? "md5_hex" : "md5_base64"; warn("&Digest::MD5::%s function %s", f, msg); } } Only in /home/steve/perl-current/ext/Digest/MD5/: pm_to_blib Only in Digest-MD5-2.36: rfc1321.txt diff -ur Digest-MD5-2.36/t/files.t /home/steve/perl-current/ext/Digest/MD5/t/files.t --- Digest-MD5-2.36/t/files.t 2005-11-30 07:52:12.000000000 -0600 +++ /home/steve/perl-current/ext/Digest/MD5/t/files.t 2007-07-10 08:18:56.000000000 -0500 @@ -22,16 +22,16 @@ $EXPECT = <<EOT; c7b68bb806b2d42f4a11511132e94ae8 Changes 11e8028ee426273db6b6db270a8bb38c README -347d5b9f257eb62eaab60b3d952451f7 MD5.pm -b61eb1bba8cc490040d02f6bf24874f7 MD5.xs +c5e839f675f682215f913ea73788bc2c MD5.pm +d4b61fd6f875dcd3e3066a3d6750010e MD5.xs 276da0aa4e9a08b7fe09430c9c5690aa rfc1321.txt EOT } elsif ("\n" eq "\015") { # MacOS $EXPECT = <<EOT; 628699b88b6a803225678802d2470067 Changes c95549c6c5e1e1c078b27042f1dc850f README -77503ff007841a671275fdf544dad68e MD5.pm -716c3278fd80338727c100e5d2a76795 MD5.xs +e78ad7902025d17f140bef176dc4b154 MD5.pm +315f43d139c2ead64060d03b13b39ec5 MD5.xs 754b9db19f79dbc4992f7166eb0f37ce rfc1321.txt EOT } else { @@ -39,8 +39,8 @@ $EXPECT = <<EOT; 2fdc25c326960308f5334c967455d1f5 Changes c95549c6c5e1e1c078b27042f1dc850f README -77503ff007841a671275fdf544dad68e MD5.pm -716c3278fd80338727c100e5d2a76795 MD5.xs +e78ad7902025d17f140bef176dc4b154 MD5.pm +ef3c87d60a88b50c60eb75af81cd244a MD5.xs 754b9db19f79dbc4992f7166eb0f37ce rfc1321.txt EOT }
I synced up with blead today and uploaded 2.37 to CPAN.