Skip Menu |

This queue is for tickets about the Image-Info CPAN distribution.

Report information
The Basics
Id: 28054
Status: resolved
Priority: 0/
Queue: Image-Info
People
Owner: TELS [...] cpan.org
Requestors: adamk [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 1.25
Fixed in: (no value)
Attachments
achtung.png

History Show all quoted text
  Mon Jul 09 02:35:06 2007 adamk [...] cpan.org - Ticket created
Subject: Invalid warning in Image::Info::PNG
In the PNG parser, Image::Info::PNG, at around line 141 is the following. elsif ($type eq "zTXt" && $have_zlib) { my($key, $val) = split(/\0/, $data, 2); my($method,$ctext) = split(//, $val, 2); if ($method == 0) { $info->push_info(0, $key, Compress::Zlib::uncompress($ctext)); } else { $info->push_info(0, "Chunk-$type" => $data); } } From this, I am getting warnings. Argument "\0" isn't numeric in numeric eq (==) at /usr/local/share/perl/5.8.8/Image/Info/PNG.pm line 141. at /usr/local/share/perl/5.8.8/Image/Info/PNG.pm line 141 Image::Info::PNG::process_file('Image::Info::Result=ARRAY(0xa5c0b80)', 'GLOB(0xa5ebff0)', 'HASH(0x8e8932c)') called at /usr/local/share/perl/5.8.8/Image/Info.pm line 63 eval {...} called at /usr/local/share/perl/5.8.8/Image/Info.pm line 47 Image::Info::image_info('SCALAR(0xa1ddfd8)') called at lib/LocalVision/Image.pm line 33 So I think we need to change this... if ($method == 0) { ... to this ... if ($method eq "\0" or $method == 0) {
  Mon Jul 09 02:37:05 2007 adamk [...] cpan.org - Correspondence added
Actually, ignore this bug. I had an old version. Upgrading to the current version resolves my issue.
  Mon Jul 09 02:37:08 2007 adamk [...] cpan.org - Status changed from 'new' to 'open'
  Mon Jul 09 02:39:23 2007 adamk [...] cpan.org - Correspondence added
Actually, ignore my request to ignore this bug. :) It's still happening for me, so the fix is still needed.
  Mon Jul 09 10:30:33 2007 nospam-abuse [...] bloodgate.com - Correspondence added
Subject: Re: [rt.cpan.org #28054] Invalid warning in Image::Info::PNG
Date: Mon, 9 Jul 2007 16:30:59 +0200
To: bug-Image-Info [...] rt.cpan.org
From: Tels <nospam-abuse [...] bloodgate.com>
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Moin, On Monday 09 July 2007 08:39:25 via RT wrote: Show quoted text
> Queue: Image-Info > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=28054 > > > Actually, ignore my request to ignore this bug. :) > > It's still happening for me, so the fix is still needed.
Can you send me a small, preferable open/free image (so I can include it in the testsuite) that triggers this problem? Thanx for your report, Tels - -- Signed on Mon Jul 9 16:30:15 2007 with key 0x93B84C15. Get one of my photo posters: http://bloodgate.com/posters PGP key on http://bloodgate.com/tels.asc or per email. "There are three things I have always loved and never understood - art, music, and women." -- unknown -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iQEVAwUBRpJGrHcLPEOTuEwVAQIFVwf+NptY2jknyosroRVCIcRptgUCRwKrZgdQ edg/6WfCVTk+KJyBQaY47/ULsFh1p2sGYIBbUXToalZh5oSlTZ/4k0h51U61RCuC suQNfgnst6Yf4WlbzhDWIH/NRZGi4u3Um74pKpu2z9LQJEay++GsaDPFbyTI6U8F M110kz1eYfFjWCupphnhKa8kHwGv8Ps7gUkgP/MwkD62V0pqsBNi+2AfAhlzxc9b P5lW4dZorCq8RJRpOmPzp8UaZMHQLj3F2oE9rfb0FCWwtsMpLC/t/sJIW1IY4Ho4 9KxNrK5I/9E9KcXJK/rcgZ5y4CjT5FePm/ZMa1ZDeyJ4pSwpu6hULA== =GzVj -----END PGP SIGNATURE-----
  Sat Sep 08 13:19:26 2007 TELS [...] cpan.org - Taken
  Thu Jul 16 18:19:40 2009 SREZIC [...] cpan.org - Correspondence added
On Mon Jul 09 10:30:33 2007, nospam-abuse@bloodgate.com wrote: Show quoted text
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Moin, > > On Monday 09 July 2007 08:39:25 via RT wrote:
> > Queue: Image-Info > > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=28054 > > > > > Actually, ignore my request to ignore this bug. :) > > > > It's still happening for me, so the fix is still needed.
> > Can you send me a small, preferable open/free image (so I can include
it in Show quoted text
> the testsuite) that triggers this problem? > > Thanx for your report, >
The problem can be reproduced with a PNG image containing a compressed comment. This can be generated e.g. with the Image Edit > Comment menu in ImageMagick. I attached an example. Regards, Slaven
Download achtung.png
image/png 958b
achtung.png
  Thu Jul 16 18:23:45 2009 SREZIC [...] cpan.org - Correspondence added
On Thu Jul 16 18:19:40 2009, SREZIC wrote: Show quoted text
> On Mon Jul 09 10:30:33 2007, nospam-abuse@bloodgate.com wrote:
> > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > Moin, > > > > On Monday 09 July 2007 08:39:25 via RT wrote:
> > > Queue: Image-Info > > > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=28054 > > > > > > > Actually, ignore my request to ignore this bug. :) > > > > > > It's still happening for me, so the fix is still needed.
> > > > Can you send me a small, preferable open/free image (so I can include
> it in
> > the testsuite) that triggers this problem? > > > > Thanx for your report, > >
> > The problem can be reproduced with a PNG image containing a compressed > comment. This can be generated e.g. with the Image Edit > Comment menu > in ImageMagick. I attached an example. >
It seems that if ($method == 0) { really needs to be replaced by if ($method eq "\0") { I'll do this for the next release. Regards, Slaven
  Fri Jul 17 14:24:12 2009 SREZIC [...] cpan.org - Correspondence added
Fixed in 1.28_52.
  Fri Jul 17 14:24:14 2009 SREZIC [...] cpan.org - Status changed from 'open' to 'resolved'