Bug #27958 for DBIx-DBSchema: DBIx::DBSchema::Table still calling newly deprecated API.

Wed Jul 04 14:39:08 2007 jesse [...] bestpractical.com - Ticket created

Subject:	DBIx::DBSchema::Table still calling newly deprecated API.
Date:	Wed, 4 Jul 2007 14:37:09 -0400
To:	bug-dbix-dbschema [...] rt.cpan.org
From:	Jesse Vincent <jesse [...] bestpractical.com>

As I'm updating Jifty::DBI for the latest changes in DBIx::DBSchema, it looks like you're still calling the old ->unique and ->index APIs from within sql_create_table. Which makes my tests scream. Or am I doing something wrong? Best, Jesse [debugging output is from flipping carps to clucks] DBIx::DBSchema::Table->unique method is deprecated; see ->indices at / opt/local/lib/perl5/site_perl/5.8.8/DBIx/DBSchema/Table.pm line 384 DBIx::DBSchema::Table::unique('DBIx::DBSchema::Table=HASH (0x196f6c8)') called at /opt/local/lib/perl5/site_perl/5.8.8/DBIx/ DBSchema/Table.pm line 523 DBIx::DBSchema::Table::sql_create_table ('DBIx::DBSchema::Table=HASH(0x196f6c8)', 'DBI::db=HASH(0x195f124)') called at /opt/local/lib/perl5/site_perl/5.8.8/DBIx/DBSchema.pm line 237 DBIx::DBSchema::sql('DBIx::DBSchema=HASH(0x195f790)', 'DBI::db=HASH(0x195f124)') called at lib/Jifty/DBI/SchemaGenerator.pm line 222 Jifty::DBI::SchemaGenerator::create_table_sql_statements ('Jifty::DBI::SchemaGenerator=HASH(0x196ba34)') called at lib/Jifty/ DBI/SchemaGenerator.pm line 237 Jifty::DBI::SchemaGenerator::create_table_sql_text ('Jifty::DBI::SchemaGenerator=HASH(0x196ba34)') called at t/ 10schema.t line 124

Download PGP.sig
application/pgp-signature 186b

Message body not shown because it is not plain text.

Thu Jul 05 16:26:44 2007 ivan-pause [...] 420.am - Correspondence added

From:

ivan-pause [...] 420.am

On Wed Jul 04 14:39:08 2007, jesse@bestpractical.com wrote: Show quoted text

> > As I'm updating Jifty::DBI for the latest changes in DBIx::DBSchema, > it looks like you're still calling the old ->unique and ->index APIs > from within sql_create_table. Which makes my tests scream.

Yeah, the idea was to keep things backwards-compatible, so sql_create_table still calls the old methods. I"ll make sure that its quiet about it in the next version - should be fairly soon, someone sent in patches to add table and column deletion as well.

Thu Jul 05 16:26:46 2007 The RT System itself - Status changed from 'new' to 'open'

Thu Jul 05 16:35:26 2007 jesse [...] bestpractical.com - Correspondence added

Subject:	Re: [rt.cpan.org #27958] DBIx::DBSchema::Table still calling newly deprecated API.
Date:	Thu, 5 Jul 2007 16:35:08 -0400
To:	bug-DBIx-DBSchema [...] rt.cpan.org
From:	Jesse Vincent <jesse [...] bestpractical.com>

On Jul 5, 2007, at 4:26 PM, Ivan Kohler via RT wrote: Show quoted text

> > <URL: http://rt.cpan.org/Ticket/Display.html?id=27958 > > > On Wed Jul 04 14:39:08 2007, jesse@bestpractical.com wrote:

>> >> As I'm updating Jifty::DBI for the latest changes in DBIx::DBSchema, >> it looks like you're still calling the old ->unique and ->index APIs >> from within sql_create_table. Which makes my tests scream.

> > Yeah, the idea was to keep things backwards-compatible,

It wasn't 100%, mostly due to generating equivalent but not exactly equivalent SQL. It actually broke Jifty::DBI, but it was a fairly easy fix (and quite easily arguably our fault). Show quoted text

> so > sql_create_table still calls the old methods. I"ll make sure that its > quiet about it in the next version - should be fairly soon,

Lovely. I've got clueless Jifty users flipping out since the test suite is now _Full_ of warns. So a release soon would help a bunch. Thanks! Show quoted text

> someone > sent in patches to add table and column deletion as well.

Ah, cool. we're already doing that locally. it'd be nice to further abstract out.

Download PGP.sig
application/pgp-signature 186b

Message body not shown because it is not plain text.

Tue Aug 14 19:13:29 2007 ivan-pause [...] 420.am - Severity Normal added

Tue Aug 14 19:13:29 2007 ivan-pause [...] 420.am - Broken in 0.33 added

Thu Sep 06 18:21:14 2007 ivan-pause [...] 420.am - Status changed from 'open' to 'resolved'

Thu Sep 06 18:21:51 2007 ivan-pause [...] 420.am - Fixed in 0.34 added