Skip Menu |

This queue is for tickets about the Filesys-DiskFree CPAN distribution.

Report information
The Basics
Id: 27940
Status: open
Priority: 0/
Queue: Filesys-DiskFree
People
Owner: Nobody in particular
Requestors: Michael.Weinberger [...] neddix.de
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Tue Jul 03 10:28:19 2007 Michael.Weinberger [...] neddix.de - Ticket created
Subject: Filesys::DiskFree requires LANG=en_US
Date: Tue, 3 Jul 2007 14:27:29 -0000
To: bug-Filesys-DiskFree [...] rt.cpan.org
From: Michael Weinberger <Michael.Weinberger [...] neddix.de>
The header line of the df -P command output is not recognized when environment variable LANG is not equal to en_US. Example: export LANG="fr_CA" echo 'use Filesys::DiskFree;$df=new Filesys::DiskFree;$df->df();'|perl -w OUTPUT: Argument "de" isn't numeric in multiplication (*) at /usr/lib/perl5/vendor_perl/5.8.5/Filesys/DiskFree.pm line 144, <HANDLE> line 1. Argument "fich." isn't numeric in multiplication (*) at /usr/lib/perl5/vendor_perl/5.8.5/Filesys/DiskFree.pm line 145, <HANDLE> line 1. Argument "1024-blocs" isn't numeric in multiplication (*) at /usr/lib/perl5/vendor_perl/5.8.5/Filesys/DiskFree.pm line 146, <HANDLE> line 1. SYSTEM: Linux sme7 2.6.9-55.ELsmp #1 SMP Wed May 2 14:28:44 EDT 2007 i686 i686 i386 GNU/Linux Perl, v5.8.5 built for i386-linux-thread-multi Michael Weinberger
  Mon Feb 16 05:23:57 2009 wwwnick [...] hp.com - Correspondence added
Attached patch to work with any locale On Tue Jul 03 10:28:19 2007, Michael.Weinberger@neddix.de wrote: Show quoted text
> > The header line of the df -P command output is not recognized when > environment variable LANG is not equal to en_US. > > Example: > export LANG="fr_CA" > echo 'use Filesys::DiskFree;$df=new Filesys::DiskFree;$df->df();'|perl > -w > > OUTPUT: > Argument "de" isn't numeric in multiplication (*) at > /usr/lib/perl5/vendor_perl/5.8.5/Filesys/DiskFree.pm line 144, > <HANDLE> line 1. > Argument "fich." isn't numeric in multiplication (*) at > /usr/lib/perl5/vendor_perl/5.8.5/Filesys/DiskFree.pm line 145, > <HANDLE> line 1. > Argument "1024-blocs" isn't numeric in multiplication (*) at > /usr/lib/perl5/vendor_perl/5.8.5/Filesys/DiskFree.pm line 146, > <HANDLE> line 1. > > SYSTEM: > Linux sme7 2.6.9-55.ELsmp #1 SMP Wed May 2 14:28:44 EDT 2007 i686 i686 > i386 GNU/Linux > Perl, v5.8.5 built for i386-linux-thread-multi > > Michael Weinberger
--- DiskFree.pm 2009-02-20 19:14:05.293042880 +0100 +++ DiskFree.pm 2009-02-20 19:28:27.166018272 +0100 @@ -116,9 +116,11 @@ sub load() { my $self=shift; my $handle=shift; + my $lineno=0; if(ref $handle eq "GLOB"){ while(<$handle>){ + next if !$lineno; $self->readline($_); } } else {
  Mon Feb 16 05:23:59 2009 The RT System itself - Status changed from 'new' to 'open'
  Mon Feb 16 06:08:27 2009 wwwnick [...] hp.com - Correspondence added
attached correct patch :)
--- DiskFree.pm 2009-02-20 19:14:05.293042880 +0100 +++ DiskFree.pm 2009-02-20 19:28:27.166018272 +0100 @@ -116,9 +116,13 @@ sub load() { my $self=shift; my $handle=shift; - + my $lineno=0; if(ref $handle eq "GLOB"){ while(<$handle>){ + if (!$lineno) { + $lineno++; + next; + } $self->readline($_); } } else {