Skip Menu |

This queue is for tickets about the Net-Ping CPAN distribution.

Report information
The Basics
Id: 27915
Status: resolved
Priority: 0/
Queue: Net-Ping

People
Owner: Nobody in particular
Requestors: RURBAN [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 2.31
Fixed in: (no value)



Subject: fix icmp test: cygwin requires admin also
Attached patch by Jan Dubois (to blead, please use -p2) fixes a test issue for cygwin users which are not admin. http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2007-07/msg00143.html -- Reini Urban
Subject: pl-ping-t-500.patch
diff -ub perl-current/lib/Net/Ping/t/500_ping_icmp.t.orig perl-current/lib/Net/Ping/t/500_ping_icmp.t --- perl-current/lib/Net/Ping/t/500_ping_icmp.t.orig 2006-06-13 19:29:17.000000000 +0000 +++ perl-current/lib/Net/Ping/t/500_ping_icmp.t 2007-07-02 22:03:01.461375000 +0000 @@ -15,8 +15,8 @@ # Everything loaded fine ok 1; -if (($> and $^O ne 'VMS' and $^O ne 'cygwin') - or ($^O eq 'MSWin32' +if (($> and $^O ne 'VMS') + or (($^O eq 'MSWin32' or $^O eq 'cygwin') and !IsAdminUser()) or ($^O eq 'VMS' and (`write sys\$output f\$privilege("SYSPRV")` =~ m/FALSE/))) { @@ -29,7 +29,7 @@ } sub IsAdminUser { - return unless $^O eq 'MSWin32'; + return unless $^O eq 'MSWin32' or $^O eq 'cygwin'; return unless eval { require Win32 }; return unless defined &Win32::IsAdminUser; return Win32::IsAdminUser();
From: SMPETERS [...] cpan.org
On Mon Jul 02 18:30:58 2007, RURBAN wrote: Show quoted text
> Attached patch by Jan Dubois (to blead, please use -p2) fixes a test > issue for cygwin users which are not admin. >
http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2007-07/msg00143.html This patch is also included in RT #28348, but with all the accumulated fixes.
On Mon Jul 30 09:14:22 2007, SMPETERS wrote: Show quoted text
> On Mon Jul 02 18:30:58 2007, RURBAN wrote:
> > Attached patch by Jan Dubois (to blead, please use -p2) fixes a test > > issue for cygwin users which are not admin. > >
>
http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2007-07/msg00143.html Show quoted text
> > This patch is also included in RT #28348, but with all the accumulated > fixes.
Applied as version 2.32.