Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Email-Send CPAN distribution.

Report information
The Basics
Id: 27798
Status: resolved
Priority: 0/
Queue: Email-Send
People
Owner: Nobody in particular
Requestors: tmetro [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Unimportant
Broken in: 2.00
Fixed in: (no value)

History Show all quoted text
  Thu Jun 28 20:41:37 2007 tmetro [...] cpan.org - Ticket created
Subject: POD bugs
http://search.cpan.org/~rjbs/Email-Send-2.185/lib/Email/Send.pm#Writing_Mailers Show quoted text
> Here's an example of a mailer that sends email to a URL. > > package Email::Send::HTTP::Post; > use strict;
... Show quoted text
> sub send { > my ($class, $message, @args);
That last line is missing a "= @_". Also, the documentation for send should more explicitly define what the return value is. I had to dig into the source to see that it is a Return::Value object typically, but I believe it actually is just passing on the value of the mailer plug-in, yet the documentation on writing mailers also doesn't specify what they should return (though the examples clearly show Return::Value objects. -Tom
  Thu Jun 28 21:17:58 2007 rjbs [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #27798] POD bugs
Date: Thu, 28 Jun 2007 21:17:40 -0400
To: Tom Metro via RT <bug-Email-Send [...] rt.cpan.org>
From: Ricardo SIGNES <rjbs [...] cpan.org>
* Tom Metro via RT <bug-Email-Send@rt.cpan.org> [2007-06-28T20:41:41] Show quoted text
> > sub send { > > my ($class, $message, @args);
> > That last line is missing a "= @_".
Thanks! Show quoted text
> Also, the documentation for send should more explicitly define what the > return value is. I had to dig into the source to see that it is a > Return::Value object typically, but I believe it actually is just > passing on the value of the mailer plug-in, yet the documentation on > writing mailers also doesn't specify what they should return (though the > examples clearly show Return::Value objects.
Yeah, this problem is likely to be fixed in the Email::Send replacement currently under development. The API is so poorly defined (both because it lacks definition and because the chosen definition is a bad idea) that we are more likely to move on than fix it. I'll have a look at the existing released modules to see if I can say that Return::Value should be used. I've just gotten back from YAPC North America, and there are lots of idaes that need to be transcriibed and sent to the PEP list, which may happen after I've had a shower, sleep and a shave. ;) -- rjbs
  Thu Jun 28 21:17:59 2007 The RT System itself - Status changed from 'new' to 'open'
  Thu Nov 01 22:54:21 2007 rjbs [...] cpan.org - Correspondence added
The POD bug is now fixed, and the other bugs will be addressed by the replacement of Email::Send. -- rjbs
  Thu Nov 01 22:54:23 2007 rjbs [...] cpan.org - Status changed from 'open' to 'resolved'