I'm still interested in getting this fixed, but I'll need to know the
repo address (it's not in the docs), as well as what username and
password to use. I guessed that my PAUSE username/password might work,
but they didn't.
Because I forgot this bug existed in Parse::CSV, I tried to use it
again, and will need to switch to raw Text::CSV_XS until this is fixed.
I also noticed that Parse::CSV hardcodes within it the options to new()
that Text::CSV_XS accepts. This means it needs to be maintained as
Text::CSV_XS adds more options (and it already added one). It seems
perhaps cleaner for Parse::CSV to keep track of its own options, and
pass everything else to Text::CSV_XS.
Mark
On Tue Dec 11 22:59:15 2007, adamkennedybackup@gmail.com wrote:
Show quoted text> I don't typically accept patches as such (as I'm terrible with them),
> my
> normal preference is to provide contributors commit access to the
> repository
> and have them apply the improvements directly.
>
> That said, if Mark is willing to apply any patch, you are welcome to
> provide
> one.
>
> Adam K
>
> On 12/12/2007, MARKSTOS via RT <bug-Parse-CSV@rt.cpan.org> wrote:
> >
> >
> > Queue: Parse-CSV
> > Ticket <URL:
http://rt.cpan.org/Ticket/Display.html?id=27734 >
> >
> > On Mon Jun 25 14:11:11 2007, amain@wested.org wrote:
> > > Hello Adam,
> > >
> > > I'm working with you lovely Parse::CSV module and have a couple
> features
> > > I'd like to add:
> > >
> > > * Support for a fields() method, so I don't have to do $parser-
> >{fields}
> > > to get the field names (using fields => 'auto') before I start
> parsing
> > > the body of the file.
> > >
> > > * Support for embedded newlines--right now _getline uses:
> > >
> > > my $line = <$handle>;
> > >
> > > Rather than
> > >
> > > my $line = $csv->getline($handle)
> > >
> > >
> >
> >
http://search.cpan.org/~hmbrand/Text-CSV_XS-
> 0.29/CSV_XS.pm#Embedded_newlines
> > >
> > > Just wanted to confirm that you're accepting patches before I code
> this
> > > up with a some test cases.
> > >
> > > Thanks so much!
> > >
> > > -Andrew
> >
> > Andrew,
> >
> > Please proceed with a patch and post it here. Even if Adam doesn't
> > accept it (and I suspect he would), the rest of us will benefit by
> > having the patch in an easy-to-find public place, so we can patch
> our
> > own copies if we'd like.
> >
> > I for one also am interested in embedded newline support and am a
> fan of
> > Parse::CSV.
> >
> >
> >
> >
> >
