Bug #27721 for Module-Depends: File::chdir 0.08 breaks Module::Depends 0.12

Mon Jun 25 00:45:10 2007 ANDK [...] cpan.org - Ticket created

CC:	DAGOLDEN [...] cpan.org
Subject:	File::chdir 0.08 breaks Module::Depends 0.12

RCLAMP/Module-Depends-0.12.tar.gz /usr/bin/make -- OK Running make test CPAN: CPAN::Reporter loaded ok (v0.44) PERL_DL_NONLAZY=1 /home/src/perl/repoperls/installed-perls/perl/pVSGU0p/perl-5.8.0@31443/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/depends....Failed to change directory to '/home/sand/.cpan/build/Module-Depends-0.12-hZuYHR/t/no-such-dir' at /home/sand/.cpan/build/Module-Depends-0.12-hZuYHR/blib/lib/Module/Depends.pm line 66 # Looks like you planned 17 tests but only ran 7. # Looks like your test died just after 7. dubious Test returned status 255 (wstat 65280, 0xff00) DIED. FAILED tests 8-17 Failed 10/17 tests, 41.18% okay Failed Test Stat Wstat Total Fail List of Failed ------------------------------------------------------------------------------- t/depends.t 255 65280 17 20 8-17 Failed 1/1 test scripts. 10/17 subtests failed. Files=1, Tests=17, 2 wallclock secs ( 0.57 cusr + 0.04 csys = 0.61 CPU) Downgrading to DAGOLDEN/File-chdir-0.07.tar.gz fixes the tests: RCLAMP/Module-Depends-0.12.tar.gz /usr/bin/make -- OK Running make test PERL_DL_NONLAZY=1 /home/src/perl/repoperls/installed-perls/perl/pVSGU0p/perl-5.8.0@31443/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/depends....Subroutine main::build_requires redefined at /home/src/perl/repoperls/installed-perls/perl/pVSGU0p/perl-5.8.0@31443/lib/5.9.5/Exporter.pm line 66. at Makefile.PL line 3 Subroutine main::include_deps redefined at /home/src/perl/repoperls/installed-perls/perl/pVSGU0p/perl-5.8.0@31443/lib/5.9.5/Exporter.pm line 66. at Makefile.PL line 3 Subroutine main::requires redefined at /home/src/perl/repoperls/installed-perls/perl/pVSGU0p/perl-5.8.0@31443/lib/5.9.5/Exporter.pm line 66. at Makefile.PL line 3 ok All tests successful. Files=1, Tests=17, 3 wallclock secs ( 0.84 cusr + 0.06 csys = 0.90 CPU) I have not checked which behaviour I find more appropriate just wanted to let you know. CC'd to DAGOLDEN@cpan.org.

Mon Jun 25 16:45:11 2007 dagolden [...] cpan.org - Correspondence added

File::chdir 0.08 throws an exception when changing directories fails. This patch on Module::Depends 0.12 passes tests: --- lib/Module/Depends.pm.orig 2007-06-25 16:35:57.000000000 -0400 +++ lib/Module/Depends.pm 2007-06-25 16:40:48.000000000 -0400 @@ -63,10 +63,13 @@ my $going_to = Cwd::realpath( File::Spec->rel2abs( $self->dist_dir ) ); - local $CWD = $going_to; - $CWD eq $going_to - ? $self->_find_modules - : $self->error( "couldn't chdir to " . $self->dist_dir . ": $!" ); + eval { + local $CWD = $going_to; + $self->_find_modules; + }; + if ($@) { + $self->error( "couldn't chdir to " . $self->dist_dir . ": $!" ) + } return $self; }

Mon Jun 25 16:45:12 2007 The RT System itself - Status changed from 'new' to 'open'

Tue Jun 26 07:54:12 2007 RCLAMP [...] cpan.org - Correspondence added

From:

RCLAMP [...] cpan.org

On Mon Jun 25 16:45:11 2007, DAGOLDEN wrote: Show quoted text

> File::chdir 0.08 throws an exception when changing directories fails. > This patch on Module::Depends 0.12 passes tests:

But of course makes them fail with an older version of File::chdir in the mix. Changing your key behavior in a minor revision is the suck. -- Richard Clamp <richardc@unixbeard.net>

Tue Jun 26 08:47:57 2007 RCLAMP [...] cpan.org - Correspondence added

On Mon Jun 25 00:45:10 2007, ANDK wrote: Show quoted text

> t/depends....Failed to change directory to > '/home/sand/.cpan/build/Module-Depends-0.12-hZuYHR/t/no-such-dir' at > /home/sand/.cpan/build/Module-Depends-0.12- > hZuYHR/blib/lib/Module/Depends.pm > line 66 > # Looks like you planned 17 tests but only ran 7. > # Looks like your test died just after 7. > dubious > Test returned status 255 (wstat 65280, 0xff00) > DIED. FAILED tests 8-17

Show quoted text

> > I have not checked which behaviour I find more appropriate just > wanted > to let you know.

Module::Depends 0.13, released to CPAN today, no longer uses File::chdir so is now immune from whatever fun and games they choose to play with their apis in the future. -- Richard Clamp <richardc@unixbeard.net>

Tue Jun 26 08:48:00 2007 RCLAMP [...] cpan.org - Status changed from 'open' to 'resolved'