Bug #27663 for Graph-Easy: no subgroups with Graph::Easy::Group

Wed Jun 20 12:52:23 2007 notbenh [...] cpan.org - Ticket created

Subject:

no subgroups with Graph::Easy::Group

I've included an example, from what the docs say, those groups should be nested. I took a peek at the code and didn't see anything that jumped out at me. Though I have not dug very deep.

Subject:

GE_test.pl

#!/usr/bin/perl use strict; use warnings; use Graph::Easy; my $g = Graph::Easy->new; my $a = $g->add_group('A'); my $b = $g->add_group('B'); my $c = $g->add_group('C'); my $n1 = $g->add_node('one'); my $n2 = $g->add_node('two'); my $n3 = $g->add_node('three'); $c->add_member($n1); $b->add_member($c); $b->add_member($n2); $a->add_member($b); $a->add_member($n3); print $g->as_ascii();

Wed Jun 20 13:02:28 2007 nospam-abuse [...] bloodgate.com - Correspondence added

Subject:	Re: [rt.cpan.org #27663] no subgroups with Graph::Easy::Group
Date:	Wed, 20 Jun 2007 19:02:08 +0200
To:	bug-Graph-Easy [...] rt.cpan.org
From:	Tels <nospam-abuse [...] bloodgate.com>

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, On Wednesday 20 June 2007 18:52:25 Ben Hengst via RT wrote: Show quoted text

> Wed Jun 20 12:52:23 2007: Request 27663 was acted upon. > Transaction: Ticket created by NOTBENH > Queue: Graph-Easy > Subject: no subgroups with Graph::Easy::Group > Broken in: (no value) > Severity: Important > Owner: Nobody > Requestors: notbenh@cpan.org > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=27663 > > > > I've included an example, from what the docs say, those groups should be > nested. I took a peek at the code and didn't see anything that jumped > out at me. Though I have not dug very deep.

The reason is that the layouter is not really nested yet - it needs to call the as_ascii() for each group, and then assemble them in the order inner => outer. At the moment this is simple not implemented - sorry :/ All the best, Tels - -- Signed on Wed Jun 20 19:01:17 2007 with key 0x93B84C15. View my photo gallery: http://bloodgate.com/photos PGP key on http://bloodgate.com/tels.asc or per email. "When you don't know what to do, walk fast and look worried." -- Unknown -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iQEVAwUBRnldkHcLPEOTuEwVAQKQ/gf8CuhFXCdnNgqXpxYA0BMIK9AbzCWKQn0Y 512zkfwLfcFcJfF5XaK9PVOxpk0CRN6wXYyEPvxoKuNOgw3QscHiVimvu8RmYBK6 T6goenb6qpgYjxfN422lOMzri5HT5OpPDe1VCZjeIhucFDefIn+aDUNM2ZzR/b2q hqKxSpwpmaK6USSCrbU/F6OhFNPsZw4/4IbUyY7Li4/a3/Bu1R7eVHXX9d4YQwFY Or1VkWgyrJUeWOqr8R7hUlyyK7/wSVXjMIPdaOBArU0tkZrxUh4EKBlhDKwkOGnU SyHZWlE89y9CmRTjPNGLXXopYyLK4aaBxY57258OHeZBSnl5q/rHNA== =olMK -----END PGP SIGNATURE-----

Wed Jun 20 13:02:30 2007 The RT System itself - Status changed from 'new' to 'open'

Wed Jun 20 13:46:59 2007 ben.hengst [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #27663] no subgroups with Graph::Easy::Group
Date:	Wed, 20 Jun 2007 10:46:41 -0700
To:	bug-Graph-Easy [...] rt.cpan.org
From:	benh <ben.hengst [...] gmail.com>

it's ok that it's not set up yet... but the docs dont say anything about it. also I found something else in the docs as_graphviz_txt() gets mentioned twice in E::G::Node though if called it's not there? On 6/20/07, nospam-abuse@bloodgate.com via RT <bug-Graph-Easy@rt.cpan.org> wrote: Show quoted text

> > <URL: http://rt.cpan.org/Ticket/Display.html?id=27663 > > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hello, > > On Wednesday 20 June 2007 18:52:25 Ben Hengst via RT wrote:

> > Wed Jun 20 12:52:23 2007: Request 27663 was acted upon. > > Transaction: Ticket created by NOTBENH > > Queue: Graph-Easy > > Subject: no subgroups with Graph::Easy::Group > > Broken in: (no value) > > Severity: Important > > Owner: Nobody > > Requestors: notbenh@cpan.org > > Status: new > > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=27663 > > > > > > > I've included an example, from what the docs say, those groups should be > > nested. I took a peek at the code and didn't see anything that jumped > > out at me. Though I have not dug very deep.

> > The reason is that the layouter is not really nested yet - it needs to call > the as_ascii() for each group, and then assemble them in the order inner => > outer. > > At the moment this is simple not implemented - sorry :/ > > All the best, > > Tels > > - -- > Signed on Wed Jun 20 19:01:17 2007 with key 0x93B84C15. > View my photo gallery: http://bloodgate.com/photos > PGP key on http://bloodgate.com/tels.asc or per email. > > "When you don't know what to do, walk fast and look worried." > > -- Unknown > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.2 (GNU/Linux) > > iQEVAwUBRnldkHcLPEOTuEwVAQKQ/gf8CuhFXCdnNgqXpxYA0BMIK9AbzCWKQn0Y > 512zkfwLfcFcJfF5XaK9PVOxpk0CRN6wXYyEPvxoKuNOgw3QscHiVimvu8RmYBK6 > T6goenb6qpgYjxfN422lOMzri5HT5OpPDe1VCZjeIhucFDefIn+aDUNM2ZzR/b2q > hqKxSpwpmaK6USSCrbU/F6OhFNPsZw4/4IbUyY7Li4/a3/Bu1R7eVHXX9d4YQwFY > Or1VkWgyrJUeWOqr8R7hUlyyK7/wSVXjMIPdaOBArU0tkZrxUh4EKBlhDKwkOGnU > SyHZWlE89y9CmRTjPNGLXXopYyLK4aaBxY57258OHeZBSnl5q/rHNA== > =olMK > -----END PGP SIGNATURE----- > >

-- benh~

Wed Jun 20 14:28:10 2007 nospam-abuse [...] bloodgate.com - Correspondence added

Subject:	Re: [rt.cpan.org #27663] no subgroups with Graph::Easy::Group
Date:	Wed, 20 Jun 2007 20:27:35 +0200
To:	bug-Graph-Easy [...] rt.cpan.org
From:	Tels <nospam-abuse [...] bloodgate.com>

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Moin, On Wednesday 20 June 2007 19:47:05 ben.hengst@gmail.com via RT wrote: Show quoted text

> Queue: Graph-Easy > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=27663 > > > it's ok that it's not set up yet... but the docs dont say anything about > it.

It was expected to be long done - but I got sidetracked. Sorry :( The code is half-way done, but I couldn't get the last bits to work, so I stopped half way through. Show quoted text

> also I found something else in the docs > > as_graphviz_txt() gets mentioned twice in E::G::Node though if called > it's not there?

It only works if you load "As_graphviz.pm" before - I think I need to either document this, or make that loading automatical. Also the doc needs to mention that this isnt't a usefull method either :) Thanx a lot for the report, Tels - -- Signed on Wed Jun 20 20:25:36 2007 with key 0x93B84C15. View my photo gallery: http://bloodgate.com/photos PGP key on http://bloodgate.com/tels.asc or per email. http://www.giantitp.com/cgi-bin/GiantITP/ootscript?SK=1 -- Order of the Stick -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (GNU/Linux) iQEVAwUBRnlxl3cLPEOTuEwVAQLmDAf+JPFMokP/jS01nrb9uWaIdAMPCtmgeG2A IQF0d12PloGt3vvZfq6eR40lEUPjMvtBzH9mOeBHHcdYB7lO+tLXtxGgNC9CFmgB ZX2BkIwMxU60GWoQpWpQnaf65tTL4Ks6OqdDAEUDOqEYYlh/l7R6yu6b7L9GGlNi oP46jviN3DNWdjrO4M1yIJk3uTr56gW9BGZZC3aa7QOj4ypIAwFE6xnJW8XBJlag d4ydYk8egNPtmSlszuSexvbajADjnlh7PIAZWIj9nt3jn4sPIG60HpH6HRMSfgTb Kup52/nJC59wu80Mwv+y5MwhqBuyZ5Opiwe9r7hHLNS9WXKN+T0cxg== =CQFr -----END PGP SIGNATURE-----

Wed Jun 20 16:46:00 2007 ben.hengst [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #27663] no subgroups with Graph::Easy::Group
Date:	Wed, 20 Jun 2007 13:45:16 -0700
To:	bug-Graph-Easy [...] rt.cpan.org
From:	benh <ben.hengst [...] gmail.com>

ehh it happens. thanks so much for the work that you have done. If I get a chance mind if I poke at the code? On 6/20/07, nospam-abuse@bloodgate.com via RT <bug-Graph-Easy@rt.cpan.org> wrote: Show quoted text

> > <URL: http://rt.cpan.org/Ticket/Display.html?id=27663 > > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Moin, > > On Wednesday 20 June 2007 19:47:05 ben.hengst@gmail.com via RT wrote:

> > Queue: Graph-Easy > > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=27663 > > > > > it's ok that it's not set up yet... but the docs dont say anything about > > it.

> > It was expected to be long done - but I got sidetracked. Sorry :( > > The code is half-way done, but I couldn't get the last bits to work, so I > stopped half way through. >

> > also I found something else in the docs > > > > as_graphviz_txt() gets mentioned twice in E::G::Node though if called > > it's not there?

> > It only works if you load "As_graphviz.pm" before - I think I need to either > document this, or make that loading automatical. Also the doc needs to > mention that this isnt't a usefull method either :) > > Thanx a lot for the report, > > Tels > > - -- > Signed on Wed Jun 20 20:25:36 2007 with key 0x93B84C15. > View my photo gallery: http://bloodgate.com/photos > PGP key on http://bloodgate.com/tels.asc or per email. > > http://www.giantitp.com/cgi-bin/GiantITP/ootscript?SK=1 > > -- Order of the Stick > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.2 (GNU/Linux) > > iQEVAwUBRnlxl3cLPEOTuEwVAQLmDAf+JPFMokP/jS01nrb9uWaIdAMPCtmgeG2A > IQF0d12PloGt3vvZfq6eR40lEUPjMvtBzH9mOeBHHcdYB7lO+tLXtxGgNC9CFmgB > ZX2BkIwMxU60GWoQpWpQnaf65tTL4Ks6OqdDAEUDOqEYYlh/l7R6yu6b7L9GGlNi > oP46jviN3DNWdjrO4M1yIJk3uTr56gW9BGZZC3aa7QOj4ypIAwFE6xnJW8XBJlag > d4ydYk8egNPtmSlszuSexvbajADjnlh7PIAZWIj9nt3jn4sPIG60HpH6HRMSfgTb > Kup52/nJC59wu80Mwv+y5MwhqBuyZ5Opiwe9r7hHLNS9WXKN+T0cxg== > =CQFr > -----END PGP SIGNATURE----- > >

-- benh~

Fri Jul 31 18:56:35 2009 SHLOMIF [...] cpan.org - Correspondence added

On Wed Jun 20 14:28:10 2007, nospam-abuse@bloodgate.com wrote: Show quoted text

> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Moin, > > On Wednesday 20 June 2007 19:47:05 ben.hengst@gmail.com via RT wrote:

> > Queue: Graph-Easy > > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=27663 > > > > > it's ok that it's not set up yet... but the docs dont say anything

> about

> > it.

> > It was expected to be long done - but I got sidetracked. Sorry :( > > The code is half-way done, but I couldn't get the last bits to work, > so I > stopped half way through. >

> > also I found something else in the docs > > > > as_graphviz_txt() gets mentioned twice in E::G::Node though if

> called

> > it's not there?

> > It only works if you load "As_graphviz.pm" before - I think I need to > either > document this, or make that loading automatical. Also the doc needs to > mention that this isnt't a usefull method either :) > > Thanx a lot for the report, > > Tels >

I've now fixed the docs of Graph-Easy/lib/Graph/Easy/Node.pm to mention that in r3732 : {{{{{{{ * Partial fix to bug #27663 + Fix the name of the function in the code excerpt of as_graphviz() + Mark as_graphviz() and as_graphviz() as for internal use. + Make sure to indicate that one needs to load Graph::Easy::As_graphviz beforehand. }}}}}}} Regards, Shlomi Fish Show quoted text

> - -- > Signed on Wed Jun 20 20:25:36 2007 with key 0x93B84C15. > View my photo gallery: http://bloodgate.com/photos > PGP key on http://bloodgate.com/tels.asc or per email. > > http://www.giantitp.com/cgi-bin/GiantITP/ootscript?SK=1 > > -- Order of the Stick > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.2 (GNU/Linux) > > iQEVAwUBRnlxl3cLPEOTuEwVAQLmDAf+JPFMokP/jS01nrb9uWaIdAMPCtmgeG2A > IQF0d12PloGt3vvZfq6eR40lEUPjMvtBzH9mOeBHHcdYB7lO+tLXtxGgNC9CFmgB > ZX2BkIwMxU60GWoQpWpQnaf65tTL4Ks6OqdDAEUDOqEYYlh/l7R6yu6b7L9GGlNi > oP46jviN3DNWdjrO4M1yIJk3uTr56gW9BGZZC3aa7QOj4ypIAwFE6xnJW8XBJlag > d4ydYk8egNPtmSlszuSexvbajADjnlh7PIAZWIj9nt3jn4sPIG60HpH6HRMSfgTb > Kup52/nJC59wu80Mwv+y5MwhqBuyZ5Opiwe9r7hHLNS9WXKN+T0cxg== > =CQFr > -----END PGP SIGNATURE-----