Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 27637
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: Bernhard.Schmalhofer [...] gmx.de
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.053
Fixed in: (no value)

History Show all quoted text
  Tue Jun 19 04:09:14 2007 Bernhard.Schmalhofer [...] gmx.de - Ticket created
Subject: False positive for ValuesAndExpressions::ProhibitMixedBooleanOperators
Hi, I'm running Perl::Critic 1.05 and encountered a possible false positive for ValuesAndExpressions::ProhibitMixedBooleanOperators. Checking the code: package main; # pragmata use strict; use warnings; use 5.008; # Modules from CPAN use Test::More tests => 1; ok( ! 1, 'values are URLs' ) or diag 'never happens'; 1; with perlcritic -severity 4 high_low.pl gives me: Mixed high and low-precedence booleans at line 11, column 1. See page 70 of PBP. (Severity: 4) I would have thought that the '! 1' and the 'or' are two seperate expressions. Best regards, Bernhard
  Tue Jun 19 23:51:23 2007 jeffrey_thalhammer [...] yahoo.com - Correspondence added
Subject: Re: [rt.cpan.org #27637] False positive for ValuesAndExpressions::ProhibitMixedBooleanOperators
Date: Tue, 19 Jun 2007 20:51:05 -0700 (PDT)
To: bug-Perl-Critic [...] rt.cpan.org
From: Jeffrey Thalhammer <jeffrey_thalhammer [...] yahoo.com>
Show quoted text
> I would have thought that the '! 1' and the 'or' are > two seperate expressions.
At the moment, the Policy looks for mixed boolean operators within the entire statement. I'll see if we can improve that. Thanks for reporting this. -Jeff Show quoted text
____________________________________________________________________________________ Choose the right car based on your needs. Check out Yahoo! Autos new Car Finder tool. http://autos.yahoo.com/carfinder/
  Tue Jun 19 23:51:25 2007 The RT System itself - Status changed from 'new' to 'open'
  Thu Jan 22 11:08:36 2009 KYLE [...] cpan.org - Correspondence added
This appears to be fixed as of revision 1960 (or so). Can this ticket be marked resolved?
  Thu Jan 22 11:29:09 2009 Bernhard.Schmalhofer [...] gmx.de - Correspondence added
Subject: Re: [rt.cpan.org #27637] False positive for ValuesAndExpressions::ProhibitMixedBooleanOperators
Date: Thu, 22 Jan 2009 17:21:44 +0100
To: bug-Perl-Critic [...] rt.cpan.org
From: Bernhard Schmalhofer <Bernhard.Schmalhofer [...] gmx.de>
Kyle Hasselbacher via RT schrieb: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=27637 > > > This appears to be fixed as of revision 1960 (or so). Can this ticket > be marked resolved? > >
Yes, please go ahead and close the ticket.
  Sat Jan 24 21:53:48 2009 thaljef [...] cpan.org - Status changed from 'open' to 'resolved'