Bug #27558 for CPANPLUS-Dist-Deb: setting deb_version=2 does not promote a rebuild of a package

Wed Jun 13 02:42:02 2007 andreas.marienborg [...] gmail.com - Ticket created

Subject:

setting deb_version=2 does not promote a rebuild of a package

cpan2dist --format CPANPLUS::Dist::Deb --timeout 300 --dist-opts deb_version=2 Module::Install Could not find or check module 'Module::Signature' [THIS MAY BE A PROBLEM!] at /usr/local/share/perl/5.8.8/CPANPLUS/Module/Signature.pm line 51 [MSG] Already created package of 'Module::Install' at '/home/andreas/.cpanplus/5.8.8/dist/debian/main/pool/cpan-lib/m/cpan-libmodule-install-perl/cpan-libmodule-install-perl_0.67-1_all.deb' -- not doing so again unless you force Use of uninitialized value in join or string at (eval 90) line 2. [MSG] You have already created a '' distribution -- not doing so again unless you force Created 'CPANPLUS::Dist::Deb' distribution for Module::Install to: /home/andreas/.cpanplus/5.8.8/dist/debian/main/pool/cpan-lib/m/cpan-libmodule-install-perl/cpan-libmodule-install-perl_0.67-1_all.deb

Wed Jun 13 03:00:55 2007 andreas.marienborg [...] gmail.com - Correspondence added

These patches fixes the given issue, and also fixes an issue with creating -2 for instance version.

--- Deb/Constants.pm.orig 2007-06-13 09:53:10.000000000 +0200 +++ Deb/Constants.pm 2007-06-13 09:53:14.000000000 +0200 @@ -186,13 +186,14 @@ my $dir = shift() or return; my $pre = shift() || ''; my $xs = shift() ? 1 : 0; + my $ver = shift(); my $arch = $xs ? DEB_ARCHITECTURE->() : DEB_RULES_ARCH->(); my $name = join '_', DEB_PACKAGE_NAME->($mod, $pre), - DEB_VERSION->($mod), + DEB_VERSION->($mod, $ver), $arch .'.deb'; return File::Spec->catfile( $dir, $name

--- Deb.pm.orig 2007-06-13 09:52:10.000000000 +0200 +++ Deb.pm 2007-06-13 09:51:50.000000000 +0200 @@ -327,7 +327,8 @@ ### did we already create the package? if so, don't bother to rebuild ### unless we are forced to { for my $has_xs (0,1) { - my $pkg = DEB_DEB_FILE_NAME->( $self, $basedir, $prefix, $has_xs); + my $pkg = DEB_DEB_FILE_NAME->( $self, $basedir, $prefix, $has_xs, $deb_version); + warn "PKG: $pkg"; if( -e $pkg && -s _ and not $force) { msg(loc("Already created package of '%1' at '%2' -- not doing" @@ -425,7 +426,7 @@ ### let's figure out what this distribution will be called -- we'll need ### that later to see if it was actually created { my $has_xs = scalar GET_XS_FILES->( $self->status->extract ) ? 1 : 0; - my $debfile = DEB_DEB_FILE_NAME->( $self, '.', $prefix, $has_xs ); + my $debfile = DEB_DEB_FILE_NAME->( $self, '.', $prefix, $has_xs, $deb_version ); $dist->status->package_filename( $debfile ); }

Wed Jun 13 03:00:59 2007 andreas.marienborg [...] gmail.com - Status changed from 'new' to 'open'

Sun Jun 17 08:38:18 2007 kane [...] cpan.org - Correspondence added

On Wed Jun 13 03:00:55 2007, ANDREMAR wrote: Show quoted text

> These patches fixes the given issue, and also fixes an issue with > creating -2 for instance version.

Thanks for hte patches. I've just uploaded 0.06 which should address this issue. Cheers, Jos

Sun Jun 17 08:38:22 2007 kane [...] cpan.org - Status changed from 'open' to 'resolved'