Subject: | [PATCH] minor packaging changes for html2text distribution |
Date: | Fri, 8 Jun 2007 16:06:51 -0300 |
To: | "Ave Wrigley" <Ave.Wrigley [...] itn.co.uk>, bug-html2text [...] rt.cpan.org |
From: | "Adriano Ferreira" <a.r.ferreira [...] gmail.com> |
Ave,
You will find attached a patch against html2text-0.003. The purpose of
the patch is to update some packaging issues in the distribution.
With the recent introduction of the command "recent" in the CPAN shell
(which loads http://search.cpan.org/recent and then convert it to
text) and the reliance either on lynx or html2text, I think these
changes are opportune.
Let me explain each one of the changes made in the patch:
(1) the Changes file were updated so you don't have to or may take it
as a departing point
(2) a test was introduced into the MANIFEST (more on this later)
(3) when installing html2text-0.003 via the current CPAN, it tells us
"No tests defined for html2text extension." As I introduced a test, a
new requirement on Test::More were added to Makefile.PL. This is quite
common in today's distribution as Test::More is core for some time and
literally thousands of modules bring this dependency.
(4) the 'dist' part in Makefile.PL may be removed as the CPAN
toolchain works quite well nowadays without the need for these
sometimes unportable parameters.
(5) two additional parameters were introduced to Makefile.PL which are
quite common today: AUTHOR and LICENSE. They are ignored when working
with an old MakeMaker and are primarily for adding information to the
distribution (META.yml). Review this to make sure that's how you would
like it.
(6) touched README to update version number
(7) the primary show-stopper that prompted me to write this patch is
the shebang line the distribution has been using
#!/bin/env perl -w
Even though the installation works, the script itself may fail in some
platforms. It actually happened when I tried with Cygwin. On contrary,
the shebang line
#!/usr/bin/perl -w
is automatically updated to the right path on installation time and
will work everywhere.
(8) and then I touched the version number and it is your call to bump
it to 0.004 or whatever it pleases you
(9) I wrote a simple test script which merely checks that the script
compiles. It depends on the availability of Test::Script. If it is not
installed, the test is skipped without a failure. I think this is a
very minimal test and the simplest.
Thanks for this module.
Best regards,
Adriano Ferreira
Message body is not shown because sender requested not to inline it.