Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the ack CPAN distribution.

Maintainer(s)' notes

ack's issues are tracked at https://github.com/petdance/ack2

Report information
The Basics
Id: 27471
Status: rejected
Priority: 0/
Queue: ack
People
Owner: Nobody in particular
Requestors: matt [...] diephouse.com
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 1.58
Fixed in: (no value)

History Show all quoted text
  Wed Jun 06 18:09:29 2007 matt [...] diephouse.com - Ticket created
Subject: -a doesn't respect --nobinary
When I'm searching in a foreign code base, I often find that there are uncommon file extensions. I want to include those files in my search, but I still don't want to search binary files -- they're not helpful! `ack -a --nobinary search-term` should do that, but it doesn't. The -a clobbers --nobinary. That really needs to be fixed. It'll be a big help to me. Thanks! -- Matt Diephouse
  Wed Jun 06 20:37:45 2007 andy [...] petdance.com - Correspondence added
Subject: Re: [rt.cpan.org #27471] -a doesn't respect --nobinary
Date: Wed, 6 Jun 2007 19:36:48 -0500
To: bug-ack [...] rt.cpan.org
From: Andy Lester <andy [...] petdance.com>
Show quoted text
> > `ack -a --nobinary search-term` should do that, but it doesn't. The > -a clobbers --nobinary.
No, that's my intention. --binary/--nobinary is a filetype just like --perl or --html. -- Andy Lester => andy@petdance.com => www.petdance.com => AIM:petdance
  Wed Jun 06 20:37:56 2007 The RT System itself - Status changed from 'new' to 'open'
  Wed Jun 06 21:28:52 2007 matt [...] diephouse.com - Correspondence added
Subject: Re: [rt.cpan.org #27471] -a doesn't respect --nobinary
Date: Wed, 6 Jun 2007 18:26:59 -0700
To: bug-ack [...] rt.cpan.org
From: Matt Diephouse <matt [...] diephouse.com>
andy@petdance.com via RT wrote: Show quoted text
> > <URL: http://rt.cpan.org/Ticket/Display.html?id=27471 > >
>> >> `ack -a --nobinary search-term` should do that, but it doesn't. The >> -a clobbers --nobinary.
> > No, that's my intention. --binary/--nobinary is a filetype just like > --perl or --html.
Well I want `ack -a --nohtml search-term` to search everything but html too. I want it to work for all filetypes. Basically, I need a way to say "include file types you don't know but don't search foo", where foo could be binary or html. -- Matt Diephouse
  Wed Jun 06 21:48:28 2007 andy [...] petdance.com - Correspondence added
Subject: Re: [rt.cpan.org #27471] -a doesn't respect --nobinary
Date: Wed, 6 Jun 2007 20:45:26 -0500
To: bug-ack [...] rt.cpan.org
From: Andy Lester <andy [...] petdance.com>
On Jun 6, 2007, at 8:28 PM, Matt Diephouse via RT wrote: Show quoted text
> Well I want `ack -a --nohtml search-term` to search everything but > html too.
That's what it should indeed do. Or rather, it searches every file type it knows about but skips the HTML. Yes, ack ignores stuff it doesn't know what it is. -- Andy Lester => andy@petdance.com => www.petdance.com => AIM:petdance
  Wed Jun 06 22:10:55 2007 matt [...] diephouse.com - Correspondence added
Subject: Re: [rt.cpan.org #27471] -a doesn't respect --nobinary
Date: Wed, 6 Jun 2007 19:09:01 -0700
To: bug-ack [...] rt.cpan.org
From: Matt Diephouse <matt [...] diephouse.com>
On 06 Jun 2007, at 6:48 PM, andy@petdance.com via RT wrote: Show quoted text
> On Jun 6, 2007, at 8:28 PM, Matt Diephouse via RT wrote: >
>> Well I want `ack -a --nohtml search-term` to search everything but >> html too.
> > That's what it should indeed do. Or rather, it searches every file > type it knows about but skips the HTML. > > Yes, ack ignores stuff it doesn't know what it is.
Right, but -a makes it search *everything*. So given these files: known.c known.o unknown.filetype 1) ack --nobinary searches known.c 2) ack -a searches known.c, known.o, unknown.filetype 3) ack -a --nobinary does the same thing There's no way to search just known.c and unknown.filetype. This is really annoying in some codebases. If -a and --nobinary are stackable, then (3) does what I want. Note that right now (2) and (3) do the same thing. So making this change adds functionality and doesn't take any away. This is how I read -a and --nobinary: -a: search all files -- even the ones I don't know about --nobinary: don't search binary files I think combining them should mean "search all files -- even the ones I don't know about -- but don't search binary files". -- Matt Diephouse
  Wed Jun 06 22:28:15 2007 andy [...] petdance.com - Correspondence added
Subject: Re: [rt.cpan.org #27471] -a doesn't respect --nobinary
Date: Wed, 6 Jun 2007 21:26:32 -0500
To: bug-ack [...] rt.cpan.org
From: Andy Lester <andy [...] petdance.com>
On Jun 6, 2007, at 9:11 PM, Matt Diephouse via RT wrote: Show quoted text
> Right, but -a makes it search *everything*.
No, it doesn't. It searches all filetypes. Which is not the same as every file. This should be carried on in ack-users, not this ticket. -- Andy Lester => andy@petdance.com => www.petdance.com => AIM:petdance
  Wed Nov 07 22:21:56 2007 PETDANCE [...] cpan.org - Status changed from 'open' to 'rejected'