Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CGI CPAN distribution.

Report information
The Basics
Id: 27455
Status: resolved
Priority: 0/
Queue: CGI
People
Owner: MARKSTOS [...] cpan.org
Requestors: info [...] gknw.de
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Tue Jun 05 20:55:55 2007 info [...] gknw.de - Ticket created
Subject: CGI.pm doesnt use binmode() on NetWare platform
Date: Wed, 6 Jun 2007 02:54:48 +0200
To: bug-CGI.pm [...] rt.cpan.org
From: Guenter Knauf <info [...] gknw.de>
Hi Lincoln, while testing with POST data I found that CGI.pm doesnt use binmode() on NetWare; below is a patch against CGI.pm 3.29 which fixes this: ########################################################################### # patch to fix CGI.pm to use binmode() on NetWare -- by G. Knauf. # ########################################################################### --- CGI.pm.orig Mon Apr 16 18:58:46 2007 +++ CGI.pm Wed Jun 06 02:45:06 2007 @@ -155,12 +155,14 @@ $OS = 'EPOC'; } elsif ($OS =~ /^cygwin/i) { $OS = 'CYGWIN'; +} elsif ($OS =~ /^NetWare/i) { + $OS = 'NETWARE'; } else { $OS = 'UNIX'; } # Some OS logic. Binary mode enabled on DOS, NT and VMS -$needs_binmode = $OS=~/^(WINDOWS|DOS|OS2|MSWin|CYGWIN)/; +$needs_binmode = $OS=~/^(WINDOWS|DOS|OS2|MSWin|CYGWIN|NETWARE)/; # This is the default class for the CGI object to use when all else fails. $DefaultClass = 'CGI' unless defined $CGI::DefaultClass; @@ -171,7 +173,7 @@ # The path separator is a slash, backslash or semicolon, depending # on the paltform. $SL = { - UNIX => '/', OS2 => '\\', EPOC => '/', CYGWIN => '/', + UNIX => '/', OS2 => '\\', EPOC => '/', CYGWIN => '/', NETWARE => '/', WINDOWS => '\\', DOS => '\\', MACINTOSH => ':', VMS => '/' }->{$OS}; thanks, Guenter.
########################################################################### # patch to fix CGI.pm to use binmode() on NetWare -- by G. Knauf. # ########################################################################### --- CGI.pm.orig Mon Apr 16 18:58:46 2007 +++ CGI.pm Wed Jun 06 02:45:06 2007 @@ -155,12 +155,14 @@ $OS = 'EPOC'; } elsif ($OS =~ /^cygwin/i) { $OS = 'CYGWIN'; +} elsif ($OS =~ /^NetWare/i) { + $OS = 'NETWARE'; } else { $OS = 'UNIX'; } # Some OS logic. Binary mode enabled on DOS, NT and VMS -$needs_binmode = $OS=~/^(WINDOWS|DOS|OS2|MSWin|CYGWIN)/; +$needs_binmode = $OS=~/^(WINDOWS|DOS|OS2|MSWin|CYGWIN|NETWARE)/; # This is the default class for the CGI object to use when all else fails. $DefaultClass = 'CGI' unless defined $CGI::DefaultClass; @@ -171,7 +173,7 @@ # The path separator is a slash, backslash or semicolon, depending # on the paltform. $SL = { - UNIX => '/', OS2 => '\\', EPOC => '/', CYGWIN => '/', + UNIX => '/', OS2 => '\\', EPOC => '/', CYGWIN => '/', NETWARE => '/', WINDOWS => '\\', DOS => '\\', MACINTOSH => ':', VMS => '/' }->{$OS};
  Thu Jul 23 22:20:34 2009 MARKSTOS [...] cpan.org - Taken
  Thu Jul 23 22:21:45 2009 MARKSTOS [...] cpan.org - Subject changed from 'CGI.pm doesnt use binmode() on NetWare platform' to 'PATCH: also use binmode() on NetWare platform'
  Thu Jul 23 22:21:45 2009 MARKSTOS [...] cpan.org - Broken in 3.43 added
  Thu Jul 23 22:23:25 2009 MARKSTOS [...] cpan.org - Correspondence added
On Tue Jun 05 20:55:55 2007, info@gknw.de wrote: Show quoted text
> Hi Lincoln, > while testing with POST data I found that CGI.pm doesnt use binmode() > on NetWare; > below is a patch against CGI.pm 3.29 which fixes this: > >
########################################################################### Show quoted text
> # patch to fix CGI.pm to use binmode() on NetWare -- by G. Knauf. > # >
########################################################################### Show quoted text
> --- CGI.pm.orig Mon Apr 16 18:58:46 2007 > +++ CGI.pm Wed Jun 06 02:45:06 2007 > @@ -155,12 +155,14 @@ > $OS = 'EPOC'; > } elsif ($OS =~ /^cygwin/i) { > $OS = 'CYGWIN'; > +} elsif ($OS =~ /^NetWare/i) { > + $OS = 'NETWARE'; > } else { > $OS = 'UNIX'; > } > > # Some OS logic. Binary mode enabled on DOS, NT and VMS > -$needs_binmode = $OS=~/^(WINDOWS|DOS|OS2|MSWin|CYGWIN)/; > +$needs_binmode = $OS=~/^(WINDOWS|DOS|OS2|MSWin|CYGWIN|NETWARE)/; > > # This is the default class for the CGI object to use when all else > fails. > $DefaultClass = 'CGI' unless defined $CGI::DefaultClass; > @@ -171,7 +173,7 @@ > # The path separator is a slash, backslash or semicolon, depending > # on the paltform. > $SL = { > - UNIX => '/', OS2 => '\\', EPOC => '/', CYGWIN => '/', > + UNIX => '/', OS2 => '\\', EPOC => '/', CYGWIN => '/', > NETWARE => '/', > WINDOWS => '\\', DOS => '\\', MACINTOSH => ':', VMS => '/' > }->{$OS};
Thanks for the patch. I recommend it be apply for the next release. Mark
  Thu Jul 23 22:23:26 2009 The RT System itself - Status changed from 'new' to 'open'
  Sat Aug 01 21:42:12 2009 MARKSTOS [...] cpan.org - Correspondence added
Thanks, this patch has been applied in my git repo now. Mark
  Sat Aug 01 21:42:13 2009 MARKSTOS [...] cpan.org - Status changed from 'open' to 'patched'
  Fri Aug 14 21:41:24 2009 MARKSTOS [...] cpan.org - Correspondence added
Subject: released, thanks.
I believe this change was released today as part of CGI.pm 3.45. Thanks for the contribution.
  Fri Aug 14 21:41:24 2009 The RT System itself - Status changed from 'patched' to 'open'
  Fri Aug 14 21:41:25 2009 MARKSTOS [...] cpan.org - Status changed from 'open' to 'resolved'
  Fri May 23 14:28:46 2014 The RT System itself - Queue changed from CGI.pm to CGI