Skip Menu |

This queue is for tickets about the SQL-Translator CPAN distribution.

Report information
The Basics
Id: 27438
Status: resolved
Priority: 0/
Queue: SQL-Translator

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in:
  • 0.08
  • 0.08_04
Fixed in: 0.11003



Subject: sqlt: quote_table_names and quote_field_names already on by default
These code lines in sqlt look wrong: my $translator = SQL::Translator->new( ... quote_table_names => $quote_table_names || 1, quote_field_names => $quote_field_names || 1, These means that quote_table_names and quote_field_names are always turned on, regardless on the commandline setting. It should probably be quote_table_names => $quote_table_names or quote_table_names => defined $quote_table_names ? $quote_table_names : 1 depending on the value be turned on or off by default. Additionally the GetOptions declaration should be changed to 'quote_table_names!' => \$quote_table_names, (note the exclam mark). Regards, Slaven