Bug #27368 for Net-SSH2: Memory leak in Net:SSH2::poll()

Fri Jun 01 09:21:14 2007 kvs [...] binarysolutions.dk - Ticket created

Subject:	Memory leak in Net:SSH2::poll()
Date:	Fri, 01 Jun 2007 15:20:05 +0200
To:	bug-Net-SSH2 [...] rt.cpan.org
From:	Kenneth Vestergaard Schmidt <kvs [...] binarysolutions.dk>

Hi. Net:SSH2 v0.10 seems to be leaking some memory on each call to poll(). I haven't been able to determine if it's in the .pm, the .xs or the .so. I've put a script which demonstrates the bug at http://dev.binsol.dk/~kvs/net-ssh2-leak.pl I've tried reinitialising @poll on each run through the main-loop, and I've tried not using $chan->eof, so that shouldn't be it. I've disabled reading the data on the channel, since this'll make the memory-leak that much more apparent - it just gobbles up RAM. This is on an amd64 FreeBSD 6.2-system, with perl 5.8.8 and libssh2-0.14. Let me know if I missed anything, or can do/test something. -- Best Regards Kenneth Schmidt

Tue Aug 14 10:26:59 2007 sullivan [...] bear.com - Correspondence added

From:

sullivan [...] bear.com

The SSH2.xs function net_ss__poll() does a Perl_malloc() of pollfd but never frees it before returning. I believe the bottom of the routine should look like: if (changed < 0) { Perl_mfree( pollfd ); XSRETURN_EMPTY; } for (i = 0; i < count; ++i) { HV* hv = (HV*)SvRV(*av_fetch(event, i, 0/*lval*/)); hv_store(hv, "revents", 7, newSViv(pollfd[i].revents), 0/ *hash*/); debug("- [%d] revents %d\n", i, pollfd[i].revents); } Perl_mfree( pollfd ); XSRETURN_IV(changed);

Tue Aug 14 10:27:11 2007 The RT System itself - Status changed from 'new' to 'open'

Sat Nov 10 19:02:32 2007 dbrobins [...] cpan.org - Correspondence added

Fixed in 0.18 based on djmsullivan's patch.

Sat Nov 10 19:02:34 2007 dbrobins [...] cpan.org - Status changed from 'open' to 'resolved'