Skip Menu |

This queue is for tickets about the WWW-Facebook-API CPAN distribution.

Report information
The Basics
Id: 27351
Status: resolved
Priority: 0/
Queue: WWW-Facebook-API

People
Owner: Nobody in particular
Requestors: trs [...] bestpractical.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: FEATURE PATCH: fbml namespace
Date: Thu, 31 May 2007 02:13:55 -0400
To: bug-WWW-Facebook-API [...] rt.cpan.org
From: Thomas Sibley <trs [...] bestpractical.com>
Hi, I've patched WWW::Facebook::API 0.1.4 to include methods for the FBML namespace. These calls are undocumented in the official doc (though it is mentioned), but the wiki has some tangential doc on it. While the patch should work just fine in theory, I haven't actually tested it yet. Thanks for the great work on this library. It makes interfacing with Facebook much easier. Cheers, Tom
diff -ruN WWW-Facebook-API-v0.1.4-orig/lib/WWW/Facebook/API/FBML.pm WWW-Facebook-API-v0.1.4/lib/WWW/Facebook/API/FBML.pm --- WWW-Facebook-API-v0.1.4-orig/lib/WWW/Facebook/API/FBML.pm 1969-12-31 19:00:00.000000000 -0500 +++ WWW-Facebook-API-v0.1.4/lib/WWW/Facebook/API/FBML.pm 2007-05-31 02:02:47.000000000 -0400 @@ -0,0 +1,127 @@ +package WWW::Facebook::API::FBML; + +use warnings; +use strict; +use Carp; + +use version; our $VERSION = qv('0.1.4'); + +use Moose; +extends 'Moose::Object'; + +has 'base' => ( is => 'ro', isa => 'WWW::Facebook::API::Base' ); + +sub refresh_img_src { shift->base->call( 'fbml.refreshImgSrc', @_ ) } +sub refresh_ref_url { shift->base->call( 'fbml.refreshRefUrl', @_ ) } +sub set_ref_handle { shift->base->call( 'fbml.setRefHandle', @_ ) } + +1; # Magic true value required at end of module +__END__ + +=head1 NAME + +WWW::Facebook::API::FBML - FBML methods for Client + + +=head1 VERSION + +This document describes WWW::Facebook::API::FBML version 0.1.4 + + +=head1 SYNOPSIS + + use WWW::Facebook::API; + +=head1 DESCRIPTION + +Methods for updating FBML references with L<WWW::Facebook::API> + +=head1 SUBROUTINES/METHODS + +=over + +=item base + +The L<WWW::Facebook::API::Base> object to use to make calls to +the REST server. + +=item set_ref_handle + +The fbml.setRefHandle method of the Facebook API. + +=item refresh_img_src + +The fbml.refreshImgSrc method of the Facebook API. + +=item refresh_ref_url + +The fbml.refreshRefUrl method of the Facebook API. + +=back + + +=head1 DIAGNOSTICS + +None. + +=head1 CONFIGURATION AND ENVIRONMENT + +WWW::Facebook::API::FBML requires no configuration files or +environment variables. + + +=head1 DEPENDENCIES + +L<Moose> +L<WWW::Facebook::API::Base> + + +=head1 INCOMPATIBILITIES + +None reported. + + +=head1 BUGS AND LIMITATIONS + +No bugs have been reported. + +Please report any bugs or feature requests to +C<bug-www-facebook-api@rt.cpan.org>, or through the web interface at +L<http://rt.cpan.org>. + + +=head1 AUTHOR + +David Romano C<< <unobe@cpan.org> >> + + +=head1 LICENSE AND COPYRIGHT + +Copyright (c) 2007, David Romano C<< <unobe@cpan.org> >>. All rights reserved. + +This module is free software; you can redistribute it and/or +modify it under the same terms as Perl itself. See L<perlartistic>. + + +=head1 DISCLAIMER OF WARRANTY + +BECAUSE THIS SOFTWARE IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY +FOR THE SOFTWARE, TO THE EXTENT PERMITTED BY APPLICABLE LAW. EXCEPT WHEN +OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES +PROVIDE THE SOFTWARE "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER +EXPRESSED OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED +WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. THE +ENTIRE RISK AS TO THE QUALITY AND PERFORMANCE OF THE SOFTWARE IS WITH +YOU. SHOULD THE SOFTWARE PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL +NECESSARY SERVICING, REPAIR, OR CORRECTION. + +IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING +WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY AND/OR +REDISTRIBUTE THE SOFTWARE AS PERMITTED BY THE ABOVE LICENSE, BE +LIABLE TO YOU FOR DAMAGES, INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL, +OR CONSEQUENTIAL DAMAGES ARISING OUT OF THE USE OR INABILITY TO USE +THE SOFTWARE (INCLUDING BUT NOT LIMITED TO LOSS OF DATA OR DATA BEING +RENDERED INACCURATE OR LOSSES SUSTAINED BY YOU OR THIRD PARTIES OR A +FAILURE OF THE SOFTWARE TO OPERATE WITH ANY OTHER SOFTWARE), EVEN IF +SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE POSSIBILITY OF +SUCH DAMAGES. diff -ruN WWW-Facebook-API-v0.1.4-orig/lib/WWW/Facebook/API.pm WWW-Facebook-API-v0.1.4/lib/WWW/Facebook/API.pm --- WWW-Facebook-API-v0.1.4-orig/lib/WWW/Facebook/API.pm 2007-05-30 09:21:11.000000000 -0400 +++ WWW-Facebook-API-v0.1.4/lib/WWW/Facebook/API.pm 2007-05-31 02:03:29.000000000 -0400 @@ -36,6 +36,13 @@ return WWW::Facebook::API::Events->new( base => $_[0] ) }, ); +has 'fbml' => (is => 'ro', + isa => 'WWW::Facebook::API::FBML', + default => sub { + use WWW::Facebook::API::FBML; + return WWW::Facebook::API::FBML->new( base => $_[0] ) + }, +); has 'fql' => (is => 'ro', isa => 'WWW::Facebook::API::FQL', default => sub { @@ -185,6 +192,10 @@ All method names from the Facebook API are lower_cased instead of CamelCase, e.g., events.getInWindow is events->get_in_window +=item fbml + +fbml namespace of the API (See L<WWW::Facebook::API::FBML>). + =item fql fql namespace of the API (See L<WWW::Facebook::API::FQL>).
Subject: Re: [rt.cpan.org #27351] FEATURE PATCH: fbml namespace
Date: Thu, 31 May 2007 11:42:13 -0700
To: "trs [...] bestpractical.com via RT" <bug-WWW-Facebook-API [...] rt.cpan.org>
From: David Romano <unobe [...] cpan.org>
H Tom, trs@bestpractical.com via RT wrote on Wed, May 30, 2007 at 11:14:03PM PDT: Show quoted text
> I've patched WWW::Facebook::API 0.1.4 to include methods for the FBML > namespace. These calls are undocumented in the official doc (though it > is mentioned), but the wiki has some tangential doc on it. While the > patch should work just fine in theory, I haven't actually tested it yet.
Thanks! I'll apply it anyway, and the tests can follow. I want to change the authorship for that module to you, since you wrote it. Can I put your name with your CPAN address in the doc part? Either way, the patch will be in 0.1.5, which will be headed to CPAN when I hear back from you. Show quoted text
> Thanks for the great work on this library. It makes interfacing with > Facebook much easier.
Thanks Tom! I have had mixed reviews already, and I'm trying to figure out what is frustrating a lot of people about the module. For some its the skimpy documentation (I know, I can always work on that). For others its the dependency load because of Moose. One thing which will probably help is to make the repo public, and I was thinking of having it hosted on code.google.com. If you have any suggestions about how to make the module better, I'd be very appreciative! Thanks again for the patch :-) - David -- "If you MUST get married, it is always advisable to marry beauty. Otherwise, you'll never find anybody to take her off your hands." -- Unknown
Subject: Re: [rt.cpan.org #27351] FEATURE PATCH: fbml namespace
Date: Thu, 31 May 2007 15:29:23 -0400
To: bug-WWW-Facebook-API [...] rt.cpan.org
From: Thomas Sibley <trs [...] bestpractical.com>
Thanks for the quick response! Show quoted text
> Thanks! I'll apply it anyway, and the tests can follow. I want to > change the authorship for that module to you, since you wrote it. Can I > put your name with your CPAN address in the doc part? Either way, the > patch will be in 0.1.5, which will be headed to CPAN when I hear back > from you.
Sure. TSIBLEY and tsibley@cpan.org. Show quoted text
> Thanks Tom! I have had mixed reviews already, and I'm trying to figure > out what is frustrating a lot of people about the module. For some its > the skimpy documentation (I know, I can always work on that). For > others its the dependency load because of Moose. One thing which will > probably help is to make the repo public, and I was thinking of having > it hosted on code.google.com. If you have any suggestions about how to > make the module better, I'd be very appreciative! Thanks again for the > patch :-)
The dep load on Moose is a bit annoying, but it's tolerable. It'd be nice to see that go away though. Anyway, moving the code into a public repo would be great. code.google.com is a reasonable place. Cheers, Tom
Subject: Re: [rt.cpan.org #27351] FEATURE PATCH: fbml namespace
Date: Thu, 31 May 2007 14:24:39 -0700
To: "trs [...] bestpractical.com via RT" <bug-WWW-Facebook-API [...] rt.cpan.org>
From: David Romano <unobe [...] cpan.org>
trs@bestpractical.com via RT wrote on Thu, May 31, 2007 at 12:29:39PM PDT: Show quoted text
> Anyway, moving the code into a public repo would be great. > code.google.com is a reasonable place.
http://code.google.com/p/perl-www-facebook-api/ - David -- "Life is what happens to you while you're busy making other plans." -- John Lennon
feature added