Bug #27305 for WWW-Facebook-API: implicit dependency on Test::MockObject::Extends

Sun May 27 11:44:29 2007 sorourke [...] cs.ucsd.edu - Ticket created

Subject:	implicit dependency on Test::MockObject::Extends
Date:	Sun, 27 May 2007 08:43:36 -0700
To:	bug-www-facebook-api [...] rt.cpan.org
From:	"Sean O'Rourke" <sorourke [...] cs.ucsd.edu>

A non-optional test, t/auth.t, depends on Test::MockObject::Extends without stating this dependency. The attached patch makes the dependency optional. /s

Message body is not shown because sender requested not to inline it.

Mon May 28 10:25:33 2007 unobe [...] cpan.org - Correspondence added

Fixed in 0.0.9. Thanks!

Mon May 28 10:26:03 2007 The RT System itself - Status changed from 'new' to 'open'

Mon May 28 10:26:05 2007 unobe [...] cpan.org - Status changed from 'open' to 'resolved'

Tue May 29 08:50:11 2007 seano [...] cpan.org - Correspondence added

I'm reluctant to mention this, but you didn't choose the resolution I had in mind, i.e. making T::MO::E optional. IMHO mandatory dependencies on test modules are a mistake, so I urge you to treat T::MO::E like you treat Test::Pod and Test::Pod::Coverage -- use them if available, but don't try to install them.

Tue May 29 08:50:13 2007 The RT System itself - Status changed from 'resolved' to 'open'

Tue May 29 15:50:51 2007 unobe@cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #27305] implicit dependency on Test::MockObject::Extends
Date:	Tue, 29 May 2007 12:49:57 -0700
To:	via RT <bug-WWW-Facebook-API [...] rt.cpan.org>
From:	David Romano <unobe [...] cpan.org>

via RT wrote on Tue, May 29, 2007 at 05:50:13AM PDT: Show quoted text

> I'm reluctant to mention this, but you didn't choose the resolution I > had in mind, i.e. making T::MO::E optional. IMHO mandatory > dependencies on test modules are a mistake, so I urge you to treat > T::MO::E like you treat Test::Pod and Test::Pod::Coverage -- use them > if available, but don't try to install them.

Yeah, I had thought about that, when I was going to sleep last night: thanks for the follow-up! I'll have it recommended in Makefile.PL, and apply the patch you gave, in the next release. - David -- "Let a fool hold his tongue and the fool will pass for a sage." -- Unknown

Tue May 29 16:02:17 2007 unobe@cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #27305] implicit dependency on Test::MockObject::Extends
Date:	Tue, 29 May 2007 13:01:44 -0700
To:	via RT <bug-WWW-Facebook-API [...] rt.cpan.org>
From:	David Romano <unobe [...] cpan.org>

Oops, was thinking of Module::Install. Nothing will now be in Makefile.PL for Test::MockObject::Extends. On its way to CPAN, - David -- "He is no fool who gives what he can never keep to gain what he can never lose." -- Jim Elliot

Tue May 29 17:26:21 2007 unobe@cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #27305] implicit dependency on Test::MockObject::Extends
Date:	Tue, 29 May 2007 14:25:38 -0700
To:	via RT <bug-WWW-Facebook-API [...] rt.cpan.org>
From:	David Romano <unobe [...] cpan.org>

via RT wrote on Tue, May 29, 2007 at 05:50:13AM PDT: Show quoted text

> I'm reluctant to mention this, but you didn't choose the resolution I > had in mind, i.e. making T::MO::E optional. IMHO mandatory > dependencies on test modules are a mistake, so I urge you to treat > T::MO::E like you treat Test::Pod and Test::Pod::Coverage -- use them > if available, but don't try to install them.

Okay, so I had to tweak the patch so that it didn't ALWAYS skip the tests, even if Test::MockObject::Extends was available. Attached is the patch. - David -- "Life is what happens to you while you're busy making other plans." -- John Lennon

Message body is not shown because sender requested not to inline it.

Wed May 30 09:37:02 2007 unobe [...] cpan.org - Correspondence added

fixed in 0.1.2

Wed May 30 09:37:09 2007 unobe [...] cpan.org - Status changed from 'open' to 'resolved'