Bug #2723 for ExtUtils-MakeMaker: Automatic writing of META.yml

Mon Jun 02 11:14:32 2003 Guest - Ticket created

Subject:

Automatic writing of META.yml

$ make dist Could not open MANIFEST: Permission denied at /usr/local/lib/perl5/5.8.0/ExtUtils/Manifest.pm line 542. make: *** [metafile_addtomanifest] Error 13 Exit 2 This is quite common, because I'm using RCS for my perl dists. RCS makes the file unwritable if it is unlocked. Regards, Slaven

Mon Jun 02 17:25:28 2003 mschwern [...] cpan.org - Correspondence added

[guest - Mon Jun 2 11:14:32 2003]: Show quoted text

> $ make dist > Could not open MANIFEST: Permission denied at > /usr/local/lib/perl5/5.8.0/ExtUtils/Manifest.pm line 542. > make: *** [metafile_addtomanifest] Error 13 > Exit 2 > > This is quite common, because I'm using RCS for my perl dists. > RCS makes the file unwritable if it is unlocked.

Any suggested action for MakeMaker to take instead?

Mon Jun 02 17:25:29 2003 mschwern [...] cpan.org - Status changed from 'new' to 'open'

Mon Jun 02 20:26:15 2003 mschwern [...] cpan.org - Correspondence added

[slaven@rezic.de - Mon Jun 2 18:38:42 2003]: Show quoted text

> Just warn that MANIFEST is not writable and do not fail. This could be > constructed as a feature for people who do not like their MANIFEST to > be changed. Or add a attribute (NO_META_YML_GENERATION?) for > Makefile.PL. Or both.

There's already a NO_META attribute (see ExtUtils::MakeMaker::FAQ). Patches welcome on the warning part.

Tue Jun 03 07:30:11 2003 SREZIC [...] cpan.org - Correspondence added

From:

slaven [...] rezic.de

[MSCHWERN - Mon Jun 2 20:26:15 2003]: Show quoted text

> [slaven@rezic.de - Mon Jun 2 18:38:42 2003]:

> > Just warn that MANIFEST is not writable and do not fail. This could be > > constructed as a feature for people who do not like their MANIFEST to > > be changed. Or add a attribute (NO_META_YML_GENERATION?) for > > Makefile.PL. Or both.

> > There's already a NO_META attribute (see ExtUtils::MakeMaker::FAQ). > > Patches welcome on the warning part.

Here's one.

#### Patch data follows #### diff -up 'ExtUtils-MakeMaker-6.10_04/lib/ExtUtils/MM_Any.pm' 'new.ExtUtils-MakeMaker-6.10_04/lib/ExtUtils/MM_Any.pm' Index: ./lib/ExtUtils/MM_Any.pm --- ./lib/ExtUtils/MM_Any.pm Sat May 10 03:41:59 2003 +++ ./lib/ExtUtils/MM_Any.pm Tue Jun 3 13:27:12 2003 @@ -605,7 +605,7 @@ metafile_addtomanifest: MAKE_FRAG my $add_meta = $self->oneliner(<<'CODE', ['-MExtUtils::Manifest=maniadd']); -maniadd({q{META.yml} => q{Module meta-data (added by MakeMaker)}}); +eval { maniadd({q{META.yml} => q{Module meta-data (added by MakeMaker)}}) }; warn q{Could not add META.yml to MANIFEST: }.$$@ if $$@; CODE return sprintf <<'MAKE_FRAG', $add_meta; #### End of Patch data ####

Tue Jun 03 07:32:35 2003 SREZIC [...] cpan.org - Correspondence added

[MSCHWERN - Mon Jun 2 20:26:15 2003]: Show quoted text

> [slaven@rezic.de - Mon Jun 2 18:38:42 2003]:

> > Just warn that MANIFEST is not writable and do not fail. This could be > > constructed as a feature for people who do not like their MANIFEST to > > be changed. Or add a attribute (NO_META_YML_GENERATION?) for > > Makefile.PL. Or both.

> > There's already a NO_META attribute (see ExtUtils::MakeMaker::FAQ).

No, there's no reference to NO_META except in the source code and the Changes file.

Tue Jun 03 07:40:24 2003 mschwern [...] cpan.org - Correspondence added

[SREZIC - Tue Jun 3 07:32:35 2003]: Show quoted text

> No, there's no reference to NO_META except in the source code and the > Changes file.

You must be looking at the 6.10_04 alpha. That's, like, sooooooo last week. Look at the snapshot on makemaker.org.

Thu Jun 05 05:07:29 2003 mschwern [...] cpan.org - Correspondence added

[SREZIC - Tue Jun 3 07:30:11 2003]: Show quoted text

> > Patches welcome on the warning part.

> > Here's one.

Okie-doke, its in the snapshot.

Thu Jun 05 05:07:30 2003 mschwern [...] cpan.org - Status changed from 'open' to 'resolved'