Bug #2721 for Archive-Tar: uninitialized values in test of Archive-Tar-1.00

Mon Jun 02 04:57:00 2003 Guest - Ticket created

Subject:

uninitialized values in test of Archive-Tar-1.00

Solaris 7 (Sparc), Perl 5.8.0 (ithreads, shared libperl), compiled with Forte 6.2, latest Compress::Zlib and IO::Zlib. (and also on RedHat Linux 7.2, gcc): The ->data method seems to return "undef" in line 704... Cheers, Marek $ make test TEST_VERBOSE=1 PERL_DL_NONLAZY=1 /opt/perl_5.8.0/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(1, 'blib/lib', 'blib/arch')" t/*.t t/01_use........1..2 ok 1 - use Archive::Tar; ok 2 - Object created isa Archive::Tar ok t/02_methods....ok 1 - Object created isa Archive::Tar ok 2 - Reading uncompressed file using 'read()' ok 3 - All files accounted for ok 4 - Content OK ok 5 - Content OK ok 6 - Content OK ok 7 - Reading uncompressed file using 'list_archive()' ok 8 - All files accounted for ok 9 - Found expected file ok 10 - Found expected file ok 11 - Found expected file ok 12 - Reading compressed file using 'read()' ok 13 - All files accounted for ok 14 - Content OK ok 15 - Content OK ok 16 - Content OK ok 17 - Reading compressed file using 'list_archive()' ok 18 - All files accounted for ok 19 - Found expected file ok 20 - Found expected file ok 21 - Found expected file ok 22 - Adding files ok 23 - Proper name ok 24 - Proper type ok 25 - Content OK ok 26 - Adding data ok 27 - Proper name ok 28 - Proper type ok 29 - Content OK ok 30 - Renaming ok 31 - Replacing content ok 32 - Removing files ok 33 - Proper files remaining Use of uninitialized value in print at /home/hwadm/.cpan/build/Archive-Tar-1.00/blib/lib/Archive/Tar.pm line 704. Use of uninitialized value in print at /home/hwadm/.cpan/build/Archive-Tar-1.00/blib/lib/Archive/Tar.pm line 704. ok 34 - Writing tarfile using 'write()' ok 35 - File written ok 36 - Writing tarfile using 'create_archive()' ok 37 - File written Use of uninitialized value in print at /home/hwadm/.cpan/build/Archive-Tar-1.00/blib/lib/Archive/Tar.pm line 704. Use of uninitialized value in print at /home/hwadm/.cpan/build/Archive-Tar-1.00/blib/lib/Archive/Tar.pm line 704. ok 38 - Writing compressed file using 'write()' ok 39 - File written ok 40 - Writing compressed file using 'create_archive()' ok 41 - File written ok 42 - Found expected files ok 43 - Extracting files using 'extract()' ok 44 - Expected file found ok 45 - Opening file ok 46 - Contents OK ok 47 - Expected file found ok 48 - Opening file ok 49 - Contents OK ok 50 - Expected file found ok 51 - Opening file ok 52 - Contents OK ok 53 - Extracting files using 'extract_archive()' ok 54 - Expected file found ok 55 - Opening file ok 56 - Contents OK ok 57 - Expected file found ok 58 - Opening file ok 59 - Contents OK ok 60 - Expected file found ok 61 - Opening file ok 62 - Contents OK ok 63 - Limited read ok 64 - Expected file found ok 65 - Found old data ok 66 - Clearing old data ok 67 - Old data cleared 1..67 ok All tests successful. Files=2, Tests=69, 4 wallclock secs ( 1.88 cusr + 0.48 csys = 2.36 CPU)

Mon Jun 02 09:19:48 2003 kane [...] dwim.org - Correspondence added

Date:	Mon, 2 Jun 2003 15:19:44 +0200
Subject:	Re: [cpan #2721] uninitialized values in test of Archive-Tar-1.00
From:	"Jos I. Boumans" <kane [...] dwim.org>
To:	bug-Archive-Tar [...] rt.cpan.org
RT-Send-Cc:

On Monday, Jun 2, 2003, at 10:57 Europe/Amsterdam, Guest via RT wrote: Show quoted text

> Solaris 7 (Sparc), Perl 5.8.0 (ithreads, shared libperl), compiled > with Forte 6.2, latest Compress::Zlib and IO::Zlib. > > (and also on RedHat Linux 7.2, gcc): > > The ->data method seems to return "undef" in line 704...

i'm unable to reproduce this on any of my systems... can you add some debug info (dumpers of the file objects might work here), and mail me that? -- Jos Boumans "You know you are never more indignant in life than when you're shopping at a store you feel is beneath you and one of the other customers mistakes you for one of the employees of that store." - Dennis Miller CPANPLUS http://cpanplus.sf.net

Mon Jun 02 10:01:36 2003 Guest - Correspondence added

From:

marek.rouchal [...] infineon.com

[kane@dwim.org - Mon Jun 2 09:19:48 2003]: Show quoted text

> i'm unable to reproduce this on any of my systems... can you add some > debug info (dumpers of the file objects might work here), and mail me > that?

Hope this helps a bit - it seems to me that the entry shown does not have a "data" key in the hash - perhaps it was not properly initialized? $ perl -d -Mblib t/02_methods.t main::(t/02_methods.t:11): my $tar = new Archive::Tar; DB<1> b Archive::Tar::_write_to_handle DB<2> r ok 1 - Object created isa Archive::Tar ok 2 - Reading uncompressed file using 'read()' ok 3 - All files accounted for ok 4 - Content OK ok 5 - Content OK ok 6 - Content OK ok 7 - Reading uncompressed file using 'list_archive()' ok 8 - All files accounted for ok 9 - Found expected file ok 10 - Found expected file ok 11 - Found expected file ok 12 - Reading compressed file using 'read()' ok 13 - All files accounted for ok 14 - Content OK ok 15 - Content OK ok 16 - Content OK ok 17 - Reading compressed file using 'list_archive()' ok 18 - All files accounted for ok 19 - Found expected file ok 20 - Found expected file ok 21 - Found expected file ok 22 - Adding files ok 23 - Proper name ok 24 - Proper type ok 25 - Content OK ok 26 - Adding data ok 27 - Proper name ok 28 - Proper type ok 29 - Content OK ok 30 - Renaming ok 31 - Replacing content ok 32 - Removing files ok 33 - Proper files remaining Archive::Tar::_write_to_handle(/home/hwadm/.cpan/build/Archive-Tar- 1.00/blib/lib/Archive/Tar.pm:684): 684: my $self = shift; DB<2> n [... a couple of n's removed ...] Archive::Tar::_write_to_handle(/home/hwadm/.cpan/build/Archive-Tar- 1.00/blib/lib/Archive/Tar.pm:704): 704: print $handle $entry->data or ( 705: $self->_error( qq[Could not write data for: ] . $entry->name ), 706: return undef 707: ); DB<2> x $handle 0 IO::File=GLOB(0x84ca97c) -> *Symbol::GEN5 FileHandle({*Symbol::GEN5}) => fileno(3) DB<3> x $entry 0 Archive::Tar::File=HASH(0x85f5144) 'chksum' => 5045 'devmajor' => 0 'devminor' => 0 'gid' => 20 'gname' => 'staff' 'linkname' => '' 'magic' => 'ustar' 'mode' => 16877 'mtime' => 1051037954 'name' => 'directory/' 'prefix' => '' 'raw' => "directory/ \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@ \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@ \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@ \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@0040755\c@0000765 \c@0000024\c@00000000000\c@07651310402\c@011665\c@ 5 \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@ \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@ \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@ \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@ \c@\c@\c@\c@ustar \c@kane\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c @\c@\c@\c@\c@\c@\c@staff\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@ \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@ \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@ \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@ \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@ \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@ \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@ \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@ \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@ \c@\c@" 'size' => 0 'type' => 5 'uid' => 501 'uname' => 'kane' 'version' => '' DB<4> s Archive::Tar::File::CODE(0x8506cec)(/home/hwadm/.cpan/build/Archive-Tar- 1.00/blib/lib/Archive/Tar/File.pm:43): 43: my $self = shift;

Mon Jun 02 10:24:31 2003 kane [...] dwim.org - Correspondence added

Date:	Mon, 2 Jun 2003 16:24:26 +0200
Subject:	Re: [cpan #2721] uninitialized values in test of Archive-Tar-1.00
From:	"Jos I. Boumans" <kane [...] dwim.org>
To:	bug-Archive-Tar [...] rt.cpan.org
RT-Send-Cc:

On Monday, Jun 2, 2003, at 16:01 Europe/Amsterdam, Guest via RT wrote: Show quoted text

> > This message about Archive-Tar was sent to you by guest <> via > rt.cpan.org > > Full context and any attached attachments can be found at: > <URL: https://rt.cpan.org/Ticket/Display.html?id=2721 > > > [kane@dwim.org - Mon Jun 2 09:19:48 2003]:

>> i'm unable to reproduce this on any of my systems... can you add some >> debug info (dumpers of the file objects might work here), and mail me >> that?

> > Hope this helps a bit - it seems to me that the entry shown does > not have a "data" key in the hash - perhaps it was not properly > initialized?

no, it seems to me the problem is when it's writing out a directory. and directories don't have 'data' like a normal file does.. i'm not sure why it warns for you and not for me though. anyway, below the sig is a patch, try it, i think it should quell the warnings. Show quoted text

> ok 33 - Proper files remaining > Archive::Tar::_write_to_handle(/home/hwadm/.cpan/build/Archive-Tar- > 1.00/blib/lib/Archive/Tar.pm:684): > 684: my $self = shift; > DB<2> n > [... a couple of n's removed ...] > Archive::Tar::_write_to_handle(/home/hwadm/.cpan/build/Archive-Tar- > 1.00/blib/lib/Archive/Tar.pm:704): > 704: print $handle $entry->data or ( > 705: $self->_error( qq[Could not write data for: ] . > $entry->name ), > 706: return undef > 707: ); > DB<2> x $handle > 0 IO::File=GLOB(0x84ca97c) > -> *Symbol::GEN5 > FileHandle({*Symbol::GEN5}) => fileno(3) > DB<3> x $entry > 0 Archive::Tar::File=HASH(0x85f5144) > 'chksum' => 5045 > 'devmajor' => 0 > 'devminor' => 0 > 'gid' => 20 > 'gname' => 'staff' > 'linkname' => '' > 'magic' => 'ustar' > 'mode' => 16877 > 'mtime' => 1051037954 > 'name' => 'directory/' > 'prefix' => '' > 'raw' => "directory/ > \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c > @ > \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c > @ > \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c > @ > \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@0040755\c@0000765 > \c@0000024\c@00000000000\c@07651310402\c@011665\c@ 5 > \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c > @ > \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c > @ > \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c > @ > \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c > @ > \c@\c@\c@\c@ustar > \c@kane\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\ > c > @\c@\c@\c@\c@\c@\c@staff\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c > @ > \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c > @ > \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c > @ > \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c > @ > \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c > @ > \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c > @ > \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c > @ > \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c > @ > \c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c@\c > @ > \c@\c@" > 'size' => 0 > 'type' => 5 > 'uid' => 501 > 'uname' => 'kane' > 'version' => '' >

-- Jos Boumans "If superman is so smart, why does he wear underpants over his trousers?" CPANPLUS http://cpanplus.sf.net ==== //member/kane/archive-tar-new/lib/Archive/Tar.pm#27 - /Users/kane/p4/other/archive-tar-new/lib/Archive/Tar.pm ==== 703a704 Show quoted text

> if( length $entry->data ) {

708c709 < #} --- Show quoted text

> }

Tue Jun 03 08:00:49 2003 Guest - Correspondence added

From:

marek.rouchal [...] infineon.com

Show quoted text

>> Hope this helps a bit - it seems to me that the entry shown does >> not have a "data" key in the hash - perhaps it was not properly >> initialized?

> >no, it seems to me the problem is when it's writing out a directory. >and directories don't have 'data' like a normal file does.. i'm not >sure why it warns for you and not for me though. > >anyway, below the sig is a patch, try it, i think it should quell the >warnings. > >==== //member/kane/archive-tar-new/lib/Archive/Tar.pm#27 - >/Users/kane/p4/other/archive-tar-new/lib/Archive/Tar.pm ==== >703a704

> > if( length $entry->data ) {

>708c709 >< #} >---

> > }

Well, I don't think this will work - the length() function will also complain about an undefined value! Note that if there is no such key in the hash, then the value of this key will be "undef". The "if" should be sth. like this maybe: if( $entry->has_data ) { ... } and of course we need a method in Archive::Tar::File: sub has_data { exists(shift->{data}); } Hope this helps, Marek

Wed Jun 04 14:32:57 2003 Guest - Correspondence added

From:

blaise [...] hobbystage.net

Worst problem with FreeBSD on 486 Show quoted text

cpan> install Archive::Tar

Running install for module Archive::Tar Running make for K/KA/KANE/Archive-Tar-1.00.tar.gz Is already unwrapped into directory /root/.cpan/build/Archive-Tar- 1.00 Has already been processed within this session Running make test PERL_DL_NONLAZY=1 /usr/bin/perl -Iblib/arch -Iblib/lib - I/usr/local/lib/perl5/5.6.1/i386-freebsd-thread-multi - I/usr/local/lib/perl5/5.6.1 -e 'use Test::Harness qw(&runtests $verbose); $verbose=0; runtests @ARGV;' t/*.t t/01_use............ok t/02_methods........Use of uninitialized value in print at blib/lib/Archive/Tar.pm line 704. Use of uninitialized value in print at blib/lib/Archive/Tar.pm line 704. Use of uninitialized value in print at blib/lib/Archive/Tar.pm line 704. Use of uninitialized value in print at blib/lib/Archive/Tar.pm line 704. t/02_methods........FAILED tests 1- 67 Failed 67/67 tests, 0.00% okay Failed Test Status Wstat Total Fail Failed List of Failed ----------------------------------------------------------------------- --------- t/02_methods.t 67 67 100.00% 1-67 Failed 1/2 test scripts, 50.00% okay. 67/69 subtests failed, 2.90% okay. *** Error code 35 Stop in /root/.cpan/build/Archive-Tar-1.00. /usr/bin/make test -- NOT OK Running make install make test had returned bad status, won't install without force

Sat Jun 07 05:35:27 2003 kane [...] dwim.org - Correspondence added

Date:	Sat, 7 Jun 2003 11:35:17 +0200
Subject:	Re: [cpan #2721] uninitialized values in test of Archive-Tar-1.00
From:	"Jos I. Boumans" <kane [...] dwim.org>
To:	bug-Archive-Tar [...] rt.cpan.org
RT-Send-Cc:

On Wednesday, Jun 4, 2003, at 20:32 Europe/Amsterdam, Guest via RT wrote: Show quoted text

> This message about Archive-Tar was sent to you by guest <> via > rt.cpan.org

i'm sorry, i'll need a slightly better bug report than this. Show quoted text

> Full context and any attached attachments can be found at: > <URL: https://rt.cpan.org/Ticket/Display.html?id=2721 >

1) if you're not sure it's the same bug, please file a different bug -- uninitialized variables do not make /all/ tests fail. Show quoted text

> Worst problem with FreeBSD on 486

2) what freebsd? what configuration? what perl? what perl configuaration? Show quoted text

> cpan> install Archive::Tar

3) what happens if you install it manually? is this perhaps a CPAN.pm bug? Show quoted text

> t/02_methods........FAILED tests 1- > 67 > Failed 67/67 tests, 0.00% okay > Failed Test Status Wstat Total Fail Failed List of Failed

4) i need the test output -- otherwise i have no idea of knowing what is broken. please run the test seperately with TEST_VERBOSE = 1 -- Jos Boumans "You know you are never more indignant in life than when you're shopping at a store you feel is beneath you and one of the other customers mistakes you for one of the employees of that store." - Dennis Miller CPANPLUS http://cpanplus.sf.net

Sat Jun 07 05:44:35 2003 kane [...] dwim.org - Correspondence added

Date:	Sat, 7 Jun 2003 11:44:29 +0200
Subject:	Re: [cpan #2721] uninitialized values in test of Archive-Tar-1.00
From:	"Jos I. Boumans" <kane [...] dwim.org>
To:	bug-Archive-Tar [...] rt.cpan.org
RT-Send-Cc:

On Tuesday, Jun 3, 2003, at 14:00 Europe/Amsterdam, Guest via RT wrote: Show quoted text

>> ==== //member/kane/archive-tar-new/lib/Archive/Tar.pm#27 - >> /Users/kane/p4/other/archive-tar-new/lib/Archive/Tar.pm ==== >> 703a704

>>> if( length $entry->data ) {

>> 708c709 >> < #} >> ---

>>> }

> > Well, I don't think this will work - the length() function > will also complain about an undefined value!

d'oh, it's kinda hard fixing a problem that doesn't exist on your own box =/ Show quoted text

> Note that if > there is no such key in the hash, then the value of this > key will be "undef".

which is fine Show quoted text

> and of course we need a method in > Archive::Tar::File: > > sub has_data { > exists(shift->{data}); > } >

i applied the following patches: ==== //member/kane/archive-tar-new/lib/Archive/Tar.pm#30 (text) ==== 712c712 < if( length $entry->data ) { --- Show quoted text

> if( $entry->has_content ) {

==== //member/kane/archive-tar-new/lib/Archive/Tar/File.pm#14 (text) ==== 337a338,351 Show quoted text

> =head2 has_content > > Returns a boolean to indicate whether the current object has content. > Some special files like directories and so on never will have any > content. This method is mainly to make sure you don't get warnings > for using unitialized values when looking at an objects's content. > > =cut > > sub has_content { > my $self = shift; > return defined $self->data() && length $self->data() ? 1 : 0; > } >

==== //member/kane/archive-tar-new/lib/Archive/Tar/File.pm#15 (text) ==== 45c45,49 < return $self->{$key}; --- Show quoted text

> > ### just in case the key is not there or undef or something

### Show quoted text

> { local $^W = 0; > return $self->{$key}; > }

and these still make all my tests succeed... perhaps you can try them on your system and verify that they also fix the problem you reported? -- Jos Boumans "Cocaine is God's way of telling you you make too much money" CPANPLUS http://cpanplus.sf.net

Tue Jun 10 08:44:54 2003 Guest - Correspondence added

Subject:	SOLVED, BUT: uninitialized values in test of Archive-Tar-1.00
From:	marek.rouchal [...] infineon.com

[kane@dwim.org - Sat Jun 7 05:44:35 2003]: Show quoted text

> i applied the following patches: > ... > and these still make all my tests succeed... perhaps you can try them > on your system > and verify that they also fix the problem you reported?

The version 1.01 fixes the problem described in this ticket - however I get a new one :-/ $ make test TEST_VERBOSE=1 PERL_DL_NONLAZY=1 /opt/perl_5.8.0/bin/perl "-MExtUtils::Command::MM" "- e" "test_harness(1, 'blib/lib', 'blib/arch')" t/*.t t/01_use........1..2 Useless use of a constant in void context at /home/hwadm/.cpan/build/Archive-Tar- 1.01/blib/lib/Archive/Tar/File.pm line 395. ok 1 - use Archive::Tar; ok 2 - Object created isa Archive::Tar ok This can be fixed easily with this patch (see also perlop for the operator precedence): --- lib/Archive/Tar/File.pm.orig 2003-06-10 14:43:01.490721000 +0200 +++ lib/Archive/Tar/File.pm 2003-06-10 14:43:08.605720000 +0200 @@ -392,7 +392,7 @@ sub replace_content { my $self = shift; - my $data = shift or ''; + my $data = shift || ''; $self->data( $data ); $self->size( length $data );

Tue Jun 10 09:00:20 2003 kane [...] dwim.org - Correspondence added

Date:	Tue, 10 Jun 2003 14:59:58 +0200
Subject:	Re: [cpan #2721] SOLVED, BUT: uninitialized values in test of Archive-Tar-1.00
From:	"Jos I. Boumans" <kane [...] dwim.org>
To:	bug-Archive-Tar [...] rt.cpan.org
RT-Send-Cc:

On Tuesday, Jun 10, 2003, at 14:44 Europe/Amsterdam, Guest via RT wrote: Show quoted text

> The version 1.01 fixes the problem described in this ticket - > however I get a new one :-/

Show quoted text

> --- lib/Archive/Tar/File.pm.orig 2003-06-10 14:43:01.490721000 +0200 > +++ lib/Archive/Tar/File.pm 2003-06-10 14:43:08.605720000 +0200 > @@ -392,7 +392,7 @@ > > sub replace_content { > my $self = shift; > - my $data = shift or ''; > + my $data = shift || ''; > > $self->data( $data ); > $self->size( length $data );

this seems like a silly oopsie. thanks for spotting -- Jos Boumans "You know you are never more indignant in life than when you're shopping at a store you feel is beneath you and one of the other customers mistakes you for one of the employees of that store." - Dennis Miller CPANPLUS http://cpanplus.sf.net

Fri Jun 13 10:56:35 2003 kane [...] cpan.org - Fixed in 1.02 added

Fri Jun 13 10:57:12 2003 kane [...] cpan.org - Status changed from 'new' to 'resolved'