| Subject: | please make the rsync tests optional |
Hi,
when File::Rsync is installed, the rsync tests are currently run
unconditionally. This may be undesirable in some cases, as they need a
connection to localhost to pass. Please consider making the rsync tests
optional, eg. by prompting in a similar way as with Net::SSH.
Proposed patch attached; I suppose some more documentation in README
would also be in order.
Again, thanks for your work on SVN::Notify::Mirror,
--
Niko Tyni (on behalf of the Debian Perl Group)
ntyni@iki.fi
| Subject: | svn-notify-rsync.patch |
--- libsvn-notify-mirror-perl-0.03602.orig/Build.PL
+++ libsvn-notify-mirror-perl-0.03602/Build.PL
@@ -54,7 +54,10 @@
}
if ( $mb->feature('rsync_support') ) {
- $mb->notes( rsynctests => 1 );
+ $mb->notes( rsynctests => 1 ) if
+ $mb->y_n(
+ "Do you want to run the rsync tests?\n".
+ "(see the README for details)",'N');
}
$mb->create_build_script;