Skip Menu |

This queue is for tickets about the WWW-CheckSite CPAN distribution.

Report information
The Basics
Id: 27099
Status: resolved
Priority: 0/
Queue: WWW-CheckSite
People
Owner: abeltje [...] cpan.org
Requestors: peter [...] peknet.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Fri May 11 15:28:13 2007 peter [...] peknet.com - Ticket created
Subject: 0.017 make test fails -- patch attached
Date: Fri, 11 May 2007 14:26:07 -0500
To: bug-www-checksite [...] rt.cpan.org
From: Peter Karman <peter [...] peknet.com>
--- lib/WWW/CheckSite/Spider.pm 2007-04-30 08:13:26.000000000 -0500 +++ /tmp/WWW-CheckSite-0.017/blib/lib/WWW/CheckSite/Spider.pm 2007-05-11 14:23:00.000000000 -0500 @@ -248,7 +248,7 @@ my @candidates = $self->links_filtered; - my $new_base = $mech->uri; + my $new_base = URI->new( $mech->uri ); $new_base->canonical ne URI->new( $base )->canonical and $cache->set( $new_base => $this_page ); -- Peter Karman . http://peknet.com/ . peter@peknet.com
  Sun May 13 07:58:51 2007 abeltje [...] cpan.org - Taken
  Sun May 13 08:08:19 2007 abeltje [...] cpan.org - Correspondence added
On Fri May 11 15:28:13 2007, peter@peknet.com wrote: Show quoted text
> --- lib/WWW/CheckSite/Spider.pm 2007-04-30 08:13:26.000000000 -0500 > +++ /tmp/WWW-CheckSite-0.017/blib/lib/WWW/CheckSite/Spider.pm 2007-
05-11 Show quoted text
> 14:23:00.000000000 -0500 > @@ -248,7 +248,7 @@ > > my @candidates = $self->links_filtered; > > - my $new_base = $mech->uri; > + my $new_base = URI->new( $mech->uri );
I see no use in making a new URI as $mech->uri() is documented to return a URI object and $mech is not used anywhere else in that sub. Please explain? TIA, -- Abe.
  Sun May 13 08:08:23 2007 The RT System itself - Status changed from 'new' to 'open'
  Sun May 13 13:58:04 2007 peter [...] peknet.com - Correspondence added
Subject: Re: [rt.cpan.org #27099] 0.017 make test fails -- patch attached
Date: Sun, 13 May 2007 12:57:31 -0500
To: bug-WWW-CheckSite [...] rt.cpan.org
From: Peter Karman <peter [...] peknet.com>
via RT scribbled on 5/13/07 7:08 AM: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=27099 > > > On Fri May 11 15:28:13 2007, peter@peknet.com wrote:
>> --- lib/WWW/CheckSite/Spider.pm 2007-04-30 08:13:26.000000000 -0500 >> +++ /tmp/WWW-CheckSite-0.017/blib/lib/WWW/CheckSite/Spider.pm 2007-
> 05-11
>> 14:23:00.000000000 -0500 >> @@ -248,7 +248,7 @@ >> >> my @candidates = $self->links_filtered; >> >> - my $new_base = $mech->uri; >> + my $new_base = URI->new( $mech->uri );
> > I see no use in making a new URI as $mech->uri() is documented to > return a URI object and $mech is not used anywhere else in that sub. > > > Please explain?
Sorry. False alarm. That patch fixed the particular 'make test' issue I was having: t/02spider........ok 1/19Can't locate object method "canonical" via package "http://localhost:32821/index.html" (perhaps you forgot to load "http://localhost:32821/index.html"?) at /tmp/WWW-CheckSite-0.017/blib/lib/WWW/CheckSite/Spider.pm line 253. but now I realize I had an older WWW::Mechanize (was 1.16, now 1.24). Upgrading that and Sub::Uplevel to newest fixed the issue. Perhaps a required minimum version of WWW::Mechanize in the Makefile.PL would have caught this? Sorry to waste your time, pek -- Peter Karman . http://peknet.com/ . peter@peknet.com
  Sun May 13 17:16:40 2007 abeltje [...] cpan.org - Correspondence added
On Sun May 13 13:58:04 2007, peter@peknet.com wrote: [snip] Show quoted text
> Sorry. False alarm. That patch fixed the particular 'make test' issue > I was having: > > t/02spider........ok 1/19Can't locate object method "canonical" via > package > "http://localhost:32821/index.html" (perhaps you forgot to load > "http://localhost:32821/index.html"?) at > /tmp/WWW-CheckSite-0.017/blib/lib/WWW/CheckSite/Spider.pm line 253. > > > but now I realize I had an older WWW::Mechanize (was 1.16, now 1.24). > Upgrading > that and Sub::Uplevel to newest fixed the issue. > > Perhaps a required minimum version of WWW::Mechanize in the > Makefile.PL would > have caught this?
You are quite right! Some digging in the WWW::Mechanize history, shows the uri() method is only documented to be a URI object from version 1.20 I've upped the required version of WWW::Mechize to 1.20 Show quoted text
> Sorry to waste your time,
Nope, you helped! thanks! -- Abe.
  Sun May 13 17:16:43 2007 abeltje [...] cpan.org - Status changed from 'open' to 'resolved'