Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 27065
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: bwarfield [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Unimportant
Broken in: 1.04
Fixed in: (no value)

History Show all quoted text
  Thu May 10 12:55:32 2007 bwarfield [...] cpan.org - Ticket created
Subject: Policy::CodeLayout::ProhibitTrailingWhitespace breaks under Perl 5.6.1
The "_escape" sub of Perl::Critic::Policy::CodeLayout::ProhibitTrailingWhitespace uses the subroutine "charnames::viacode", which does not exist in the version of the "charnames" module distributed with 5.6.1 (which apparently cannot be upgraded without upgrading the entire perl distribution). This causes the tests in t/20_policy_prohibittrailingwhitespace to fail. A suggested fix would be to skip those tests if the perl version is too low (I think any 5.8 series perl has this function available).
  Thu May 17 12:25:52 2007 jeffrey_thalhammer [...] yahoo.com - Correspondence added
Subject: Re: [rt.cpan.org #27065] Policy::CodeLayout::ProhibitTrailingWhitespace breaks under Perl 5.6.1
Date: Thu, 17 May 2007 09:25:20 -0700 (PDT)
To: bug-Perl-Critic [...] rt.cpan.org
From: Jeffrey Thalhammer <jeffrey_thalhammer [...] yahoo.com>
Show quoted text
> The "_escape" sub of ProhibitTrailingWhitespace > uses the subroutine "charnames::viacode", which > does not exist in the version of the "charnames" > module distributed with 5.6.1 (which apparently > cannot be upgraded without upgrading the entire perl > distribution). This causes the tests in > t/20_policy_prohibittrailingwhitespace to fail.
Hmmm. So I wonder if this policy is completely broken on perls <= 5.6.1. If so maybe this policy should just always return no violations when run with those perls. Thanks for reporting this. I'll check it out. ____________________________________________________________________________________Shape Yahoo! in your own image. Join our Network Research Panel today! http://surveylink.yahoo.com/gmrs/yahoo_panel_invite.asp?a=7
  Thu May 17 12:25:55 2007 The RT System itself - Status changed from 'new' to 'open'
  Tue Jun 05 21:47:20 2007 thaljef [...] cpan.org - Correspondence added
Fixed and released as Perl-Critic-1.053. Thanks for reporting this.
  Tue Jun 05 21:47:24 2007 thaljef [...] cpan.org - Status changed from 'open' to 'resolved'