Skip Menu |

This queue is for tickets about the Tk-Wizard CPAN distribution.

Report information
The Basics
Id: 27023
Status: resolved
Worked: 27 min
Priority: 0/
Queue: Tk-Wizard

People
Owner: LGODDARD [...] cpan.org
Requestors: LGODDARD [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 2.005
Fixed in: (no value)



Subject: Fails tests on Debian Sarge, Perl 588
CPAN.pm: Going to build M/MT/MTHURN/Tk-Wizard-2.005.tar.gz Checking if your kit is complete... Looks good Writing Makefile for Tk::Wizard cp lib/Tk/Wizard/Image.pm blib/lib/Tk/Wizard/Image.pm cp lib/Tk/Wizard.pm blib/lib/Tk/Wizard.pm cp lib/Tk/Wizard/Installer.pm blib/lib/Tk/Wizard/Installer.pm cp lib/Tk/Wizard/Installer/Win32.pm blib/lib/Tk/Wizard/Installer/Win32.pm Manifying blib/man3/Tk::Wizard::Image.3pm Manifying blib/man3/Tk::Wizard.3pm Manifying blib/man3/Tk::Wizard::Installer.3pm Manifying blib/man3/Tk::Wizard::Installer::Win32.3pm MTHURN/Tk-Wizard-2.005.tar.gz /usr/bin/make -- OK Running make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "- e" "test_harness (0, 'inc', 'blib/lib', 'blib/arch')" t/*.t t/05_Wizard.........ok 1/0couldn't connect to display ":0" at /usr/lib/perl5/Tk/ MainWindow.pm line 55. Tk::MainWindow->new() at /home/scrawley/.cpan/build/Tk-Wizard-2.005- 06RtRI/blib/ lib/Tk/Wizard.pm line 307 # Looks like your test died just after 1. t/05_Wizard.........dubious Test returned status 255 (wstat 65280, 0xff00) after all the subtests completed successfully t/06_AutoDestroy....ok 1/25couldn't connect to display ":0" at /usr/lib/perl5/Tk /MainWindow.pm line 55. Tk::MainWindow->new() at /home/scrawley/.cpan/build/Tk-Wizard-2.005- 06RtRI/blib/ lib/Tk/Wizard.pm line 307 # Looks like you planned 25 tests but only ran 1. # Looks like your test died just after 1. t/06_AutoDestroy....dubious Test returned status 255 (wstat 65280, 0xff00) DIED. FAILED tests 2-25 Failed 24/25 tests, 4.00% okay t/10_Wizard.........ok 1/0couldn't connect to display ":0" at /usr/lib/perl5/Tk/ MainWindow.pm line 55. Tk::MainWindow->new() at /home/scrawley/.cpan/build/Tk-Wizard-2.005- 06RtRI/blib/ lib/Tk/Wizard.pm line 307 # Looks like your test died just after 1. t/10_Wizard.........dubious Test returned status 255 (wstat 65280, 0xff00) after all the subtests completed successfully t/20_bad_arg........ok 1/0couldn't connect to display ":0" at /usr/lib/perl5/Tk/ MainWindow.pm line 55. Tk::MainWindow->new() at /home/scrawley/.cpan/build/Tk-Wizard-2.005- 06RtRI/blib/ lib/Tk/Wizard.pm line 307 # Looks like your test died just after 1. t/20_bad_arg........dubious Test returned status 255 (wstat 65280, 0xff00) after all the subtests completed successfully t/22_skip...........ok 1/0couldn't connect to display ":0" at /usr/lib/perl5/Tk/ MainWindow.pm line 55. Tk::MainWindow->new() at /home/scrawley/.cpan/build/Tk-Wizard-2.005- 06RtRI/blib/ lib/Tk/Wizard.pm line 307 # Looks like your test died just after 1. t/22_skip...........dubious Test returned status 255 (wstat 65280, 0xff00) after all the subtests completed successfully t/25_TaskList.......ok 1/6couldn't connect to display ":0" at /usr/lib/perl5/Tk/ MainWindow.pm line 55. Tk::MainWindow->new() at /home/scrawley/.cpan/build/Tk-Wizard-2.005- 06RtRI/blib/ lib/Tk/Wizard.pm line 307 # Looks like you planned 6 tests but only ran 1. # Looks like your test died just after 1. t/25_TaskList.......dubious Test returned status 255 (wstat 65280, 0xff00) DIED. FAILED tests 2-6 Failed 5/6 tests, 16.67% okay t/30_pb.............ok 1/0couldn't connect to display ":0" at /usr/lib/perl5/Tk/ MainWindow.pm line 55. Tk::MainWindow->new() at /home/scrawley/.cpan/build/Tk-Wizard-2.005- 06RtRI/blib/ lib/Tk/Wizard.pm line 307 # Looks like your test died just after 2. t/30_pb.............dubious Test returned status 255 (wstat 65280, 0xff00) after all the subtests completed successfully t/40_Win32..........ok 1/2 skipped: various reasons t/50_Installer......ok 2/18couldn't connect to display ":0" at /usr/lib/perl5/Tk /MainWindow.pm line 55. Tk::MainWindow->new() at /home/scrawley/.cpan/build/Tk-Wizard-2.005- 06RtRI/blib/ lib/Tk/Wizard.pm line 307 # Looks like you planned 18 tests but only ran 2. # Looks like your test died just after 2. t/50_Installer......dubious Test returned status 255 (wstat 65280, 0xff00) DIED. FAILED tests 3-18 Failed 16/18 tests, 11.11% okay t/52_Installer......ok 1/0couldn't connect to display ":0" at /usr/lib/perl5/Tk/ MainWindow.pm line 55. Tk::MainWindow->new() at /home/scrawley/.cpan/build/Tk-Wizard-2.005- 06RtRI/blib/ lib/Tk/Wizard.pm line 307 # Looks like your test died just after 9. t/52_Installer......dubious Test returned status 255 (wstat 65280, 0xff00) after all the subtests completed successfully t/70_TopLevel.......ok 1/0couldn't connect to display ":0" at /usr/lib/perl5/Tk/ MainWindow.pm line 55. Tk::MainWindow->new() at t/70_TopLevel.t line 33 # Looks like your test died just after 1. t/70_TopLevel.......dubious Test returned status 255 (wstat 65280, 0xff00) after all the subtests completed successfully t/77_dirselect......ok 1/0couldn't connect to display ":0" at /usr/lib/perl5/Tk/ MainWindow.pm line 55. Tk::MainWindow->new() at /home/scrawley/.cpan/build/Tk-Wizard-2.005- 06RtRI/blib/ lib/Tk/Wizard.pm line 307 # Looks like your test died just after 1. t/77_dirselect......dubious Test returned status 255 (wstat 65280, 0xff00) after all the subtests completed successfully t/99_prepost........ok 1/33couldn't connect to display ":0" at /usr/lib/perl5/Tk /MainWindow.pm line 55. Tk::MainWindow->new() at /home/scrawley/.cpan/build/Tk-Wizard-2.005- 06RtRI/blib/ lib/Tk/Wizard.pm line 307 # Looks like you planned 33 tests but only ran 1. # Looks like your test died just after 1. t/99_prepost........dubious Test returned status 255 (wstat 65280, 0xff00) DIED. FAILED tests 2-33 Failed 32/33 tests, 3.03% okay t/pod...............ok Failed Test Stat Wstat Total Fail List of Failed ------------------------------------------------------------------------ ------- t/05_Wizard.t 255 65280 1 0 ?? t/06_AutoDestroy.t 255 65280 25 48 2-25 t/10_Wizard.t 255 65280 1 0 ?? t/20_bad_arg.t 255 65280 1 0 ?? t/22_skip.t 255 65280 1 0 ?? t/25_TaskList.t 255 65280 6 10 2-6 t/30_pb.t 255 65280 2 0 ?? t/50_Installer.t 255 65280 18 32 3-18 t/52_Installer.t 255 65280 9 0 ?? t/70_TopLevel.t 255 65280 1 0 ?? t/77_dirselect.t 255 65280 1 0 ?? t/99_prepost.t 255 65280 33 64 2-33 1 subtest skipped. Failed 12/14 test scripts. 77/105 subtests failed. Files=14, Tests=105, 81 wallclock secs ( 6.97 cusr + 0.44 csys = 7.41 CPU) Failed 12/14 test programs. 77/105 subtests failed. make: *** [test_dynamic] Error 255 MTHURN/Tk-Wizard-2.005.tar.gz /usr/bin/make test -- NOT OK Running make install make test had returned bad status, won't install without force Failed during this command: MTHURN/Tk-Wizard-2.005.tar.gz : make_test NO
Note: this is for an install overy tty - *no display*!
How can I tell if there is a display available...? I guess if there is no display, we can compose pages but cannot call the main loop.
IMO this is NOT a problem we can be expected to avoid. All Tk modules have this vulnerability. Even if we detect whether DISPLAY is set, the connection might be refused when we do try to create a window. My suggestion is to close this and forget about it. 8-) -- - - Martin 'Kingpin' Thurn
Here http://www.perlmonks.org/?node_id=432975 is a LENGTHY discussion about detecting whether a GUI display is available. And another thought from me: it should be the responsibility of the APPLICATION PROGRAMMER to decide whether they want to call the Wizard. We're just giving them window tools, THEY should decide when they want to use our tools. -- - - Martin 'Kingpin' Thurn
Subject: Re: [rt.cpan.org #27023] Fails tests on Debian Sarge, Perl 588
Date: Thu, 10 May 2007 20:32:20 +0100
To: bug-Tk-Wizard [...] rt.cpan.org
From: Lee Goddard <London [...] LeeGoddard.net>
:-) I know that Tk-Wizard has a major refactor coming, and that the failure of a test script in a 1% case may seem comparatively unimportant, but --- still, y'know? Certain standards, etc. If only I applied the same standards to the housework, my wife is saying... Lee
Subject: Re: [rt.cpan.org #27023] Fails tests on Debian Sarge, Perl 588
Date: Thu, 10 May 2007 20:37:29 +0100
To: bug-Tk-Wizard [...] rt.cpan.org
From: Lee Goddard <London [...] LeeGoddard.net>
Martin Thurn via RT wrote: Show quoted text
> Queue: Tk-Wizard > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=27023 > > > Here http://www.perlmonks.org/?node_id=432975 is a LENGTHY > discussion about detecting whether a GUI display is available. >
Thanks, will look into it next week. Show quoted text
> And another thought from me: it should be the responsibility of the > APPLICATION PROGRAMMER to decide whether they want to call the Wizard. > We're just giving them window tools, THEY should decide when they want > to use our tools. >
Yes and no. Yes, because the Wizard has started to turn into a real Widget, slowly, even though that is not how it started out. So I hope to advertise components more, and generally be more conventional in being a component. Hence the lack of MainWindow creation (presuming that got onto CPAN, which from your earlier tickets I think it may not have done). On the other hand, we are a Perl module, not a Tk or TCL module, and so we should aim to pass conventional Perl module installation procedure (though not bow to the current beauty of the day). Frankly, when my own module fails on my own machine, something is wrong...! -- Lee Goddard Mail: lee@leegoddard.net www: www.LeeGoddard.net MSN: idontwantahotmailaccount@msn.com Tel: 0208 444 5357
AOK now. -- lgoddard at cpan org http://www.LeeGoddard.net