Bug #27012 for Authen-Htpasswd: 05edit.t error

On Tue Jul 17 05:41:36 2007, CHORNY wrote: Show quoted text
I'll guess that these failures are seen with bleadperl. It appears that there's been a change in the semantics of backslash, such that the expression m/^\Q$username\:/, which used to match a username followed by colon, now matches a username followed by a literal backslash followed by a colon (tested with 5.8.8 vs. 5.9.5). The docs in perlop and perlre aren't specific enough about the desired semantics of backslash to prove whether this is a bug or correct behavior. The general statements that "anything that looks like" . \[^[:alnum:]] . "is interpreted as a literal character" (perlre) and "Let it be stressed that whatever falls between \Q and \E is interpolated in the usual way: (perlop) would seem to indicate that "\:" and "\Q\:" should have identical behavior. However, the repeated warnings about undesired behavior of backslash within quotemeta appear to indicate that the difference is intended behavior. The attached patch, which simply places a \E before the \: (after which the backslash before the : is really redundant, but doesn't hurt) allows the test to function properly under both 5.8.8 and 5.9.5.

--- lib/Authen/Htpasswd.pm.0.16 2007-07-15 18:10:58.000000000 -0400 +++ lib/Authen/Htpasswd.pm 2007-07-21 23:41:09.000000000 -0400 @@ -188,7 +188,7 @@ my ($old,$new) = $self->_start_rewrite; my $seen = 0; while (defined(my $line = <$old>)) { - if ($line =~ /^\Q$username\:/) { + if ($line =~ /^\Q$username\E\:/) { chomp $line; my (undef,undef,@extra_info) = split /:/, $line; $user->{extra_info} ||= [ @extra_info ] if scalar @extra_info; @@ -219,7 +219,7 @@ my ($old,$new) = $self->_start_rewrite; while (defined(my $line = <$old>)) { - if ($line =~ /^\Q$username\:/) { + if ($line =~ /^\Q$username\E\:/) { $self->_abort_rewrite; croak "user $username already exists in " . $self->file . "!"; } @@ -244,7 +244,7 @@ my ($old,$new) = $self->_start_rewrite; while (defined(my $line = <$old>)) { - next if $line =~ /^\Q$username\:/; + next if $line =~ /^\Q$username\E\:/; $self->_print( $new, $line ); } $self->_finish_rewrite($old,$new);