Bug #26905 for CPAN-Mini: clean_unmirrored does not remove old files

Wed May 02 15:30:40 2007 mgrimes [...] cpan.org - Ticket created

Subject:

clean_unmirrored does not remove old files

First, thanks for a great module/utility. I find this incredibly useful while commuting, on planes, etc! I noticed that my local repos was growing considerably. When looking into it, the clean_unmirrored routine is not deleting any of the old / unmirrored files. File::Find::find is chdir'ing into the directory (in the wanted sub). Then, when the "-f $file" check is then done, it is looking for a path relative to the local mirror, so it always fails. The attached patch to 0.552 fixed it on my system. Regards, Mark CPAN-Mini-0.552 perl v5.8.7 CYGWIN_NT-5.1 IBM-MGT40 1.5.24(0.156/4/2) 2007-01-31 10:57 i686 Cygwin (although I'm pretty sure this would effect all OS)

Subject:

patch-0.552-clean_unmirrored

Download patch-0.552-clean_unmirrored
application/octet-stream 766b

Message body not shown because it is not plain text.

Mon May 07 18:00:14 2007 rjbs [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #26905] clean_unmirrored does not remove old files
Date:	Mon, 7 May 2007 17:59:12 -0400
To:	via RT <bug-CPAN-Mini [...] rt.cpan.org>
From:	Ricardo SIGNES <rjbs [...] cpan.org>

* via RT <bug-CPAN-Mini@rt.cpan.org> [2007-05-02T15:30:42] Show quoted text

> First, thanks for a great module/utility. I find this incredibly useful > while commuting, on planes, etc!

One does aim to give satisfaction! Show quoted text

> I noticed that my local repos was growing considerably. When looking > into it, the clean_unmirrored routine is not deleting any of the old / > unmirrored files. File::Find::find is chdir'ing into the directory (in > the wanted sub). Then, when the "-f $file" check is then done, it is > looking for a path relative to the local mirror, so it always fails.

Very odd. I run `minicpan` regularly, and things are getting cleaned up just fine. Would you mind telling me what options you're using (including the values of -r and -l). Sending it to me privately is fine, if you prefer. -- rjbs

Mon May 07 18:00:15 2007 The RT System itself - Status changed from 'new' to 'open'

Mon May 07 18:54:52 2007 mgrimes [...] behrmancap.com - Correspondence added

Subject:	RE: [rt.cpan.org #26905] clean_unmirrored does not remove old files
Date:	Mon, 7 May 2007 15:54:18 -0700
To:	<bug-CPAN-Mini [...] rt.cpan.org>
From:	"Mark Grimes" <mgrimes [...] behrmancap.com>

<URL: http://rt.cpan.org/Ticket/Display.html?id=26905 > Show quoted text

> Very odd. I run `minicpan` regularly, and things are getting > cleaned up just fine. Would you mind telling me what options > you're using (including the values of -r and -l). Sending it > to me privately is fine, if you prefer.

Here is my .minicpanrc => remote: ftp://ftp.ibiblio.org/pub/languages/perl/CPAN/ local: CPAN/ skip_perl: 1 And now that I look at it, I would guess the problem was caused by the relative local directory. -Mark

Mon May 07 20:13:42 2007 rjbs [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #26905] clean_unmirrored does not remove old files
Date:	Mon, 7 May 2007 20:12:12 -0400
To:	Mark Grimes via RT <bug-CPAN-Mini [...] rt.cpan.org>
From:	Ricardo SIGNES <rjbs [...] cpan.org>

* Mark Grimes via RT <bug-CPAN-Mini@rt.cpan.org> [2007-05-07T18:54:53] Show quoted text

> Here is my .minicpanrc => > > remote: ftp://ftp.ibiblio.org/pub/languages/perl/CPAN/ > local: CPAN/ > skip_perl: 1 > > And now that I look at it, I would guess the problem was caused by the > relative local directory.

I'm pretty sure that's it. I'll make it absolutize the path or something soon. -- rjbs

Fri Nov 09 19:29:00 2007 rjbs [...] cpan.org - Correspondence added

fixed in 0.563 -- rjbs

Fri Nov 09 19:29:04 2007 rjbs [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #26905 for CPAN-Mini: clean_unmirrored does not remove old files

Preferred bug tracker