Skip Menu |

This queue is for tickets about the Perl-Tags CPAN distribution.

Report information
The Basics
Id: 26842
Status: resolved
Priority: 0/
Queue: Perl-Tags

People
Owner: osfameron [...] cpan.org
Requestors: itegebo [...] berkeley.edu
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in:
  • 0.2
  • 0.21
  • 0.22
  • 0.23
Fixed in: 0.26



Subject: Included Vim example doesn't clean up tempfiles.
The Vim example included in the perldoc doesn't clean up after itself; the attached patch utilizes the Vim function tempname(). This function will both protect the tagsfile as well as cleanup after it when Vim exits.
Subject: perl-tags-vim.patch
--- perl-tags.vim-orig Mon Apr 30 13:26:21 2007 +++ perl-tags.vim Mon Apr 30 13:28:06 2007 @@ -9,6 +9,8 @@ EOF endfunction + " Let vim do the tempfile cleanup and protection + let s:tagsfile = tempname() function s:do_tags(filename) perl <<EOF my $filename = VIM::Eval('a:filename'); @@ -17,7 +19,7 @@ # we'll now do a global (for this PID) tags file which will get updated as you source dive. - my $tagsfile="/tmp/tags_$$"; + my $tagsfile= VIM::Eval('s:tagsfile'); VIM::SetOption("tags+=$tagsfile"); # of course, it may not even output, for example, if there's nothing new to process
On Mon Apr 30 16:36:06 2007, ITEGEBO wrote: Show quoted text
> The Vim example included in the perldoc doesn't clean up after itself; > the attached patch utilizes the Vim function tempname(). This function > will both protect the tagsfile as well as cleanup after it when Vim exits.
Thanks for the patch! Sounds ideal, I've added to my TODO, let me know if you'd like commit access to my repository.
Subject: Re: [rt.cpan.org #26842] Included Vim example doesn't clean up tempfiles.
Date: Tue, 15 May 2007 11:09:33 -0700
To: bug-Perl-Tags [...] rt.cpan.org
From: "Ian Tegebo" <ian.tegebo [...] gmail.com>
On 5/14/07, via RT <bug-Perl-Tags@rt.cpan.org> wrote: Show quoted text
> > <URL: http://rt.cpan.org/Ticket/Display.html?id=26842 > > > On Mon Apr 30 16:36:06 2007, ITEGEBO wrote:
> > The Vim example included in the perldoc doesn't clean up after itself; > > the attached patch utilizes the Vim function tempname(). This function > > will both protect the tagsfile as well as cleanup after it when Vim exits.
> > Thanks for the patch! Sounds ideal, I've added to my TODO, let me know > if you'd like commit access to my repository.
Sure. I'd apply and test the patch. -- Ian Tegebo
On Tue May 15 14:09:59 2007, ian.tegebo@gmail.com wrote: Show quoted text
> On 5/14/07, via RT <bug-Perl-Tags@rt.cpan.org> wrote:
> > > > <URL: http://rt.cpan.org/Ticket/Display.html?id=26842 > > > > > On Mon Apr 30 16:36:06 2007, ITEGEBO wrote:
> > > The Vim example included in the perldoc doesn't clean up after > > > itself; > > > the attached patch utilizes the Vim function tempname(). This > > > function > > > will both protect the tagsfile as well as cleanup after it when Vim > > > exits.
> > > > Thanks for the patch! Sounds ideal, I've added to my TODO, let me > > know > > if you'd like commit access to my repository.
> Sure. I'd apply and test the patch.
This was fixed in 0.26, thanks Ian!