Bug #26664 for CPAN: test failure on Solaris 8 perl-5.8.8

Thanks much, I found the culprit, the patch program on your sun has a different API than we're used to on Linux. From the output you sent me the following stands out: # Going to apply 1 patch: # /home/hwadm/.cpan/build/CPAN-1.9101-SW7TPG/t/CPAN/TestPatch.txt # /usr/bin/patch -N --fuzz=3 -p1 # patch: Invalid options. # patch: Usage: patch [-blNR] [-c|-e|-n] [-d dir] [-D define] [-i patchfile]\ # [-o outfile] [-p num] [-r rejectfile] [file] # Could not apply patch '/home/hwadm/.cpan/build/CPAN-1.9101-SW7TPG/t/CPAN/TestPatch.txt'; cannot continue # Failed during this command: # ANDK/CPAN-Test-Dummy-Perl5-Build-Fails-1.03.tar.gz: unwrapped NO -- Could not apply patch '/home/hwadm/.cpan/build/CPAN-1.9101-SW7TPG/t/CPAN/TestPatch.txt' The question is: would it work without "--fuzz=3" ? If you could try to change line ~6094 of CPAN.pm from my $stdpatchargs = "-N --fuzz=3"; to my $stdpatchargs = "-N"; would that solve the problem?

Hi Andreas, thank you for looking into this - and my apologies, I could have found the issue myself :-/ However, your suggestion does not (yet) fully solve the problem: removing the --fuzz=3 allows Solaris' /usr/bin/patch to start, but it bails out when trying to apply the patch on the read-only file t/00_load.t: # Checksum for /home/hwadm/.cpan/build/CPAN-1.9101-ncLqcY/t/CPAN/authors/id/A/AN/ANDK/C PAN-Test-Dummy-Perl5-Build-Fails-1.03.tar.gz ok # x CPAN-Test-Dummy-Perl5-Build-Fails-1.03, 0 bytes, 0 tape blocks # x CPAN-Test-Dummy-Perl5-Build-Fails-1.03/t, 0 bytes, 0 tape blocks # x CPAN-Test-Dummy-Perl5-Build-Fails-1.03/t/00_load.t, 423 bytes, 1 tape blocks # x CPAN-Test-Dummy-Perl5-Build-Fails-1.03/MANIFEST, 95 bytes, 1 tape blocks # x CPAN-Test-Dummy-Perl5-Build-Fails-1.03/META.yml, 430 bytes, 1 tape blocks # x CPAN-Test-Dummy-Perl5-Build-Fails-1.03/Changes, 213 bytes, 1 tape blocks # x CPAN-Test-Dummy-Perl5-Build-Fails-1.03/lib, 0 bytes, 0 tape blocks # x CPAN-Test-Dummy-Perl5-Build-Fails-1.03/lib/CPAN, 0 bytes, 0 tape blocks # x CPAN-Test-Dummy-Perl5-Build-Fails-1.03/lib/CPAN/Test, 0 bytes, 0 tape blocks # x CPAN-Test-Dummy-Perl5-Build-Fails-1.03/lib/CPAN/Test/Dummy, 0 bytes, 0 tape blocks # x CPAN-Test-Dummy-Perl5-Build-Fails-1.03/lib/CPAN/Test/Dummy/Perl5, 0 bytes, 0 tape blocks # x CPAN-Test-Dummy-Perl5-Build-Fails-1.03/lib/CPAN/Test/Dummy/Perl5/Build, 0 bytes, 0 tape blocks # x CPAN-Test-Dummy-Perl5-Build-Fails-1.03/lib/CPAN/Test/Dummy/Perl5/Build/F ails.pm, 692 bytes, 2 tape blocks # x CPAN-Test-Dummy-Perl5-Build-Fails-1.03/README, 260 bytes, 1 tape blocks # x CPAN-Test-Dummy-Perl5-Build-Fails-1.03/Build.PL, 455 bytes, 1 tape blocks # Going to apply 1 patch: # /home/hwadm/.cpan/build/CPAN-1.9101-ncLqcY/t/CPAN/TestPatch.txt # /usr/bin/patch -N -p1 # Looks like a unified context diff. # patch: 't/00_load.t': Permission denied # Could not apply patch '/home/hwadm/.cpan/build/CPAN-1.9101-ncLqcY/t/CPAN/TestPatch.txt'; cannot continue I tried to build a containder for the test distro with "u+w" permissions, but then the checksum is wrong and test stops after 175 tests. I could easily switch to a GNU patch program, which AFAIK does not care about file permissions, but I think that during the test my own CPAN preferences are disabled, right? I think it should work ok when the test distro contains the files with user write permissions - can you prepare that, or tell me where to adapt the checksum? Cheers, Marek Show quoted text

1.9102 is out and hopefully does the right thing: it probes for the output of 'patch --version'. If it does not work for you, please reopen ticket. Thanks,

1.9102 does the right thing in detecting whether we have GNU patch or some other. However, it does not solve the problem that the Solaris 8 patch utility refuses to patch a file with 444 (r--r--r--) permissions: # Going to apply 1 patch: # /home/hwadm/.cpan/build/CPAN-1.9102-3BJnXy/t/CPAN/TestPatch.txt # /usr/bin/patch -N -p1 # Looks like a unified context diff. # patch: 't/00_load.t': Permission denied # Could not apply patch '/home/hwadm/.cpan/build/CPAN-1.9102-3BJnXy/t/CPAN/TestPatch.txt'; cannot continue When I prepend to $PATH a directory containing a "patch" script that calls GNU patch, then everything works fine. I am wondering whether CPAN could apply a recursive chmod -R u+w on the build directory before applying the patch - then also my initial problem would be solved, and users might also appreciate being able to edit the files without having to chmod before. Thank you very much for your support! Cheers, Marek