| Subject: | Handlers in Brick::Results->flatten_by_field |
Brian, when writing bricks up to this point, we've been omitting the
handler entry in the croak hash, in part because it was unclear what it
was for and everything seemed to be working properly... Until I tried
getting more than one error out for a given field. Since there are no
handlers, this line of code:
next if $Seen{$field}{$hash->{handler}}++;
Prevents more than one error from showing up for a given field, because
we're incrementing a hash entry with the key of empty string (or undef
perhaps?). I've updated this line as follows to keep things going for us:
next if $hash->{handler} and $Seen{$field}{$hash->{handler}}++;
I guess I'm wondering if you think we need to add handlers for
everything or if you think this would be an acceptable update to your
code? My understanding is that this is to prevent the same error from
showing up more than once right? I would just assume change the code as
I did and leave it up to the developer to ensure that they pass handlers
if they want to ensure a lack of duplicity in error messages.
Let me know what you think.