If all properties are deleted in a record, or there are no properties in
the record, the PROPS-END footer will be emitted regardless. The
following patch fixes this up (and a few documentation tweaks that I
added as I went along trying to figure things out).
Nice module!
thanks,
David
| Subject: | SD.patch |
--- SVN-Dump-0.03-edit/lib/SVN/Dump/Property.pm Sun Apr 15 20:49:58 2007
+++ SVN-Dump-0.03/lib/SVN/Dump/Property.pm Tue Nov 21 01:15:21 2006
@@ -46,7 +46,7 @@
for @{ $self->{keys} };
# end marker
- $string .= "PROPS-END$NL" if @{ $self->{keys} };
+ $string .= "PROPS-END$NL";
return $string;
}
--- SVN-Dump-0.03-edit/lib/SVN/Dump/Record.pm Sun Apr 15 21:00:30 2007
+++ SVN-Dump-0.03/lib/SVN/Dump/Record.pm Tue Nov 21 01:15:21 2006
@@ -196,8 +196,7 @@
=item delete_property( @k )
-Delete the properties named in C<@p>. Properties
-that do not exist in the record will be silently ignored.
+Delete the
=item set_text( $t )
@@ -321,20 +320,19 @@
=item as_string()
-Return a string representation of the record that will be
-understood by other Subversion tools, such as C<svnadmin>.
+Return a string representation of the record.
-B<Warning:> dumping a record currently returns the information that
-was read from the original dump. This means that if you modified the
-property or text block of a record, the headers will be inconsistent.
+B<Warning:> dumping a record currenly gives back the information that
+was read from the original dump. Which means that if you modified the
+property or text block of a record, the headers will be inconstent.
=back
=head1 ENCAPSULATION
When using C<SVN::Dump> to manipulate a SVN dump, one should not
-access the C<SVN::Dump::Headers>, C<SVN::Dump::Property> and
-C<SVN::Dump::Text> components of a C<SVN::Dump::Record> object directly, but use
+directly access the C<SVN::Dump::Headers>, C<SVN::Dump::Property> and
+C<SVN::Dump::Text> components of a C<SVN::Dump::Record> object, but use
the appropriate C<set_...()> and C<get_...()> methods of the record object.
These methods compute the appropriate modifications of the header values,