| Subject: | Snark gets low CPANTS score |
Acme::Snark has shockingly low quality as measured at
http://cpants.perl.org/dist/Acme-Snark.
Such an important core module deserves better! See attached diffs.
| Subject: | snark.diff |
diff -urN Acme-Snark-0.03.orig/Changes Acme-Snark-0.03/Changes
--- Acme-Snark-0.03.orig/Changes 2007-04-15 16:23:09.000000000 +0100
+++ Acme-Snark-0.03/Changes 2007-04-15 16:34:05.000000000 +0100
@@ -3,3 +3,5 @@
0.01 Fri Dec 21 04:15:16 2001
- original version; created by h2xs 1.19
+0.04 Sun Apr 15 16:33:00 2007
+ - Improve CPANTS score.
diff -urN Acme-Snark-0.03.orig/examples/example.pl Acme-Snark-0.03/examples/example.pl
--- Acme-Snark-0.03.orig/examples/example.pl 1970-01-01 01:00:00.000000000 +0100
+++ Acme-Snark-0.03/examples/example.pl 2007-04-15 16:32:53.000000000 +0100
@@ -0,0 +1,10 @@
+#!/usr/bin/perl
+
+use Acme::Snark;
+tie $foo, Acme::Snark;
+
+$foo = 0;
+$foo = 0;
+$foo = 0;
+
+print "True\n" if $foo;
diff -urN Acme-Snark-0.03.orig/Makefile.PL Acme-Snark-0.03/Makefile.PL
--- Acme-Snark-0.03.orig/Makefile.PL 2007-04-15 16:23:09.000000000 +0100
+++ Acme-Snark-0.03/Makefile.PL 2007-04-15 16:38:43.000000000 +0100
@@ -4,4 +4,8 @@
WriteMakefile(
'NAME' => 'Acme::Snark',
'VERSION_FROM' => 'Snark.pm', # finds $VERSION
+ ($] >= 5.005 ?
+ (ABSTRACT => 'What I tell you three times is true',
+ AUTHOR => 'Alex Gough') : ()),
+ 'LICENSE' => 'perl',
);
diff -urN Acme-Snark-0.03.orig/MANIFEST Acme-Snark-0.03/MANIFEST
--- Acme-Snark-0.03.orig/MANIFEST 2007-04-15 16:23:09.000000000 +0100
+++ Acme-Snark-0.03/MANIFEST 2007-04-15 16:34:33.000000000 +0100
@@ -2,4 +2,8 @@
Makefile.PL
MANIFEST
Snark.pm
-test.pl
+t/01_test.t
+t/02_test_pod.t
+t/03_test_pod_coverage.t
+examples/example.pl
+README
diff -urN Acme-Snark-0.03.orig/README Acme-Snark-0.03/README
--- Acme-Snark-0.03.orig/README 1970-01-01 01:00:00.000000000 +0100
+++ Acme-Snark-0.03/README 2007-04-15 16:34:28.000000000 +0100
@@ -0,0 +1,4 @@
+Acme::Snark
+-----------
+
+This is the Acme::Snark module.
diff -urN Acme-Snark-0.03.orig/Snark.pm Acme-Snark-0.03/Snark.pm
--- Acme-Snark-0.03.orig/Snark.pm 2007-04-15 16:23:09.000000000 +0100
+++ Acme-Snark-0.03/Snark.pm 2007-04-15 16:31:58.000000000 +0100
@@ -2,7 +2,7 @@
use strict;
use vars qw($VERSION);
-$VERSION = '0.03';
+$VERSION = '0.04';
my %stash;
@@ -111,8 +111,11 @@
=head1 COPYRIGHT
-This module is Copyright (c) Alex Gough, 2001. This is free software,
-you may use and redistribute this code under the same terms as perl
-itself.
+This module is Copyright (c) Alex Gough, 2001.
+
+=head1 LICENSE
+
+This is free software, you may use and redistribute this code under the
+same terms as perl itself.
=cut
diff -urN Acme-Snark-0.03.orig/t/01_test.t Acme-Snark-0.03/t/01_test.t
--- Acme-Snark-0.03.orig/t/01_test.t 1970-01-01 01:00:00.000000000 +0100
+++ Acme-Snark-0.03/t/01_test.t 2007-04-15 16:28:59.000000000 +0100
@@ -0,0 +1,80 @@
+# Before `make install' is performed this script should be runnable with
+# `make test'. After `make install' it should work as `perl test.pl'
+
+######################### We start with some black magic to print on failure.
+
+# Change 1..1 below to 1..last_test_to_print .
+# (It may become useful if the test is moved to ./t subdirectory.)
+
+BEGIN { $| = 1; print "1..8\n"; }
+END {print "not ok 1\n" unless $loaded;}
+use Acme::Snark;
+$loaded = 1;
+print "ok 1\n";
+
+######################### End of black magic.
+
+my $foo;
+tie $foo, 'Acme::Snark';
+
+$foo = 0;$foo = 0;
+
+if ($foo) {
+ print "not ok 2\n";
+}
+else {
+ print "ok 2\n";
+}
+
+$foo = 0;
+if ($foo) {
+ print "ok 3\n";
+}
+else {
+ print "not 3\n";
+}
+my $bar = $foo + 0;
+if ($bar) {
+ print "not ok 4\n";
+}
+else {
+ print "ok 4\n";
+}
+
+my $two;
+tie $two, 'Acme::Snark';
+$two = undef;
+$two = undef;
+if ($two) {
+ print "not ok 5\n";
+}
+else {
+ print "ok 5\n";
+}
+$two = undef;
+if ($two) {
+ print "ok 6\n";
+}
+else {
+ print "not ok 6\n";
+}
+
+my $three;
+tie $three, 'Acme::Snark';
+$three = "";
+$three = "";
+if ($three) {
+ print "not ok 7\n";
+}
+else {
+ print "ok 7\n";
+}
+$three = "";
+if ($three) {
+ print "ok 8\n";
+}
+else {
+ print "not ok 8\n";
+}
+
+# But now everything is true, even the false things...
diff -urN Acme-Snark-0.03.orig/t/02_test_pod.t Acme-Snark-0.03/t/02_test_pod.t
--- Acme-Snark-0.03.orig/t/02_test_pod.t 1970-01-01 01:00:00.000000000 +0100
+++ Acme-Snark-0.03/t/02_test_pod.t 2007-04-15 16:26:21.000000000 +0100
@@ -0,0 +1,4 @@
+use Test::More;
+eval "use Test::Pod 1.00";
+plan skip_all => "Test::Pod 1.00 required for testing POD" if $@;
+all_pod_files_ok();
diff -urN Acme-Snark-0.03.orig/t/03_test_pod_coverage.t Acme-Snark-0.03/t/03_test_pod_coverage.t
--- Acme-Snark-0.03.orig/t/03_test_pod_coverage.t 1970-01-01 01:00:00.000000000 +0100
+++ Acme-Snark-0.03/t/03_test_pod_coverage.t 2007-04-15 16:31:06.000000000 +0100
@@ -0,0 +1,4 @@
+use Test::More;
+eval "use Test::Pod::Coverage 1.00";
+plan skip_all => "Test::Pod::Coverage 1.00 required for testing POD coverage" if $@;
+all_pod_coverage_ok();
diff -urN Acme-Snark-0.03.orig/test.pl Acme-Snark-0.03/test.pl
--- Acme-Snark-0.03.orig/test.pl 2007-04-15 16:23:09.000000000 +0100
+++ Acme-Snark-0.03/test.pl 1970-01-01 01:00:00.000000000 +0100
@@ -1,80 +0,0 @@
-# Before `make install' is performed this script should be runnable with
-# `make test'. After `make install' it should work as `perl test.pl'
-
-######################### We start with some black magic to print on failure.
-
-# Change 1..1 below to 1..last_test_to_print .
-# (It may become useful if the test is moved to ./t subdirectory.)
-
-BEGIN { $| = 1; print "1..1\n"; }
-END {print "not ok 1\n" unless $loaded;}
-use Acme::Snark;
-$loaded = 1;
-print "ok 1\n";
-
-######################### End of black magic.
-
-my $foo;
-tie $foo, 'Acme::Snark';
-
-$foo = 0;$foo = 0;
-
-if ($foo) {
- print "not ok 2\n";
-}
-else {
- print "ok 2\n";
-}
-
-$foo = 0;
-if ($foo) {
- print "ok 3\n";
-}
-else {
- print "not 3\n";
-}
-my $bar = $foo + 0;
-if ($bar) {
- print "not ok 4\n";
-}
-else {
- print "ok 4\n";
-}
-
-my $two;
-tie $two, 'Acme::Snark';
-$two = undef;
-$two = undef;
-if ($two) {
- print "not ok 5\n";
-}
-else {
- print "ok 5\n";
-}
-$two = undef;
-if ($two) {
- print "ok 6\n";
-}
-else {
- print "not ok 6\n";
-}
-
-my $three;
-tie $three, 'Acme::Snark';
-$three = "";
-$three = "";
-if ($three) {
- print "not ok 7\n";
-}
-else {
- print "ok 7\n";
-}
-$three = "";
-if ($three) {
- print "ok 8\n";
-}
-else {
- print "not ok 8\n";
-}
-
-# But now everything is true, even the false things...