Skip Menu |

This queue is for tickets about the IMDB-Film CPAN distribution.

Report information
The Basics
Id: 26349
Status: resolved
Priority: 0/
Queue: IMDB-Film

People
Owner: Nobody in particular
Requestors: bas [...] debian.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.26
Fixed in: (no value)



Subject: tests failing
Some tests (from make test) are failing with the current imdb site (I guess they adjusted the layout again...): [bas@cordelia]My-Packages/libimdb-perl/libimdb-film-perl-0.26> make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/01_base.t t/m1_get_movie_by_code.t t/m2_get_movie_by_title.t t/m3_get_movie_by_wrong_title.t t/m4_get_movie_by_title_single_match.t t/m5_get_movie_by_title_without_rate.t t/m6_get_movie_by_title_with_cr_casts.t t/m7_get_movie_by_info_offline.t t/p1_get_person_by_name.t t/p2_get_person_by_code.t t/p3_get_person_by_wrong_name.t t/p4_get_person_info_offline.t t/01_base................................ok t/m1_get_movie_by_code...................ok 1/18 # Failed test 'Movie Directors' # in t/m1_get_movie_by_code.t at line 69. # Structures begin differing at: # $got->[0] = Does not exist # $expected->[0] = HASH(0x85c9b10) # Failed test 'Movie Writers' # in t/m1_get_movie_by_code.t at line 70. # Structures begin differing at: # $got->[0] = Does not exist # $expected->[0] = HASH(0x85c9b64) # Looks like you failed 2 tests of 18. t/m1_get_movie_by_code...................dubious Test returned status 2 (wstat 512, 0x200) DIED. FAILED tests 17-18 Failed 2/18 tests, 88.89% okay t/m2_get_movie_by_title..................ok t/m3_get_movie_by_wrong_title............ok t/m4_get_movie_by_title_single_match.....ok t/m5_get_movie_by_title_without_rate.....ok t/m6_get_movie_by_title_with_cr_casts....ok t/m7_get_movie_by_info_offline...........ok t/p1_get_person_by_name..................ok t/p2_get_person_by_code..................ok t/p3_get_person_by_wrong_name............ok t/p4_get_person_info_offline.............ok Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- t/m1_get_movie_by_code.t 2 512 18 2 11.11% 17-18 Failed 1/12 test scripts, 91.67% okay. 2/68 subtests failed, 97.06% okay. make: *** [test_dynamic] Error 255
Turns out the layout for the Director and Writer entry on the page had changed. I'm attaching a patch that fixes the problem. Kind regards, Bas.
Download patch
application/octet-stream 1.5k

Message body not shown because it is not plain text.

Thanks a lot, Bas, for your bugreport and patch. The bug is fixed and the new version is uploaded to the CPAN. -- Best Regards, Michael Stepanov, Senior Software Developer