| Subject: | include_columns has no effect |
Calling include_columns() has no effect on the columns I see in the
spreadsheet this module generates.
It seems that the last line of _columns_wanted() contains an error as it
uses all columns in the table instead of those specified. The attached
patch fixes this.
Thanks for the work you have put into this useful module,
Tom Hukins
| Subject: | columns_wanted.diff |
--- /home/tom/p59/lib/perl5/site_perl/5.9.5/Spreadsheet/WriteExcel/FromDB.pm.old 2005-09-04 01:11:09.000000000 +0100
+++ /home/tom/p59/lib/perl5/site_perl/5.9.5/Spreadsheet/WriteExcel/FromDB.pm 2007-04-13 14:18:27.000000000 +0100
@@ -165,7 +165,7 @@
my @include = @{$self->{_include_columns}};
@include = $self->_columns_in_table unless @include;
my %ignore_columns = map { $_ => 1 } @{$self->{_ignore_columns}};
- return grep !$ignore_columns{$_}, $self->_columns_in_table;
+ return grep !$ignore_columns{$_}, @include;
}
sub _columns_in_table {