Skip Menu |

This queue is for tickets about the Crypt-SSLeay CPAN distribution.

Report information
The Basics
Id: 26319
Status: resolved
Priority: 0/
Queue: Crypt-SSLeay

People
Owner: dland [...] cpan.org
Requestors: ken.mclaren [...] bt.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Bug in Net::SSL
Date: Fri, 13 Apr 2007 12:18:32 +0100
To: <bug-Crypt-SSLeay [...] rt.cpan.org>
From: <ken.mclaren [...] bt.com>
Greetings, Many thanks for all the great work you guys do. It is most appreciated. Anyway to cut to the chase, I have found a wee bug in the Net::SSL package. This might not interest you because the Net::SSL package is being used directly i.e. not via LWP. Anyway the bug occurs when you are using a proxy and you have a non object subroutine on the stack which has a reference as its first parameter. The bug is in the get_lwp_object subroutine. I have included my current fix, although I don't think this is general enough. sub get_lwp_object { my $self = shift; my $lwp_object; my $i = 0; while(1) { package DB; my @stack = caller($i++); last unless @stack; my @stack_args = @DB::args; my $stack_object = $stack_args[0] || next; ref($stack_object) || next; # # This line of code has been added to stop the isa failing # ref($stack_object) ne 'HASH' || next; if($stack_object->isa('LWP::UserAgent')) { $lwp_object = $stack_object; last; } } $lwp_object; } In my case there is a non object subroutine call with a hash reference as its first parameter on the stack. The current code assumes that any reference as the first parameter points to a package, which is wrong in this case. This results in the isa failing which results in the connection failing. I am using perl 5.8.8 on XP and Fedora Core 5. Cheers, Ken.
From: dland [...] cpan.org
On Fri Apr 13 07:19:00 2007, ken.mclaren@bt.com wrote: Show quoted text
> Greetings, > > Many thanks for all the great work you guys do. It is most appreciated. > > Anyway to cut to the chase, I have found a wee bug in the Net::SSL > package. > > This might not interest you because the Net::SSL package is being used > directly i.e. not via LWP. > > Anyway the bug occurs when you are using a proxy and you have a non > object subroutine on the stack which has a reference as its first > parameter.
This sounds awfully similar to a bug I cleared up in the 0.53 series. Which version are you using? If you're using 0.54 then there's something wrong (or else there's another code path I didn't notice). If you aren't, then take 0.54 for a spin, as there's been a change in that regard. Let me know either way. Thanks, David Landgren
On Fri Apr 13 10:41:24 2007, DLAND wrote: Show quoted text
> On Fri Apr 13 07:19:00 2007, ken.mclaren@bt.com wrote:
> > Greetings, > > > > Many thanks for all the great work you guys do. It is most appreciated. > > > > Anyway to cut to the chase, I have found a wee bug in the Net::SSL > > package. > > > > This might not interest you because the Net::SSL package is being used > > directly i.e. not via LWP. > > > > Anyway the bug occurs when you are using a proxy and you have a non > > object subroutine on the stack which has a reference as its first > > parameter.
> > This sounds awfully similar to a bug I cleared up in the 0.53 series. > Which version are you using? If you're using 0.54 then there's something > wrong (or else there's another code path I didn't notice). > > If you aren't, then take 0.54 for a spin, as there's been a change in > that regard. > > Let me know either way.
Ken, can you confirm if this bug still exists with 0.54? Thanks, David
Subject: RE: [rt.cpan.org #26319] Bug in Net::SSL
Date: Tue, 8 May 2007 09:16:41 +0100
To: <bug-Crypt-SSLeay [...] rt.cpan.org>
From: <ken.mclaren [...] bt.com>
David, Sorry, I have been up to my eyeballs getting a release out. I will try out 0.54 this week and let you know. Ken. Show quoted text
-----Original Message----- From: David Landgren via RT [mailto:bug-Crypt-SSLeay@rt.cpan.org] Sent: 05 May 2007 09:45 To: Mclaren,KC,Ken,XDT66 R Subject: [rt.cpan.org #26319] Bug in Net::SSL <URL: http://rt.cpan.org/Ticket/Display.html?id=26319 > On Fri Apr 13 10:41:24 2007, DLAND wrote:
> On Fri Apr 13 07:19:00 2007, ken.mclaren@bt.com wrote:
> > Greetings, > > > > Many thanks for all the great work you guys do. It is most > > appreciated. > > > > Anyway to cut to the chase, I have found a wee bug in the Net::SSL > > package. > > > > This might not interest you because the Net::SSL package is being > > used directly i.e. not via LWP. > > > > Anyway the bug occurs when you are using a proxy and you have a non > > object subroutine on the stack which has a reference as its first > > parameter.
> > This sounds awfully similar to a bug I cleared up in the 0.53 series. > Which version are you using? If you're using 0.54 then there's > something wrong (or else there's another code path I didn't notice). > > If you aren't, then take 0.54 for a spin, as there's been a change in > that regard. > > Let me know either way.
Ken, can you confirm if this bug still exists with 0.54? Thanks, David
Not having heard back one way or another, I am marking this bug as resolved. Thanks for the report, David Landgren