On Thursday, May 22, 2003, at 06:30 PM, via RT wrote:
Show quoted text>
> This message about Encode was sent to you by MAREKR <MAREKR@cpan.org>
> via rt.cpan.org
>
> Full context and any attached attachments can be found at:
> <URL:
https://rt.cpan.org/Ticket/Display.html?id=2629 >
>
> On my perl-5.8.0 (ithreads, shared libperl) on Solaris/Sparc 2.7
> I see the following warning in the test (Encode-1.95!!!):
>
> t/enc_utf8.......Argument "" isn't numeric in numeric eq (==) at
> /home/hwadm/.cpan/build/Encode-1.95/blib/lib/encoding.pm line 30.
>
> This is because $Config{perl_patchevel} yields '' rather than 0.
> This should be changed, e.g. like this:
> $Config{perl_patchlevel} ? ... : ...
> as '' and 0 are equally "false".
>
> Regards,
>
> Marek
Thanks for the report. The patch below should fix it.
Dan the Encode Maintainer
===================================================================
RCS file: encoding.pm,v
retrieving revision 1.44
diff -u -r1.44 encoding.pm
--- encoding.pm 2003/03/09 20:07:37 1.44
+++ encoding.pm 2003/05/22 09:45:16
@@ -1,4 +1,4 @@
-# $Id: encoding.pm,v 1.44 2003/03/09 20:07:37 dankogai Exp dankogai $
+# $Id: encoding.pm,v 1.44 2003/03/09 20:07:37 dankogai Exp $
package encoding;
our $VERSION = do { my @r = (q$Revision: 1.44 $ =~ /\d+/g); sprintf
"%d."."%02d" x $#r, @r };
@@ -27,7 +27,7 @@
UTF-32 UTF-32BE UTF-32LE);
$utfs{$name} or return 0; # UTFs or no
require Config; Config->import(); our %Config;
- return $Config{perl_patchlevel} == 0 # maintperl then no
+ return $Config{perl_patchlevel} ? 0 : 1 # maintperl then no
}
sub import {
