Hello,
Show quoted text> It is not a bad idea at all, but have you addressed the lacking
> holidays
> with the author of Date::Holidays::ES to begin with?
No, I didn't contact him. Because the module is ok, but I was looking
for a generic module, not associated with any country. Why? because
I'm modifying the library Business::Hours (use in RT-IR) to take care
about holidays. The number of days off will be defined in a variable
of RT-IR, in this way the administrators of RT-IR don't need to
install their specific country library (it's possible it doesn't
exist, or even it doesn't meet their requirements), so they will just
need to define the set of days off, and that's it.
Show quoted text>
> Most of the Date::Holidays::* distributions are data focused
> modules. I
> will surely investigate if it would be feasible to implement usage of
> external data.
>
> Please get back to me with you ideas and any possible feedback on your
> talk with Florian Merges.
>
> I do not know the reason to as why Florian would leave out some
> holidays. Either it is a bug on his side, or Spain has a more complex
> holiday structure.
>
> Some of the other distributions, which work with complex holiday
> structures, either by region or similar, simply have more complex APIs
> than Date::Holidays::Abstract in general specify, so you will have to
> have a look at Date::Holidays::DE or Date::Holidays::AU.
I don't think it's a bug, but as AU or DE, each province of Spain has
its particular holidays, even each city has particular holidays, i.e
Madrid (the city) has the following holidays: city days off +
province days off + national days off, so that was the reason to
implement Date::Holidays::Generic (sorry about the name), this module
implements the functions of Date::Holidays::Super, plus a new method
called load_holidays, whose goal is to load a set of specific holidays.
Attached you can find the Date::Holidays::Generic and a example of
use. The problem is that your class doesn't specify the load_holidays
method, and it would be nice if it could be done.
Cheers,
Carlos
