Bug #26235 for TermReadKey: [PATCH] fix return value of SetTerminalSize()

Tue Apr 10 13:46:47 2007 at [...] altlinux.ru - Ticket created

Subject:	[PATCH] fix return value of SetTerminalSize()
Date:	Tue, 10 Apr 2007 21:46:43 +0400
To:	bug-termreadkey [...] rt.cpan.org
From:	Alexey Tourbin <at [...] altlinux.ru>

Spotted by gcc. ReadKey.c: In function 'XS_Term__ReadKey_SetTerminalSize': ReadKey.c:2040: warning: unused variable 'targ' --- ReadKey.xs | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ReadKey.xs b/ReadKey.xs index 31f1b4a..8d79b95 100644 --- a/ReadKey.xs +++ b/ReadKey.xs @@ -1823,6 +1823,8 @@ SetTerminalSize(width,height,xpix,ypix,file=STDIN) { RETVAL=SetTerminalSize(file,width,height,xpix,ypix); } + OUTPUT: + RETVAL void GetSpeed(file=STDIN) -- 1.5.1.GIT

Tue Apr 10 15:07:15 2007 jns [...] gellyfish.com - Correspondence added

Subject:	Re: [rt.cpan.org #26235] [PATCH] fix return value of SetTerminalSize()
Date:	Tue, 10 Apr 2007 20:06:43 +0100
To:	bug-TermReadKey [...] rt.cpan.org, at [...] altlinux.ru
From:	Jonathan Stowe <jns [...] gellyfish.com>

Hi, On Tue, 2007-04-10 at 13:46 -0400, Alexey Tourbin via RT wrote: Show quoted text

> > Spotted by gcc. > ReadKey.c: In function 'XS_Term__ReadKey_SetTerminalSize': > ReadKey.c:2040: warning: unused variable 'targ' > --- > ReadKey.xs | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/ReadKey.xs b/ReadKey.xs > index 31f1b4a..8d79b95 100644 > --- a/ReadKey.xs > +++ b/ReadKey.xs > @@ -1823,6 +1823,8 @@ SetTerminalSize(width,height,xpix,ypix,file=STDIN) > { > RETVAL=SetTerminalSize(file,width,height,xpix,ypix); > } > + OUTPUT: > + RETVAL > > void > GetSpeed(file=STDIN)

Thanks for this, I've quite a few changes to integrate before the next release so it may not see the light of day immediately - I'm tempted to hold on until there is a release candidate for 5.10 to test against. Anyway thanks again. /J\

Tue Apr 10 15:07:17 2007 The RT System itself - Status changed from 'new' to 'open'

Sat Oct 26 18:28:44 2013 jns [...] gellyfish.co.uk - Correspondence added

On Tue Apr 10 13:46:47 2007, at@altlinux.ru wrote: Show quoted text

> Spotted by gcc. > ReadKey.c: In function 'XS_Term__ReadKey_SetTerminalSize': > ReadKey.c:2040: warning: unused variable 'targ' > --- > ReadKey.xs | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/ReadKey.xs b/ReadKey.xs > index 31f1b4a..8d79b95 100644 > --- a/ReadKey.xs > +++ b/ReadKey.xs > @@ -1823,6 +1823,8 @@ SetTerminalSize(width,height,xpix,ypix,file=STDIN) > { > RETVAL=SetTerminalSize(file,width,height,xpix,ypix); > } > + OUTPUT: > + RETVAL > > void > GetSpeed(file=STDIN)

Thanks that went in with https://github.com/jonathanstowe/TermReadKey/commit/09614536a0f3b73b069f09227e055b54d5f542d9

Sat Oct 26 18:29:00 2013 jns [...] gellyfish.co.uk - Status changed from 'open' to 'resolved'