Bug #26209 for SVN-Notify-Config: verbose test result failures

Tue Apr 10 00:10:30 2007 micah [...] riseup.net - Ticket created

Subject:	verbose test result failures
Date:	Mon, 9 Apr 2007 22:12:40 -0600
To:	bug-SVN-Notify-Config [...] rt.cpan.org
From:	Micah Anderson <micah [...] riseup.net>

$ ./Build test -verbose=1 Copying lib/SVN/Notify/Config.pm -> blib/lib/SVN/Notify/Config.pm t/001_basic.....ok t/002_config....ok 1/0 # Failed test 'Failed to produce expected results at rev: 3' # in t/coretests.pm at line 116. t/002_config....ok 4/0 t/002_config....NOK 6# Failed test 'All object properties match at rev: 6' # in t/coretests.pm at line 108. # Structures begin differing at: # $got->[0]{PATH} = Does not exist # $expected->[0]{PATH} = '/usr/local/bin:/usr/bin' t/002_config....NOK 7# Failed test 'Failed to produce expected results at rev: 7' # in t/coretests.pm at line 116. # Looks like you failed 3 tests of 7. t/002_config....dubious Test returned status 3 (wstat 768, 0x300) DIED. FAILED tests 3, 6-7 Failed 3/7 tests, 57.14% okay t/003_config....ok 8/0 # Failed test 'All object properties match at rev: 9' # in t/coretests.pm at line 108. # Structures begin differing at: # $got->[1] = Does not exist # $expected->[1] = SVN::Notify::Dummy=HASH(0x859e45c) t/003_config....NOK 12 # Failed test 'All object properties match at rev: 12' # in t/coretests.pm at line 108. # Structures begin differing at: # $got->[1] = Does not exist # $expected->[1] = SVN::Notify::Dummy=HASH(0x85db108) # Looks like you failed 2 tests of 12. t/003_config....dubious Test returned status 2 (wstat 512, 0x200) DIED. FAILED tests 9, 12 Failed 2/12 tests, 83.33% okay Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- t/002_config.t 3 768 7 3 42.86% 3 6-7 t/003_config.t 2 512 12 2 16.67% 9 12 Failed 2/3 test scripts, 33.33% okay. 5/20 subtests failed, 75.00% okay. Micah

Tue Apr 10 00:14:34 2007 micah [...] riseup.net - Correspondence added

Subject:	[rt.cpan.org #26209]
Date:	Mon, 9 Apr 2007 22:16:25 -0600
To:	bug-SVN-Notify-Config [...] rt.cpan.org
From:	Micah Anderson <micah [...] riseup.net>

Perl environment: Summary of my perl5 (revision 5 version 8 subversion 8) configuration: Platform: osname=linux, osvers=2.6.18.3, archname=i486-linux-gnu-thread-multi uname='linux saens 2.6.18.3 #1 smp sat nov 25 13:39:52 est 2006 i686 gnulinux ' config_args='-Dusethreads -Duselargefiles -Dccflags=-DDEBIAN -Dcccdlflags=-fPIC -Darchname=i486-linux-gnu -Dprefix=/usr -Dprivlib=/usr/share/perl/5.8 -Darchlib=/usr/lib/perl/5.8 -Dvendorprefix=/usr -Dvendorlib=/usr/share/perl5 -Dvendorarch=/usr/lib/perl5 -Dsiteprefix=/usr/local -Dsitelib=/usr/local/share/perl/5.8.8 -Dsitearch=/usr/local/lib/perl/5.8.8 -Dman1dir=/usr/share/man/man1 -Dman3dir=/usr/share/man/man3 -Dsiteman1dir=/usr/local/man/man1 -Dsiteman3dir=/usr/local/man/man3 -Dman1ext=1 -Dman3ext=3perl -Dpager=/usr/bin/sensible-pager -Uafs -Ud_csh -Uusesfio -Uusenm -Duseshrplib -Dlibperl=libperl.so.5.8.8 -Dd_dosuid -des' hint=recommended, useposix=true, d_sigaction=define usethreads=define use5005threads=undef useithreads=define usemultiplicity=define useperlio=define d_sfio=undef uselargefiles=define usesocks=undef use64bitint=undef use64bitall=undef uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -DDEBIAN -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64', optimize='-O2', cppflags='-D_REENTRANT -D_GNU_SOURCE -DTHREADS_HAVE_PIDS -DDEBIAN -fno-strict-aliasing -pipe -I/usr/local/include' ccversion='', gccversion='4.1.2 20061115 (prerelease) (Debian 4.1.1-20)', gccosandvers='' intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12 ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8 alignbytes=4, prototype=define Linker and Libraries: ld='cc', ldflags =' -L/usr/local/lib' libpth=/usr/local/lib /lib /usr/lib libs=-lgdbm -lgdbm_compat -ldb -ldl -lm -lpthread -lc -lcrypt perllibs=-ldl -lm -lpthread -lc -lcrypt libc=/lib/libc-2.3.6.so, so=so, useshrplib=true, libperl=libperl.so.5.8.8 gnulibc_version='2.3.6' Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E' cccdlflags='-fPIC', lddlflags='-shared -L/usr/local/lib' Characteristics of this binary (from libperl): Compile-time options: MULTIPLICITY PERL_IMPLICIT_CONTEXT PERL_MALLOC_WRAP THREADS_HAVE_PIDS USE_ITHREADS USE_LARGE_FILES USE_PERLIO USE_REENTRANT_API Built under linux Compiled at Dec 6 2006 23:05:53 @INC: /etc/perl /usr/local/lib/perl/5.8.8 /usr/local/share/perl/5.8.8 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.8 /usr/share/perl/5.8 /usr/local/lib/site_perl .

Tue Apr 10 00:17:23 2007 micah [...] riseup.net - Correspondence added

Subject:	[rt.cpan.org #26209]
Date:	Mon, 9 Apr 2007 22:20:27 -0600
To:	bug-SVN-Notify-Config [...] rt.cpan.org
From:	Micah Anderson <micah [...] riseup.net>

Here is where SVN::Notify files are installed on my system (standard locations on Debian for perl modules): /. /usr /usr/share /usr/share/man /usr/share/man/man1 /usr/share/man/man1/svnnotify.1p.gz /usr/share/man/man3 /usr/share/man/man3/SVN::Notify.3pm.gz /usr/share/man/man3/SVN::Notify::Alternative.3pm.gz /usr/share/man/man3/SVN::Notify::HTML.3pm.gz /usr/share/man/man3/SVN::Notify::HTML::ColorDiff.3pm.gz /usr/share/perl5 /usr/share/perl5/SVN /usr/share/perl5/SVN/Notify.pm /usr/share/perl5/SVN/Notify /usr/share/perl5/SVN/Notify/Alternative.pm /usr/share/perl5/SVN/Notify/HTML.pm /usr/share/perl5/SVN/Notify/HTML /usr/share/perl5/SVN/Notify/HTML/ColorDiff.pm /usr/share/doc /usr/share/doc/libsvn-notify-perl /usr/share/doc/libsvn-notify-perl/changelog.gz /usr/share/doc/libsvn-notify-perl/README /usr/share/doc/libsvn-notify-perl/copyright /usr/share/doc/libsvn-notify-perl/changelog.Debian.gz /usr/bin /usr/bin/svnnotify Micah

Sun Apr 15 15:12:36 2007 jpeacock [...] cpan.org - Correspondence added

From:

JPEACOCK [...] cpan.org

On Tue Apr 10 00:10:30 2007, micah@riseup.net wrote: Show quoted text

> # Failed test 'Failed to produce expected results at rev: 3' > # in t/coretests.pm at line 116.

That's unhelpful at best. I think the only way this could happen is if you don't have a new enough YAML installed (which I just realized I don't have listed as an explicit dependency). Could you install the latest YAML (0.62) and see if this failure goes away? The other thing you could do is to apply the attached patch and send me the output (you may want to redirect STDERR to a file because it will generate lots of text). Run the t/002_config.t file with --verbose=1... Show quoted text

> # in t/coretests.pm at line 108. > # Structures begin differing at: > # $got->[0]{PATH} = Does not exist > # $expected->[0]{PATH} = '/usr/local/bin:/usr/bin'

Also very weird, since this PATH is set in the test_config file itself (i.e. it doesn't matter what you have your $ENV{PATH} set to). Show quoted text

> # Failed test 'All object properties match at rev: 9' > # in t/coretests.pm at line 108. > # Structures begin differing at: > # $got->[1] = Does not exist > # $expected->[1] = SVN::Notify::Dummy=HASH(0x859e45c)

Also very weird; this relates to two different paths getting updated at this point. I hope the YAML release fixes this too... John

=== t/coretests.pm ================================================================== --- t/coretests.pm (revision 607) +++ t/coretests.pm (local) @@ -1,5 +1,6 @@ #!/usr/bin/perl use Test::More; +use Test::Harness; use YAML qw/LoadFile Load Dump/; use SVN::Notify; use Cwd; @@ -98,6 +99,7 @@ $ENV{'TZ'} = 'EST5EDT'; # fix for RT#22704 open $TESTER, '-|', _build_command($command, %args); while (<$TESTER>) { + print STDERR '#'.$_ if $Test::Harness::Verbose; next if /--- YAML/; $test .= $_; }

Sun Apr 15 15:12:42 2007 The RT System itself - Status changed from 'new' to 'open'

Sun Apr 15 16:23:34 2007 micah [...] riseup.net - Correspondence added

Subject:	Re: [rt.cpan.org #26209] verbose test result failures
Date:	Sun, 15 Apr 2007 14:23:14 -0600
To:	bug-SVN-Notify-Config [...] rt.cpan.org
From:	Micah Anderson <micah [...] riseup.net>

Hi, via RT wrote: Show quoted text

> <URL: http://rt.cpan.org/Ticket/Display.html?id=26209 > > > On Tue Apr 10 00:10:30 2007, micah@riseup.net wrote:

>> # Failed test 'Failed to produce expected results at rev: 3' >> # in t/coretests.pm at line 116.

> > That's unhelpful at best. I think the only way this could happen is if > you don't have a new enough YAML installed (which I just realized I > don't have listed as an explicit dependency). > > Could you install the latest YAML (0.62) and see if this failure goes > away?

Unfortunately, I did have YAML 0.62 installed when I ran these. :( The other thing you could do is to apply the attached patch and Show quoted text

> send me the output (you may want to redirect STDERR to a file because it > will generate lots of text). Run the t/002_config.t file with > --verbose=1...

Here are the results (after the patch was applied): $ perl t/002_config.t --verbose ok 1 - No changes at rev: 1 ok 2 - All object properties match at rev: 2 not ok 3 - Failed to produce expected results at rev: 3 # Failed test 'Failed to produce expected results at rev: 3' # in t/coretests.pm at line 118. ok 4 - No changes at rev: 4 ok 5 - All object properties match at rev: 5 not ok 6 - All object properties match at rev: 6 # Failed test 'All object properties match at rev: 6' # in t/coretests.pm at line 110. # Structures begin differing at: # $got->[0]{PATH} = Does not exist # $expected->[0]{PATH} = '/usr/local/bin:/usr/bin' not ok 7 - Failed to produce expected results at rev: 7 # Failed test 'Failed to produce expected results at rev: 7' # in t/coretests.pm at line 118. 1..7 # Looks like you failed 3 tests of 7. Show quoted text

>> # in t/coretests.pm at line 108. >> # Structures begin differing at: >> # $got->[0]{PATH} = Does not exist >> # $expected->[0]{PATH} = '/usr/local/bin:/usr/bin'

> > Also very weird, since this PATH is set in the test_config file itself > (i.e. it doesn't matter what you have your $ENV{PATH} set to). >

>> # Failed test 'All object properties match at rev: 9' >> # in t/coretests.pm at line 108. >> # Structures begin differing at: >> # $got->[1] = Does not exist >> # $expected->[1] = SVN::Notify::Dummy=HASH(0x859e45c)

> > Also very weird; this relates to two different paths getting updated at > this point. I hope the YAML release fixes this too...

I wish I could say it did, but I already had YAML installed :( Micah

Mon Apr 16 08:24:14 2007 jpeacock [...] rowman.com - Correspondence added

Subject:	Re: [rt.cpan.org #26209] verbose test result failures
Date:	Mon, 16 Apr 2007 08:24:22 -0400
To:	bug-SVN-Notify-Config [...] rt.cpan.org
From:	John Peacock <jpeacock [...] rowman.com>

Micah Anderson via RT wrote: Show quoted text

> $ perl t/002_config.t --verbose

That's running against the already installed files. To test the uninstalled modules, you need to do: $ ./Build test --test_files=t/002_config.t --verbose You should get something like this extract: t/002_config....ok 1 - No changes at rev: 1 #--- YAML #--- !!perl/hash:SVN::Notify::Dummy #PATH: /usr/local/bin:/usr/bin #charset: UTF-8 #date: '2005-12-26 12:38:12 -0500 (Mon, 26 Dec 2005)' #files: # A: # - project1/trunk/dir1/ # - project1/trunk/dir1/file2 # - project1/trunk/file1 #from: jpeacock@example.com #handle_path: project1/trunk #io_layer: encoding(UTF-8) #message: # - start work on first project #message_size: 27 #repos_path: /home/jpeacock/devel/SVN-Notify-Config/t/test-repos #revision: 2 #revision_url: ~ #sendmail: /usr/sbin/sendmail #smtp_authtype: PLAIN #subject: '[2] start work on first project' #svnlook: /usr/local/bin/svnlook #to: # - trunk@example.com # - other@example.com #user: jpeacock #user_domain: example.com #verbose: 0 #with_diff: 1 ok 2 - All object properties match at rev: 2 ... John -- John Peacock Director of Information Research and Technology Rowman & Littlefield Publishing Group 4501 Forbes Blvd Suite H Lanham, MD 20706 301-459-3366 x.5010 fax 301-429-5747

Tue Apr 17 10:59:51 2007 micah [...] riseup.net - Correspondence added

Subject:	Re: [rt.cpan.org #26209] verbose test result failures
Date:	Tue, 17 Apr 2007 09:03:30 -0600
To:	John Peacock via RT <bug-SVN-Notify-Config [...] rt.cpan.org>
From:	Micah Anderson <micah [...] riseup.net>

* John Peacock via RT <bug-SVN-Notify-Config@rt.cpan.org> [070416 05:24]: Show quoted text

> > <URL: http://rt.cpan.org/Ticket/Display.html?id=26209 > > > Micah Anderson via RT wrote:

> > $ perl t/002_config.t --verbose

> > That's running against the already installed files. To test the uninstalled > modules, you need to do: > > $ ./Build test --test_files=t/002_config.t --verbose

Apologies, here is the output of $ ./Build test --test_files=t/002_config.t --verbose t/002_config....ok 1 - No changes at rev: 1 #--- YAML #--- !!perl/hash:SVN::Notify::Dummy #PATH: /usr/local/bin:/usr/bin #charset: UTF-8 #date: '2005-12-26 12:38:12 -0500 (Mon, 26 Dec 2005)' #files: # A: # - project1/trunk/dir1/ # - project1/trunk/dir1/file2 # - project1/trunk/file1 #from: jpeacock@example.com #handle_path: project1/trunk #io_layer: encoding(UTF-8) #message: # - start work on first project #message_size: 27 #repos_path: /home/micah/debian/SVN-Notify-Config-0.0907/t/test-repos #revision: 2 #revision_url: ~ #sendmail: /usr/sbin/sendmail #smtp_authtype: PLAIN #subject: '[2] start work on first project' #svnlook: /usr/bin/svnlook #to: # - trunk@example.com # - other@example.com #user: jpeacock #user_domain: example.com #verbose: 0 #with_diff: 1 ok 2 - All object properties match at rev: 2 # Failed test 'Failed to produce expected results at rev: 3' not ok 3 - Failed to produce expected results at rev: 3 # in t/coretests.pm at line 118. ok 4 - No changes at rev: 4 #--- YAML #--- !!perl/hash:SVN::Notify::Dummy #PATH: /usr/local/bin:/usr/bin #charset: UTF-8 #date: '2005-12-26 12:38:14 -0500 (Mon, 26 Dec 2005)' #files: # A: # - project1/branches/branch1/dir2/ # - project1/branches/branch1/dir2/file4 # - project1/branches/branch1/file3 #from: branch@example.com #handle_path: project1/branches/branch1 #io_layer: encoding(UTF-8) #message: # - simulate branch development #message_size: 27 #repos_path: /home/micah/debian/SVN-Notify-Config-0.0907/t/test-repos #revision: 5 #revision_url: ~ #sendmail: /usr/sbin/sendmail #smtp_authtype: PLAIN #subject: '[5] simulate branch development' #svnlook: /usr/bin/svnlook #to: # - 'branches@example.com,branch1@example.com' #user: jpeacock #verbose: 0 #with_diff: ~ ok 5 - All object properties match at rev: 5 #--- YAML #--- !!perl/hash:SVN::Notify::Dummy #charset: UTF-8 #date: '2005-12-26 12:38:15 -0500 (Mon, 26 Dec 2005)' #files: # A: # - project1/trunk/dir2/ # - project1/trunk/file3 #from: jpeacock@example.com #handle_path: project1/trunk #io_layer: encoding(UTF-8) #message: # - merge from branch1 #message_size: 18 #repos_path: /home/micah/debian/SVN-Notify-Config-0.0907/t/test-repos #revision: 6 #revision_url: ~ #sendmail: /usr/sbin/sendmail #smtp_authtype: PLAIN #subject: '[6] merge from branch1' #svnlook: /usr/bin/svnlook #to: # - trunk@example.com # - other@example.com #user: jpeacock #user_domain: example.com #verbose: 0 #with_diff: 1 # Failed test 'All object properties match at rev: 6' # in t/coretests.pm at line 110. # Structures begin differing at: # $got->[0]{PATH} = Does not exist # $expected->[0]{PATH} = '/usr/local/bin:/usr/bin' not ok 6 - All object properties match at rev: 6 # Failed test 'Failed to produce expected results at rev: 7' # in t/coretests.pm at line 118. # Looks like you failed 3 tests of 7. not ok 7 - Failed to produce expected results at rev: 7 1..7 dubious Test returned status 3 (wstat 768, 0x300) DIED. FAILED tests 3, 6-7 Failed 3/7 tests, 57.14% okay Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- t/002_config.t 3 768 7 3 42.86% 3 6-7 Failed 1/1 test scripts, 0.00% okay. 3/7 subtests failed, 57.14% okay.

Mon May 21 02:27:53 2007 ANDK [...] cpan.org - Correspondence added

John, are you sure that you have upgraded your system to SVN::Notify 2.65? I can confirm similar test failures in my smokes since 2007-03-27. Your tests broke that day due to the 2.65 release of SVN::Notify. Downgrading to 2.64 makes all tests pass again. I said similar failures, so I should show them. So this is the failure mode with bleadperl@31244 ATM: cpan[2]> test SVN::Notify::Config Running test for module 'SVN::Notify::Config' CPAN: CPAN::Kwalify loaded ok (v5.401418) CPAN: Kwalify loaded ok (v1.14) Running make for J/JP/JPEACOCK/SVN-Notify-Config-0.0907.tar.gz Has already been unwrapped into directory /home/sand/.cpan/build/SVN-Notify-Config-0.0907-Xgs9t8 Has already been made Running make test /home/src/perl/repoperls/installed-perls/perl/peSkxq2/perl-5.8.0@31244/bin/perl Build --makefile_env_macros 1 test t/001_basic.....ok t/002_config....ok 2/0 # Failed test 'Failed to produce expected results at rev: 3' # at t/coretests.pm line 116. t/002_config....NOK 6/0 # Failed test 'All object properties match at rev: 6' # at t/coretests.pm line 108. # Structures begin differing at: # $got->[0]{PATH} = Does not exist # $expected->[0]{PATH} = '/usr/local/bin:/usr/bin' # Failed test 'Failed to produce expected results at rev: 7' # at t/coretests.pm line 116. # Looks like you failed 3 tests of 7. t/002_config....dubious Test returned status 3 (wstat 768, 0x300) DIED. FAILED tests 3, 6-7 Failed 3/7 tests, 57.14% okay t/003_config....NOK 9/0 # Failed test 'All object properties match at rev: 9' # at t/coretests.pm line 108. # Structures begin differing at: # $got->[1] = Does not exist # $expected->[1] = SVN::Notify::Dummy=HASH(0x86d4dec) t/003_config....NOK 12/0 # Failed test 'All object properties match at rev: 12' # at t/coretests.pm line 108. # Structures begin differing at: # $got->[1] = Does not exist # $expected->[1] = SVN::Notify::Dummy=HASH(0x86d5864) # Looks like you failed 2 tests of 12. t/003_config....dubious Test returned status 2 (wstat 512, 0x200) DIED. FAILED tests 9, 12 Failed 2/12 tests, 83.33% okay Failed Test Stat Wstat Total Fail List of Failed ------------------------------------------------------------------------------- t/002_config.t 3 768 7 3 3 6-7 t/003_config.t 2 512 12 2 9 12 Failed 2/3 test scripts. 5/20 subtests failed. Files=3, Tests=20, 16 wallclock secs ( 9.87 cusr + 0.90 csys = 10.77 CPU) Failed 2/3 test programs. 5/20 subtests failed. make: *** [test] Error 2 JPEACOCK/SVN-Notify-Config-0.0907.tar.gz /usr/bin/make test -- NOT OK Failed during this command: JPEACOCK/SVN-Notify-Config-0.0907.tar.gz : make_test NO After a downgrade of SVN::Notify to 2.64 (DWHEELER/SVN-Notify-2.64.tar.gz) we see: cpan[6]> test SVN::Notify::Config Running test for module 'SVN::Notify::Config' Running make for J/JP/JPEACOCK/SVN-Notify-Config-0.0907.tar.gz Has already been unwrapped into directory /home/sand/.cpan/build/SVN-Notify-Config-0.0907-Xgs9t8 Has already been made Running make test /home/src/perl/repoperls/installed-perls/perl/peSkxq2/perl-5.8.0@31244/bin/perl Build --makefile_env_macros 1 test t/001_basic.....ok t/002_config....ok t/003_config....ok All tests successful. Files=3, Tests=20, 25 wallclock secs (10.36 cusr + 0.85 csys = 11.21 CPU) JPEACOCK/SVN-Notify-Config-0.0907.tar.gz /usr/bin/make test -- OK

Mon May 21 08:30:13 2007 jpeacock [...] rowman.com - Correspondence added

Subject:	Re: [rt.cpan.org #26209] verbose test result failures
Date:	Mon, 21 May 2007 08:27:16 -0400
To:	bug-SVN-Notify-Config [...] rt.cpan.org
From:	John Peacock <jpeacock [...] rowman.com>

Andreas Koenig via RT wrote: Show quoted text

> Queue: SVN-Notify-Config > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=26209 > > > John, are you sure that you have upgraded your system to SVN::Notify 2.65? > > I can confirm similar test failures in my smokes since 2007-03-27. Your > tests broke that day due to the 2.65 release of SVN::Notify. Downgrading > to 2.64 makes all tests pass again.

Thank you! I missed that the OP was reporting the tests vs 2.65. Now that I can reproduce the failures locally, I can fix them... John -- John Peacock Director of Information Research and Technology Rowman & Littlefield Publishing Group 4501 Forbes Blvd Suite H Lanham, MD 20706 301-459-3366 x.5010 fax 301-429-5747

Sat May 26 10:50:01 2007 jpeacock [...] cpan.org - Correspondence added

I've confirmed that the problem actually lies with a regression in SVN::Notify-2.65 itself. As soon as David releases a fixed up version, this test failure will go away. Downgrading to SVN::Notify-2.64 is a workaround until that time... John

Sat May 26 10:50:04 2007 jpeacock [...] cpan.org - Status changed from 'open' to 'resolved'