Skip Menu |

This queue is for tickets about the ExtUtils-MakeMaker CPAN distribution.

Report information
The Basics
Id: 26161
Status: resolved
Priority: 0/
Queue: ExtUtils-MakeMaker

People
Owner: Nobody in particular
Requestors: SMPETERS [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] Assorted changes from bleadperl
The following patches have been applied to bleadperl. ==== //depot/perl/lib/ExtUtils/MM_Unix.pm#215 (text) ==== @@ -2538,7 +2538,7 @@ MAP_LIBPERL "$(MAP_LIBPERL)" \ Show quoted text
>> }.$self->catfile('$(DESTINSTALLARCHLIB)','perllocal.pod').q{
-}; +} if -f 'Makefile.PL'; push @m, q{ inst_perl: pure_inst_perl doc_inst_perl @@ -3415,6 +3415,7 @@ } # note: 'test.pl' name is also hardcoded in init_dirscan() my(@m); + my $subdirs_test = ($self->{DIR} && @{$self->{DIR}} ? 'subdirs-test' : ''); push(@m," TEST_VERBOSE=0 TEST_TYPE=test_\$(LINKTYPE) @@ -3424,17 +3425,17 @@ testdb :: testdb_\$(LINKTYPE) -test :: \$(TEST_TYPE) +test :: \$(TEST_TYPE) $subdirs_test "); foreach my $dir (@{ $self->{DIR} }) { my $test = $self->oneliner(sprintf <<'CODE', $dir); chdir '%s'; -system '$(MAKE) test $(PASTHRU)' +system '$(MAKE) $(USEMAKEFILE) $(FIRST_MAKEFILE) test $(PASTHRU)' if -f '$(FIRST_MAKEFILE)'; CODE - push(@m, "\t\$(NOECHO) $test\n"); + push(@m, "\nsubdirs-test ::\n\t\$(NOECHO) $test\n"); } push(@m, "\t\$(NOECHO) \$(ECHO) 'No tests defined for \$(NAME) extension.'\n") ==== //depot/perl/lib/ExtUtils/MakeMaker.pm#130 (text) ==== @@ -634,15 +634,15 @@ my %att = @_; my $self = MM->new(\%att); - if (-f $self->{MAKEFILE_OLD}) { - _unlink($self->{MAKEFILE_OLD}) or - warn "unlink $self->{MAKEFILE_OLD}: $!"; + my $new = $self->{FIRST_MAKEFILE}; + my $old = $self->{MAKEFILE_OLD}; + if (-f $old) { + _unlink($old) or warn "unlink $old: $!"; } - if ( -f $self->{MAKEFILE} ) { - _rename($self->{MAKEFILE}, $self->{MAKEFILE_OLD}) or - warn "rename $self->{MAKEFILE} => $self->{MAKEFILE_OLD}: $!" + if ( -f $new ) { + _rename($new, $old) or warn "rename $new => $old: $!" } - open MF, '>'.$self->{MAKEFILE} or die "open $self->{MAKEFILE} for write: $!"; + open MF, '>'.$new or die "open $new for write: $!"; print MF <<'EOP'; all: @@ -655,7 +655,7 @@ test: EOP - close MF or die "close $self->{MAKEFILE} for write: $!"; + close MF or die "close $new for write: $!"; } sub check_manifest { @@ -880,9 +880,10 @@ my $self = shift; my($chunk); local *FH; - print STDOUT "Writing $self->{MAKEFILE} for $self->{NAME}\n"; + my($finalname) = $self->{FIRST_MAKEFILE}; + print STDOUT "Writing $finalname for $self->{NAME}\n"; - unlink($self->{MAKEFILE}, "MakeMaker.tmp", $Is_VMS ? 'Descrip.MMS' : ''); + unlink($finalname, "MakeMaker.tmp", $Is_VMS ? 'Descrip.MMS' : ()); open(FH,">MakeMaker.tmp") or die "Unable to open MakeMaker.tmp: $!"; for $chunk (@{$self->{RESULT}}) { @@ -890,7 +891,6 @@ } close FH; - my($finalname) = $self->{MAKEFILE}; _rename("MakeMaker.tmp", $finalname) or warn "rename MakeMaker.tmp => $finalname: $!"; chmod 0644, $finalname unless $Is_VMS;
On Sun Apr 08 12:08:13 2007, SMPETERS wrote: Show quoted text
> The following patches have been applied to bleadperl.
What do these patches do?
Most of this has been integrated and/or dealt with. The remaining issue with subdirs-test I suspect is covered by 27084.
This has all been dealt with.