Bug #26143 for XML-XPath: setNodeText doesn't work with unabbreviated attribute axis syntax

Fri Apr 06 20:28:37 2007 charleswoerner [...] gmail.com - Ticket created

Subject:

setNodeText doesn't work with unabbreviated attribute axis syntax

setNodeText() doesn't work with the unabbreviated attribute axis syntax. For example, you can't say $xpath->setNodeText("/foo/bar/baz/attribute::id", "id1"); The abbreviated axis syntax "/foo/bar/baz/\@id='123'" does work, so there is a suitable workaround. Still, it appears to be a bug.

Fri Apr 06 20:33:55 2007 charleswoerner [...] gmail.com - Correspondence added

From:

charleswoerner [...] gmail.com

Attached is a test case and a patch which address this issue. On Fri Apr 06 20:28:37 2007, cwoerner wrote: Show quoted text

> setNodeText() doesn't work with the unabbreviated attribute axis syntax. > For example, you can't say > > $xpath->setNodeText("/foo/bar/baz/attribute::id", "id1"); > > The abbreviated axis syntax "/foo/bar/baz/\@id='123'" does work, so > there is a suitable workaround. Still, it appears to be a bug.

package main; use strict; use warnings; use Test::More tests => 3; use_ok("XML::XPath"); my $path = XML::XPath->new(ioref => \*DATA); $path->createNode("/child::foo/child::bar/child::baz"); # # test unabbreviated syntax # $path->setNodeText("/child::foo/child::bar/child::baz/attribute::id", "id1"); my $set = $path->find("/foo/bar/baz"); my @nodelist = $set->get_nodelist; ok($nodelist[0]->toString =~ /id="id1"/); # # test abbreviated syntax # $path->setNodeText("/foo/bar/baz/\@id", "id2"); $set = $path->find("/foo/bar/baz"); @nodelist = $set->get_nodelist; ok($nodelist[0]->toString =~ /id="id2"/); __DATA__ <?xml version="1.0" ?> <instanceData> </instanceData>

Fri Apr 06 20:34:57 2007 charleswoerner [...] gmail.com - Correspondence added

From:

charleswoerner [...] gmail.com

And here's the patch. On Fri Apr 06 20:33:55 2007, cwoerner wrote: Show quoted text

> Attached is a test case and a patch which address this issue. > > On Fri Apr 06 20:28:37 2007, cwoerner wrote:

> > setNodeText() doesn't work with the unabbreviated attribute axis syntax. > > For example, you can't say > > > > $xpath->setNodeText("/foo/bar/baz/attribute::id", "id1"); > > > > The abbreviated axis syntax "/foo/bar/baz/\@id='123'" does work, so > > there is a suitable workaround. Still, it appears to be a bug.

>

--- /usr/local/lib/perl5/site_perl/5.8.6/XML/XPath.pm 2003-01-26 11:33:17.000000000 -0800 +++ lib/XML/XPath.pm 2007-04-06 15:34:12.000000000 -0700 @@ -190,7 +190,7 @@ return undef if (!defined $nodeset); # could not find node my @nodes = $nodeset->get_nodelist; if ($#nodes < 0) { - if ($node_path =~ m|/@([^/]+)$|) { + if ($node_path =~ m{/(?:@|attribute::)([^/]+)$}) { # attribute not found, so try to create it my $parent_path = $`; my $attr = $1;

Wed Jan 06 08:43:08 2016 MANWAR [...] cpan.org - Taken

Wed Jan 06 08:44:24 2016 MANWAR [...] cpan.org - Correspondence added

Hi, Thanks for reporting the issue and the patch as well. I will try to get it applied asap. Best Regards, Mohammad S Anwar

Wed Jan 06 08:44:24 2016 The RT System itself - Status changed from 'new' to 'open'

Sun Jan 10 05:26:37 2016 MANWAR [...] cpan.org - Correspondence added

Resolved.

Sun Jan 10 05:26:39 2016 MANWAR [...] cpan.org - Status changed from 'open' to 'resolved'

Sun Jan 10 05:26:40 2016 MANWAR [...] cpan.org - Fixed in 1.20 added