Bug #2603 for CGI-Session: please add method : redirect

Mon May 19 14:43:14 2003 makoto [...] cpan.org - Ticket created

Subject:

please add method : redirect

sub redirect { my $session = shift; my($url,$param) = split(/\?/,shift); my %param = map {split /=/,$_,2} split /&/ ,$param; unless(exists $param{$session->name}){ $param{$session->name} = $session->id; } my $r = $url; my $r_param = join "&",map {"$_=$param{$_}"} keys %param; $r = "$r?$r_param" if($r_param); return CGI->redirect(-uri => $r , @_); }

Tue Jul 15 12:10:55 2003 MARKSTOS [...] cpan.org - Correspondence added

From:

mark [...] summersault.com

Here's a simplication of this patch: sub redirect { my $session = shift; my($url,$param) = split(/\?/,shift); my $q = new CGI ($param); $q->param($session->name,$session->id); return $q->redirect(-uri => "$url?".$q->query_string); } It makes use CGI.pm's built-in functions to manage query string parameters. Neither patch allows you to pass other headers when you redirect, which is sometimes useful. Of course, CGI.pm's redirect could always be used directly for that.

Tue Jul 15 12:17:02 2003 MARKSTOS [...] cpan.org - Correspondence added

[MARKSTOS - Tue Jul 15 12:10:55 2003]: Show quoted text

> Here's a simplication of this patch: > > sub redirect { > my $session = shift; > my($url,$param) = split(/\?/,shift); > my $q = new CGI ($param); > $q->param($session->name,$session->id); > return $q->redirect(-uri => "$url?".$q->query_string); > } > > It makes use CGI.pm's built-in functions to manage query string > parameters. Neither > patch allows you to pass other headers when you redirect, which is > sometimes useful. > Of course, CGI.pm's redirect could always be used directly for that. >

Ah, the original patch /did/ support passing through additional parameters. That just wasn't clear to me at first. The last line of my simplification needs to be updated to support that: return $q->redirect(-uri => "$url?".$q->query_string, @_);

Tue Jul 15 13:32:40 2003 sherzodr [...] handalak.com - Correspondence added

Date:	Tue, 15 Jul 2003 11:32:41 -0600 (MDT)
From:	Sherzod Ruzmetov <sherzodr [...] handalak.com>
To:	via RT <bug-CGI-Session [...] rt.cpan.org>
Subject:	Re: [cpan #2603] please add method : redirect
RT-Send-Cc:

:sub redirect { : my $session = shift; : my($url,$param) = split(/\?/,shift); : my $q = new CGI ($param); : $q->param($session->name,$session->id); : return $q->redirect(-uri => "$url?".$q->query_string); :} :It makes use CGI.pm's built-in functions to manage query string parameters. Neither :patch allows you to pass other headers when you redirect, which is sometimes useful. :Of course, CGI.pm's redirect could always be used directly for that. Thanks for the patch. I'll make sure to provide redirect() and other utility methods in the next release. -- Sherzod B. Ruzmetov <sherzodr@handalak.com> <URL: http://author.handalak.com >

Sun Jul 03 12:54:36 2005 sherzodr [...] cpan.org - Taken

Fri Mar 03 19:55:12 2006 MARKSTOS [...] cpan.org - Correspondence added

I know I helped with this patch, but I've changed my mind about the appropriateness of having this in the core of CGI::Session. CGI::Session has already become a large package and a redirect() function is not central to session management. I suggest instead releasing this as CGI::Session::Plugin::Redirect, using a mix-in pattern to make this appear as an additional CGI::Session method. That way, you can have the extra method you want, and be responsible for any future maintenance of it as well. :) Sherzod may disagree with me about this re-open the ticket, but I'm marking it 'rejected' it for now. Mark

Fri Mar 03 19:55:13 2006 The RT System itself - Status changed from 'new' to 'open'

Fri Mar 03 19:55:14 2006 MARKSTOS [...] cpan.org - Status changed from 'open' to 'rejected'