Skip Menu |

This queue is for tickets about the Lchown CPAN distribution.

Report information
The Basics
Id: 25968
Status: resolved
Priority: 0/
Queue: Lchown

People
Owner: Nobody in particular
Requestors: devin.heitmueller [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.00
Fixed in: (no value)



Subject: [PATCH] Fixes for win32 build and make test
This patch addresses the failures seen when compiling Lchown under Win32. Now it compiles successfully and skips the tests as appropriate on Win32. While the functionality is virtually useless on Win32 from a practical standpoint, the module should at least compile cleanly and skips its tests as appropriate. Problems fixed and verified against perl 5.8.8 MSWin32-x86-multi-thread.
Subject: lchown.patch
Index: Lchown.xs =================================================================== --- Lchown.xs (revision 15364) +++ Lchown.xs (working copy) @@ -25,6 +25,6 @@ ST(0) = sv_2mortal(newSViv(ok)); #else errno = ENOSYS; - ST(0) = &sv_undef; + ST(0) = &PL_sv_undef; #endif Index: t/notsup.t =================================================================== --- t/notsup.t (revision 15364) +++ t/notsup.t (working copy) @@ -10,6 +10,9 @@ ok( ! defined lchown($uid, $gid), "null lchown call failed" ); like( $!, '/function not implemented/i', "null lchown gave ENOSYS" ); + + my $symlink_exists = eval { symlink("",""); 1 }; + skip "Symlink not supported", 4 if !defined($symlink_exists); symlink 'bar', 'foo' or skip "can't make a symlink", 2; ok( ! defined lchown($uid, $gid, 'foo'), "valid lchown call failed" );
On Fri Mar 30 11:13:09 2007, devin.heitmueller wrote: Show quoted text
> This patch addresses the failures seen when compiling Lchown under > Win32. Now it compiles successfully and skips the tests as appropriate > on Win32. > > While the functionality is virtually useless on Win32 from a practical > standpoint, the module should at least compile cleanly and skips its > tests as appropriate. > > Problems fixed and verified against perl 5.8.8 MSWin32-x86-multi-thread.
Applied, thanks.