Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Module-Starter CPAN distribution.

Report information
The Basics
Id: 25905
Status: resolved
Priority: 0/
Queue: Module-Starter

People
Owner: Nobody in particular
Requestors: cbouvi [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in:
  • 1.42
  • 1.43_01
  • 1.44
  • 1.46
  • 1.470
  • 1.50
Fixed in: (no value)



Subject: boilerplate generated on Windows fails on Unix
The boilerplate.t files gets generated with a list of paths to the modules, in a call to module_boilerplate_ok(). When the module is created on Windows, the paths contain backslashes as directory separators. And of course, boilerplate.t complains when trying to install on a Unix machine. The paths in the call to module_boilerplate_ok should use forward slashes, no matter what. Maybe use join('/', File::Spec->splitdir(...)) ? or something... TIA
Here is a patch.
# RT25905: boilerplate path # # To apply this patch: # STEP 1: Chdir to the source directory. # STEP 2: Run the 'applypatch' program with this patch file as input. # # If you do not have 'applypatch', it is part of the 'makepatch' package # that you can fetch from the Comprehensive Perl Archive Network: # http://www.perl.com/CPAN/authors/Johan_Vromans/makepatch-x.y.tar.gz # In the above URL, 'x' should be 2 or higher. # # To apply this patch without the use of 'applypatch': # STEP 1: Chdir to the source directory. # STEP 2: Run the 'patch' program with this file as input. # #### End of Preamble #### #### Patch data follows #### diff -urp --binary "Module-Starter-1.50\lib\Module\Starter\Simple.pm" "Module-Starter-1.50.RT25905\lib\Module\Starter\Simple.pm" Index: ./lib/Module/Starter/Simple.pm --- ./lib/Module/Starter/Simple.pm Tue Oct 28 06:29:21 2008 +++ ./lib/Module/Starter/Simple.pm Thu May 7 18:48:46 2009 @@ -680,7 +680,7 @@ HERE my $module_boilerplate_tests; $module_boilerplate_tests .= - " module_boilerplate_ok('$self->{module_file}{$_}');\n" for @modules; + " module_boilerplate_ok('".$self->_module_to_pm_file($_)."');\n" for @modules; my $boilerplate_tests = @modules + 2 + $[; $t_files{'boilerplate.t'} = <<"HERE"; #### End of Patch data #### #### ApplyPatch data follows #### # Data version : 1.0 # Date generated : Thu May 7 19:47:20 2009 # Generated by : makepatch 2.03 # Recurse directories : Yes # Excluded files : (\A|/).*\~\Z # (\A|/).*\.a\Z # (\A|/).*\.bak\Z # (\A|/).*\.BAK\Z # (\A|/).*\.elc\Z # (\A|/).*\.exe\Z # (\A|/).*\.gz\Z # (\A|/).*\.ln\Z # (\A|/).*\.o\Z # (\A|/).*\.obj\Z # (\A|/).*\.olb\Z # (\A|/).*\.old\Z # (\A|/).*\.orig\Z # (\A|/).*\.rej\Z # (\A|/).*\.so\Z # (\A|/).*\.Z\Z # (\A|/)\.del\-.*\Z # (\A|/)\.make\.state\Z # (\A|/)\.nse_depinfo\Z # (\A|/)core\Z # (\A|/)tags\Z # (\A|/)TAGS\Z # p "lib/Module/Starter/Simple.pm" 25589 1241714926 0100666 #### End of ApplyPatch data #### #### End of Patch kit [created: Thu May 7 19:47:20 2009] #### #### Patch checksum: 47 1908 56763 #### #### Checksum: 65 2557 44916 ####
Fixed in 1.52. Thanks!