Skip Menu |

This queue is for tickets about the ExtUtils-ModuleMaker CPAN distribution.

Report information
The Basics
Id: 25830
Status: resolved
Worked: 1 hour (60 min)
Priority: 0/
Queue: ExtUtils-ModuleMaker
People
Owner: jkeenan [...] cpan.org
Requestors: sirianpm [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.47
Fixed in: (no value)

History Show all quoted text
  Mon Mar 26 16:56:09 2007 sirianpm [...] gmail.com - Ticket created
Subject: Problem with Interactive.pm after adding a local license
After attempting to add a license to Local.pm I encountered errors in the tests for ExtUtils::ModuleMaker. The attached txt file includes the output from the make and make test commands. The changes made to Local.pm are also attached. I am developing on a Windows XP SP2 machine with ActiveState ActivePerl v5.8.8, using nmake as my make utility. Is this a problem with my license addition or the code in Interactive.pm? Thanks, Paul
Subject: Local.pm

Message body is not shown because it is too large.

Subject: EXTUtils-ModuleMaker-0..47_nmakeOutput.TXT
C:\Download\ExtUtils-ModuleMaker-0.47>nmake Microsoft (R) Program Maintenance Utility Version 6.00.9782.0 Copyright (C) Microsoft Corp 1988-1998. All rights reserved. Skip blib\lib\ExtUtils\ModuleMaker.pm (unchanged) Skip blib\lib\ExtUtils\ModuleMaker\Licenses\Standard.pm (unchanged) Skip blib\lib\ExtUtils\ModuleMaker\StandardText.pm (unchanged) Skip blib\lib\ExtUtils\ModuleMaker\Defaults.pm (unchanged) Skip blib\lib\ExtUtils\ModuleMaker\Opts.pm (unchanged) Skip blib\lib\ExtUtils\ModuleMaker\Initializers.pm (unchanged) cp lib/ExtUtils/ModuleMaker/Licenses/Local.pm blib\lib\ExtUtils\ModuleMaker\Lice nses\Local.pm Skip blib\lib\ExtUtils\ModuleMaker\Auxiliary.pm (unchanged) Skip blib\lib\ExtUtils\ModuleMaker\Interactive.pm (unchanged) C:\Perl\bin\perl.exe -MExtUtils::Command -e cp scripts/modulemaker blib\ script\modulemaker pl2bat.bat blib\script\modulemaker C:\Download\ExtUtils-ModuleMaker-0.47>nmake test Microsoft (R) Program Maintenance Utility Version 6.00.9782.0 Copyright (C) Microsoft Corp 1988-1998. All rights reserved. C:\Perl\bin\perl.exe -MExtUtils::Command -e cp scripts/modulemaker blib\ script\modulemaker pl2bat.bat blib\script\modulemaker C:\Perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0, 'bl ib\lib', 'blib\arch')" t/01_ini.t t/03_quick.t t/04_compact.t t/05_abstract.t t/ 06_build.t t/07_proxy.t t/10_standard_text.t t/13_alt_block_new_method.t t/14_mm kr_alt_block_new_method.t t/failsafe/201.t t/failsafe/202.t t/failsafe/203.t t/f ailsafe/204.t t/failsafe/205.t t/failsafe/206.t t/failsafe/207.t t/failsafe/208. t t/failsafe/209.t t/failsafe/210.t t/failsafe/211.t t/license/apache.t t/licens e/apache_1_1.t t/license/artistic.t t/license/artistic_agg.t t/license/bsd.t t/l icense/gpl.t t/license/gpl_2.t t/license/ibm.t t/license/ibm_1_0.t t/license/int el.t t/license/jabber.t t/license/jabber_1_0.t t/license/lgpl.t t/license/lgpl_2 _1.t t/license/libpng.t t/license/looselips.t t/license/mit.t t/license/mitre.t t/license/mozilla.t t/license/mozilla_1_0.t t/license/mozilla_1_1.t t/license/mp l.t t/license/mpl_1_0.t t/license/mpl_1_1.t t/license/nethack.t t/license/nokia. t t/license/nokia_1_0a.t t/license/nokos.t t/license/nokos_1_0a.t t/license/perl .t t/license/python.t t/license/q.t t/license/q_1_0.t t/license/r_bsd.t t/licens e/ricoh.t t/license/ricoh_1_0.t t/license/sissl.t t/license/sleepycat.t t/licens e/sun.t t/license/vovida.t t/license/vovida_1_0.t t/license/zlib.t t/makedefault s/1201.t t/makedefaults/1202.t t/makedefaults/1203.t t/miscargs/901.t t/miscargs /902.t t/miscargs/903.t t/miscargs/904.t t/miscargs/905.t t/miscargs/906.t t/mis cargs/907.t t/miscargs/908.t t/miscargs/909.t t/miscargs/910.t t/miscargs/911.t t/miscargs/912.t t/miscargs/913.t t/miscargs/914.t t/miscargs/915.t t/miscargs/9 16.t t/miscargs/917.t t/miscargs/918.t t/miscargs/919.t t/miscargs/920.t t/misca rgs/921.t t/miscargs/922.t t/miscargs/923.t t/mmkr/801.t t/mmkr/802.t t/mmkr/803 .t t/mmkr/804.t t/mmkr/805.t t/mmkr/806.t t/mmkr/807.t t/mmkr/808.t t/01_ini..........................ok t/03_quick........................ok t/04_compact......................ok t/05_abstract.....................ok t/06_build........................ok 13/23 skipped: tests require File::Temp, core with 5.6, and require Modu le::Build t/07_proxy........................ok 47/57 skipped: tests require File::Temp, core with 5.6, and require Modu le::Build t/10_standard_text................ok t/13_alt_block_new_method.........ok t/14_mmkr_alt_block_new_method....ok 1/39Use of uninitialized value in string co mparison (cmp) at C:/Download/ExtUtils-ModuleMaker-0.47/blib/lib/ExtUtils/Module Maker/Interactive.pm line 79. Use of uninitialized value in string comparison (cmp) at C:/Download/ExtUtils-Mo duleMaker-0.47/blib/lib/ExtUtils/ModuleMaker/Interactive.pm line 79. t/14_mmkr_alt_block_new_method....ok t/failsafe/201....................ok t/failsafe/202....................ok t/failsafe/203....................ok t/failsafe/204....................ok t/failsafe/205....................ok t/failsafe/206....................ok t/failsafe/207....................ok t/failsafe/208....................ok t/failsafe/209....................ok t/failsafe/210....................ok t/failsafe/211....................ok t/license/apache..................ok t/license/apache_1_1..............ok t/license/artistic................ok t/license/artistic_agg............ok t/license/bsd.....................ok t/license/gpl.....................ok t/license/gpl_2...................ok t/license/ibm.....................ok t/license/ibm_1_0.................ok t/license/intel...................ok t/license/jabber..................ok t/license/jabber_1_0..............ok t/license/lgpl....................ok t/license/lgpl_2_1................ok t/license/libpng..................ok t/license/looselips...............ok t/license/mit.....................ok t/license/mitre...................ok t/license/mozilla.................ok t/license/mozilla_1_0.............ok t/license/mozilla_1_1.............ok t/license/mpl.....................ok t/license/mpl_1_0.................ok t/license/mpl_1_1.................ok t/license/nethack.................ok t/license/nokia...................ok t/license/nokia_1_0a..............ok t/license/nokos...................ok t/license/nokos_1_0a..............ok t/license/perl....................ok t/license/python..................ok t/license/q.......................ok t/license/q_1_0...................ok t/license/r_bsd...................ok t/license/ricoh...................ok t/license/ricoh_1_0...............ok t/license/sissl...................ok t/license/sleepycat...............ok t/license/sun.....................ok t/license/vovida..................ok t/license/vovida_1_0..............ok t/license/zlib....................ok t/makedefaults/1201...............ok t/makedefaults/1202...............ok t/makedefaults/1203...............ok 1/37Use of uninitialized value in string co mparison (cmp) at C:/Download/ExtUtils-ModuleMaker-0.47/blib/lib/ExtUtils/Module Maker/Interactive.pm line 79. Use of uninitialized value in string comparison (cmp) at C:/Download/ExtUtils-Mo duleMaker-0.47/blib/lib/ExtUtils/ModuleMaker/Interactive.pm line 79. t/makedefaults/1203...............ok t/miscargs/901....................ok t/miscargs/902....................ok t/miscargs/903....................ok t/miscargs/904....................ok t/miscargs/905....................ok t/miscargs/906....................ok t/miscargs/907....................ok t/miscargs/908....................ok t/miscargs/909....................ok t/miscargs/910....................ok t/miscargs/911....................ok t/miscargs/912....................ok t/miscargs/913....................ok t/miscargs/914....................ok t/miscargs/915....................ok t/miscargs/916....................ok t/miscargs/917....................ok t/miscargs/918....................ok t/miscargs/919....................ok t/miscargs/920....................ok t/miscargs/921....................ok t/miscargs/922....................ok t/miscargs/923....................ok t/mmkr/801........................ok 1/24Use of uninitialized value in string co mparison (cmp) at C:/Download/ExtUtils-ModuleMaker-0.47/blib/lib/ExtUtils/Module Maker/Interactive.pm line 79. Use of uninitialized value in string comparison (cmp) at C:/Download/ExtUtils-Mo duleMaker-0.47/blib/lib/ExtUtils/ModuleMaker/Interactive.pm line 79. t/mmkr/801........................ok t/mmkr/802........................ok 1/24Use of uninitialized value in string co mparison (cmp) at C:/Download/ExtUtils-ModuleMaker-0.47/blib/lib/ExtUtils/Module Maker/Interactive.pm line 79. Use of uninitialized value in string comparison (cmp) at C:/Download/ExtUtils-Mo duleMaker-0.47/blib/lib/ExtUtils/ModuleMaker/Interactive.pm line 79. t/mmkr/802........................ok t/mmkr/803........................ok 1/24Use of uninitialized value in string co mparison (cmp) at C:/Download/ExtUtils-ModuleMaker-0.47/blib/lib/ExtUtils/Module Maker/Interactive.pm line 79. Use of uninitialized value in string comparison (cmp) at C:/Download/ExtUtils-Mo duleMaker-0.47/blib/lib/ExtUtils/ModuleMaker/Interactive.pm line 79. t/mmkr/803........................ok t/mmkr/804........................ok 1/24Use of uninitialized value in string co mparison (cmp) at C:/Download/ExtUtils-ModuleMaker-0.47/blib/lib/ExtUtils/Module Maker/Interactive.pm line 79. Use of uninitialized value in string comparison (cmp) at C:/Download/ExtUtils-Mo duleMaker-0.47/blib/lib/ExtUtils/ModuleMaker/Interactive.pm line 79. t/mmkr/804........................ok t/mmkr/805........................ok 1/24Use of uninitialized value in string co mparison (cmp) at C:/Download/ExtUtils-ModuleMaker-0.47/blib/lib/ExtUtils/Module Maker/Interactive.pm line 79. Use of uninitialized value in string comparison (cmp) at C:/Download/ExtUtils-Mo duleMaker-0.47/blib/lib/ExtUtils/ModuleMaker/Interactive.pm line 79. t/mmkr/805........................ok t/mmkr/806........................ok 1/26Use of uninitialized value in string co mparison (cmp) at C:/Download/ExtUtils-ModuleMaker-0.47/blib/lib/ExtUtils/Module Maker/Interactive.pm line 79. Use of uninitialized value in string comparison (cmp) at C:/Download/ExtUtils-Mo duleMaker-0.47/blib/lib/ExtUtils/ModuleMaker/Interactive.pm line 79. t/mmkr/806........................ok t/mmkr/807........................ok 1/26Use of uninitialized value in string co mparison (cmp) at C:/Download/ExtUtils-ModuleMaker-0.47/blib/lib/ExtUtils/Module Maker/Interactive.pm line 79. Use of uninitialized value in string comparison (cmp) at C:/Download/ExtUtils-Mo duleMaker-0.47/blib/lib/ExtUtils/ModuleMaker/Interactive.pm line 79. t/mmkr/807........................ok t/mmkr/808........................ok 1/26Use of uninitialized value in string co mparison (cmp) at C:/Download/ExtUtils-ModuleMaker-0.47/blib/lib/ExtUtils/Module Maker/Interactive.pm line 79. Use of uninitialized value in string comparison (cmp) at C:/Download/ExtUtils-Mo duleMaker-0.47/blib/lib/ExtUtils/ModuleMaker/Interactive.pm line 79. t/mmkr/808........................ok All tests successful, 60 subtests skipped. Files=96, Tests=2198, 32 wallclock secs ( 0.00 cusr + 0.00 csys = 0.00 CPU) C:\Download\ExtUtils-ModuleMaker-0.47>
  Mon Mar 26 17:08:33 2007 sirianpm [...] gmail.com - Correspondence added
From: sirianpm [...] gmail.com
On Mon Mar 26 16:56:09 2007, Paul_AV wrote: Show quoted text
> After attempting to add a license to Local.pm I encountered errors
in Show quoted text
> the tests for ExtUtils::ModuleMaker. The attached txt file includes > the output from the make and make test commands. The changes made
to Show quoted text
> Local.pm are also attached. I am developing on a Windows XP SP2 > machine with ActiveState ActivePerl v5.8.8, using nmake as my make > utility. Is this a problem with my license addition or the code in > Interactive.pm? > > Thanks, > > Paul
My mistake what I encountered were warnings not errors. -Paul
  Mon Mar 26 19:03:07 2007 jkeen [...] verizon.net - Correspondence added
From: jkeen [...] verizon.net
On Mon Mar 26 16:56:09 2007, Paul_AV wrote: Show quoted text
> Is this a problem with my license addition or the code in > Interactive.pm? >
I'll have to investigate this. Not only are you the first person to report a bug in this aspect of EU::MM, you are the first to report even *using* this aspect of EU::MM! (I've never used it myself.) And, to complicate matters, the warning appeared when using EU::MM::Interactive -- the least well tested part of the distribution. (I have never managed to figure out how to use Expect, Test::Expect, etc., to test something as interactive as this module.) So I will have to hunt my way through this. Would it be possible to send me the output of running some of the tests which generated warnings through 'prove'? Example: Post output of: prove -v t/mmkr/801.t Thank you very much. Jim Keenan
  Mon Mar 26 19:03:09 2007 The RT System itself - Status changed from 'new' to 'open'
  Mon Mar 26 19:38:02 2007 jkeenan [...] cpan.org - Taken
  Mon Mar 26 19:56:24 2007 jkeenan [...] cpan.org - Correspondence added 60 min
This was a real bug! I have just uploaded a new version (0.48) of ExtUtils::ModuleMaker to CPAN. If you wish to simply correct the bug in your local version you can apply the attached patch. Paul: If you come to YAPC::NA::2007, I'll buy you a beer. jimk
Index: lib/ExtUtils/ModuleMaker/Interactive.pm =================================================================== --- lib/ExtUtils/ModuleMaker/Interactive.pm (revision 975) +++ lib/ExtUtils/ModuleMaker/Interactive.pm (revision 1152) @@ -5,7 +5,7 @@ BEGIN { use base qw( ExtUtils::ModuleMaker ); use vars qw ( $VERSION ); - $VERSION = 0.47; + $VERSION = 0.48; } use Carp; use Data::Dumper; @@ -77,7 +77,7 @@ ), ( map { [ $_, $License_Local->{$_} ] } - sort { $License_Standard->{$a} cmp $License_Standard->{$b} } + sort { $License_Local->{$a} cmp $License_Local->{$b} } keys( %{$License_Local} ) ), );
  Mon Mar 26 19:56:27 2007 jkeenan [...] cpan.org - Status changed from 'open' to 'resolved'