On Sun Mar 25 02:10:59 2007, CLACO wrote:
Show quoted text> On Sun Mar 25 01:56:22 2007, CLACO wrote:
> > When committing changes to a local branch and pushing those changes
> > upstream using svk push, the commit message under win32 seems to be
> > missing the time part and spells out the time zone, unlike the
> commit
> > messages from *nix clients.
> >
> > Here's a sample message from a recent commit to local, pushed up to
> the
> > mirror/master:
> >
> > r118@np5660: claco | 2007-03-25 Eastern Daylight Time
> >
> > If it weren't for the missing time, it wouldn't be so bad. I would
> > expect something more like:
> >
> > r118@np5660: claco | 2007-02-16 16:29:26 -0500
>
>
> Yup. That's almost certainly the issue. IF I svn log the master repo,
> the first line before the message has the correct date/time:
>
> C:\Development\CPAN\Mango>svn log
>
> ------------------------------------------------------------------------
> r1784 | claco | 2007-03-25 01:37:32 -0400 (Sun, 25 Mar 2007) | 3 lines
>
> r118@np5660: claco | 2007-03-25 Eastern Daylight Time
> Added tags() to products provider
>
>
> When I do the same in svk, the first line is wrong:
>
> C:\Development\CPAN\Mango>svk log
>
http://svn.handelframework.com/CPAN/Mango/trunk/lib/Mango/Provider/Products.pm
Show quoted text> ----------------------------------------------------------------------
> r119 (orig r1784): claco | 2007-03-25 Eastern Daylight Time
>
> r118@np5660: claco | 2007-03-25 Eastern Daylight Time
> Added tags() to products provider
>
>
>
> So, I'd summize that during svk push, svk is getting the wrong thing
> when calling POSIX::strftime...then sending that wrong string along as
> the new message when committing to the mirror/master.
Just as a final follow up, changing this code in Util.pm fixes the
problem for me on Win32...probably negating the speed increase achieved
by the original POSIX usage:
sub time2str {
my ($format, $time) = @_;
#require POSIX;
#return POSIX::strftime($format, localtime($time) );
require Date::Format;
return Date::Format::strftime($format, [localtime($time)]);
}
But at least now my commit messages are sane on my laptop. :-)
