Skip Menu |

This queue is for tickets about the Net-Delicious CPAN distribution.

Report information
The Basics
Id: 25760
Status: resolved
Priority: 0/
Queue: Net-Delicious

People
Owner: Nobody in particular
Requestors: rjbs [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: can't override update cache location
This took me too long to figure out... the documentation for "updates" is slightly confusing. It says: Default is the current user's home directory, followed by a temporary directory as determined by File::Temp. I thought it means "the homedir, catdir'd with another..." ...but that is not the problem. The problem I think is this code in Delicious.pm: if ((exists($self->{'__updates'})) && (-d $self->{'__updated'})) { $root = $self->{'__updates'}; } The second hash lookup should be __updates, not __updated. -- rjbs
Urg. My bad. Version 1.11 is on its way to the CPAN. In the meantime you can grab a copy over here : http://aaronland.info/perl/net/delicious/Net-Delicious-1.11.tar.gz http://aaronland.info/perl/net/delicious/Changes Cheers,
I am not sure if this is really fixed; it seems to be, but look at line 1030 versus 1009. The "$root" lexical is declared twice in the same scope. It looks like you could nuke any reference to it and just put $self->{__updates} in the catfile call. This turned up because I ran this module with warnings. Do you support 5.5? If not, using warnings in Net::Delicious would have found this during normal testing. -- rjbs
Any status on this? It should be an easy fix, and the warning is quite anoying in the production logs "my" variable $root masks earlier declaration in same scope at /opt/local/lib/perl5/site_perl/5.8.8/Net/Delicious.pm line 1030.
Fixed in N:D 1.13 which is on it's way to the CPAN. In the meantime, you can grab a copy here : http://aaronland.info/perl/net/delicious/Net-Delicious-1.13.tar.gz