Skip Menu |

This queue is for tickets about the IMDB-Film CPAN distribution.

Report information
The Basics
Id: 25560
Status: resolved
Priority: 0/
Queue: IMDB-Film

People
Owner: Nobody in particular
Requestors: clonyara [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.24
Fixed in: 0.24



Subject: bug in IMDB::Film constructor
I used: my $film = new IMDB::Film(crit => 'Dinosaur Planet (2003)', debug => 1, query => 'tt', ); and i got: [DEBUG] CRIT: Dinosaur Planet (2003) at ./convert line 192 [DEBUG] Retrieving page from internet ... at ./convert line 192 [DEBUG] URL is [http://www.imdb.com/find?tt=on;mx=20;q=Dinosaur Planet (2003)]... at ./convert line 192 [DEBUG] Go to search page ... at ./convert line 192 [DEBUG] CRIT: 0389605 at ./convert line 192 [DEBUG] Retrieving page from internet ... at ./convert line 192 [DEBUG] URL is [http://www.imdb.com/tt0389605]... at ./convert line 192 [CRITICAL] Cannot retrieve url [http://www.imdb.com/tt0389605] at ./convert line 192 it is looks like IMDB use http://www.imdb.com/title/tt0389605 URL instead old http://www.imdb.com/tt0389605 my patch for that: --- /usr/lib/perl5/site_perl/5.8.8/IMDB/BaseClass.pm 2007-03-20 07:02:06.000000000 +0200 +++ BaseClass.pm 2007-03-20 08:58:18.435000000 +0200 @@ -369,7 +369,7 @@ sub _content { $self->_show_message("Retrieving page from internet ...", 'DEBUG'); my $url = 'http://'.$self->_host().'/'. - ( $crit =~ /^\d+$/ ? $self->_query() : $self->_search() ).$crit; + ( $crit =~ /^\d+$/ ? 'title/'.$self->_query() : $self->_search() ).$crit; $page = $self->_get_page_from_internet($url); $self->status(FROM_INTERNET); }
Subject: Re: [rt.cpan.org #25560] bug in IMDB::Film constructor
Date: Mon, 26 Mar 2007 15:06:10 +0300
To: bug-IMDB-Film [...] rt.cpan.org
From: "Michael Stepanov" <stepanov.michael [...] gmail.com>
On 3/20/07, Yanik Gleyzer via RT <bug-IMDB-Film@rt.cpan.org> wrote: Show quoted text
> > Tue Mar 20 03:04:57 2007: Request 25560 was acted upon. > Transaction: Ticket created by clonyara > Queue: IMDB-Film > Subject: bug in IMDB::Film constructor > Broken in: 0.24 > Severity: Critical > Owner: Nobody > Requestors: clonyara@gmail.com > Status: new > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=25560 > > > > I used: > my $film = new IMDB::Film(crit => 'Dinosaur Planet (2003)', > debug => 1, > query => 'tt', > );
Well, there is no reason to specify query. Try to do like that: my $film = new IMDB::Film(crit => 'Dinosaur Planet (2003)', debug => 1); Parameter 'query' is mostly service parameter. It needs if IMDB will change it. So, people may pass a new one till it will be fixed in the module. Show quoted text
> and i got: > > [DEBUG] CRIT: Dinosaur Planet (2003) at ./convert line 192 > [DEBUG] Retrieving page from internet ... at ./convert line 192 > [DEBUG] URL is [http://www.imdb.com/find?tt=on;mx=20;q=Dinosaur Planet > (2003)]... at ./convert line 192 > [DEBUG] Go to search page ... at ./convert line 192 > [DEBUG] CRIT: 0389605 at ./convert line 192 > [DEBUG] Retrieving page from internet ... at ./convert line 192 > [DEBUG] URL is [http://www.imdb.com/tt0389605]... at ./convert line 192 > [CRITICAL] Cannot retrieve url [http://www.imdb.com/tt0389605] at > ./convert line 192 > > it is looks like IMDB use http://www.imdb.com/title/tt0389605 URL > instead old http://www.imdb.com/tt0389605 > > > my patch for that: > > --- /usr/lib/perl5/site_perl/5.8.8/IMDB/BaseClass.pm 2007-03-20 > 07:02:06.000000000 +0200 > +++ BaseClass.pm 2007-03-20 08:58:18.435000000 +0200 > @@ -369,7 +369,7 @@ sub _content { > $self->_show_message("Retrieving page > from internet ...", 'DEBUG'); > > my $url = 'http://'.$self->_host().'/'. > - ( $crit =~ /^\d+$/ ? > $self->_query() : $self->_search() ).$crit; > + ( $crit =~ /^\d+$/ ? > 'title/'.$self->_query() : $self->_search() ).$crit; > $page = > $self->_get_page_from_internet($url); > $self->status(FROM_INTERNET); > } > >
-- Best regards, Michael Stepanov, www.stepanoff.org
Actually, it isn't bug. -- Best Regards, Michael Stepanov, Senior Software Developer