Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 25557
Status: resolved
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: sabol [...] alderaan.gsfc.nasa.gov
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: t/20_policy_prohibittrailingwhitespace.t fails on Perl 5.8.0
Perl::Critic 1.04 fails in t/20_policy_prohibittrailingwhitespace.t on Perl 5.8.0 (yeah, I know that's pretty old, but I'm stuck with it) with the following error: Variable "%SPACE" is not imported at t/20_policy_prohibittrailingwhitespace.t line 45. Global symbol "%SPACE" requires explicit package name at t/ 20_policy_prohibittrailingwhitespace.t line 45. Execution of t/20_policy_prohibittrailingwhitespace.t aborted due to compilation errors. # Looks like your test died before it could output anything. t/20_policy_prohibittrailingwhitespace....dubious Test returned status 255 (wstat 65280, 0xff00) DIED. FAILED tests 1-2 Failed 2/2 tests, 0.00% okay The fix is to put a backslash in front of a couple open braces. Here's a patch: --- t/20_policy_prohibittrailingwhitespace.t~ 2007-03-19 22:38:51.000000000 -0400 +++ t/20_policy_prohibittrailingwhitespace.t 2007-03-20 01:58:50.956761000 -0400 @@ -43,8 +43,8 @@ #----------------------------------------------------------------------------- $code = <<"END_PERL"; -sub${SPACE}do_frobnication${SPACE}{ -\tfor${SPACE}(${SPACE}is_frobnicating()${SPACE})${SPACE}{ +sub${SPACE}do_frobnication${SPACE}\{ +\tfor${SPACE}(${SPACE}is_frobnicating()${SPACE})${SPACE}\{ ${SPACE}${SPACE}${SPACE}${SPACE}frobnicate(); \l} }
Subject: Re: [rt.cpan.org #25557] t/20_policy_prohibittrailingwhitespace.t fails on Perl 5.8.0
Date: Mon, 19 Mar 2007 23:40:11 -0700 (PDT)
To: bug-Perl-Critic [...] rt.cpan.org
From: Jeffrey Thalhammer <jeffrey_thalhammer [...] yahoo.com>
Thanks, will fix right away. Can I send you a new build for testing before I send to PAUSE? -Jeff --- "sabol@alderaan.gsfc.nasa.gov via RT" <bug-Perl-Critic@rt.cpan.org> wrote: Show quoted text
> > Tue Mar 20 02:06:32 2007: Request 25557 was acted > upon. > Transaction: Ticket created by > sabol@alderaan.gsfc.nasa.gov > Queue: Perl-Critic > Subject: > t/20_policy_prohibittrailingwhitespace.t fails on > Perl 5.8.0 > Broken in: (no value) > Severity: Normal > Owner: Nobody > Requestors: sabol@alderaan.gsfc.nasa.gov > Status: new > Ticket <URL: > http://rt.cpan.org/Ticket/Display.html?id=25557 > > > > Perl::Critic 1.04 fails in > t/20_policy_prohibittrailingwhitespace.t on Perl > 5.8.0 (yeah, I know > that's pretty old, but I'm stuck with it) with the > following error: > > Variable "%SPACE" is not imported at > t/20_policy_prohibittrailingwhitespace.t line 45. > Global symbol "%SPACE" requires explicit package > name at t/ > 20_policy_prohibittrailingwhitespace.t line 45. > Execution of > t/20_policy_prohibittrailingwhitespace.t aborted due > to compilation errors. > # Looks like your test died before it could output > anything. > t/20_policy_prohibittrailingwhitespace....dubious > > Test returned status 255 (wstat 65280, > 0xff00) > DIED. FAILED tests 1-2 > Failed 2/2 tests, 0.00% okay > > The fix is to put a backslash in front of a couple > open braces. Here's a patch: > > --- t/20_policy_prohibittrailingwhitespace.t~ > 2007-03-19 22:38:51.000000000 -0400 > +++ t/20_policy_prohibittrailingwhitespace.t > 2007-03-20 01:58:50.956761000 -0400 > @@ -43,8 +43,8 @@ > >
#----------------------------------------------------------------------------- Show quoted text
> > $code = <<"END_PERL"; > -sub${SPACE}do_frobnication${SPACE}{ >
-\tfor${SPACE}(${SPACE}is_frobnicating()${SPACE})${SPACE}{ Show quoted text
> +sub${SPACE}do_frobnication${SPACE}\{ >
+\tfor${SPACE}(${SPACE}is_frobnicating()${SPACE})${SPACE}\{ Show quoted text
> ${SPACE}${SPACE}${SPACE}${SPACE}frobnicate(); > \l} > } > >
Show quoted text
____________________________________________________________________________________ Now that's room service! Choose from over 150,000 hotels in 45,000 destinations on Yahoo! Travel to find your fit. http://farechase.yahoo.com/promo-generic-14795097
Fixed and released in Perl-Critic-1.05. Thanks for reporting this. -Jeff